Skip to content

Comments

key2any: free val if string is empty#29317

Closed
npajkovsky wants to merge 1 commit intoopenssl:masterfrom
npajkovsky:coverity
Closed

key2any: free val if string is empty#29317
npajkovsky wants to merge 1 commit intoopenssl:masterfrom
npajkovsky:coverity

Conversation

@npajkovsky
Copy link

key2any_set_ctx_params() calls OSSL_PARAM_get_utf8_string(..., &val, ...) which allocates space, but it never calls free() for a case when string is empty.

Resolves: https://scan5.scan.coverity.com/#/project-view/65138/10222?selectedIssue=1675327

@npajkovsky npajkovsky requested review from jogme and vdukhovni December 5, 2025 10:06
@npajkovsky npajkovsky self-assigned this Dec 5, 2025
@npajkovsky npajkovsky moved this to Waiting Review in Development Board Dec 5, 2025
@t8m t8m added branch: master Applies to master branch approval: review pending This pull request needs review by a committer triaged: bug The issue/pr is/fixes a bug tests: exempted The PR is exempt from requirements for testing labels Dec 5, 2025
@github-project-automation github-project-automation bot moved this from Waiting Review to Waiting Merge in Development Board Dec 5, 2025
@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Dec 5, 2025
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Dec 6, 2025
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@jogme
Copy link
Contributor

jogme commented Dec 8, 2025

Merged to master. Thank you!

@jogme jogme closed this Dec 8, 2025
openssl-machine pushed a commit that referenced this pull request Dec 8, 2025
@github-project-automation github-project-automation bot moved this from Waiting Merge to Done in Development Board Dec 8, 2025
cxx194832 pushed a commit to cxx194832/openssl that referenced this pull request Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Applies to master branch tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

7 participants