Skip to content

Comments

Fix ML-KEM/ML-DSA macro typo#29313

Closed
vdukhovni wants to merge 1 commit intoopenssl:masterfrom
vdukhovni:ml-kem-dsa-mixup
Closed

Fix ML-KEM/ML-DSA macro typo#29313
vdukhovni wants to merge 1 commit intoopenssl:masterfrom
vdukhovni:ml-kem-dsa-mixup

Conversation

@vdukhovni
Copy link

This is largely cosmetic, since the macro expands to "seed" either way, but it is best to avoid this type of error.

Checklist
  • documentation is added or updated
  • tests are added or updated

This is largely cosmetic, since the macro expands to "seed" either way,
but it is best to avoid this type of error.
@kroeckx kroeckx added the approval: review pending This pull request needs review by a committer label Dec 5, 2025
@t8m t8m added branch: master Applies to master branch triaged: bug The issue/pr is/fixes a bug tests: exempted The PR is exempt from requirements for testing labels Dec 5, 2025
@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Dec 5, 2025
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Dec 6, 2025
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@t8m
Copy link
Member

t8m commented Dec 11, 2025

Merged to the master branch. Thank you.

@t8m t8m closed this Dec 11, 2025
openssl-machine pushed a commit that referenced this pull request Dec 11, 2025
This is largely cosmetic, since the macro expands to "seed" either way,
but it is best to avoid this type of error.

Reviewed-by: Kurt Roeckx <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from #29313)
cxx194832 pushed a commit to cxx194832/openssl that referenced this pull request Dec 12, 2025
This is largely cosmetic, since the macro expands to "seed" either way,
but it is best to avoid this type of error.

Reviewed-by: Kurt Roeckx <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from openssl#29313)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Applies to master branch tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants