CMP check_cert_path_3gpp(): add missing checks trying to retrieve newly enrolled cert with PERMIT_TA_IN_EXTRACERTS_FOR_IR#29302
Closed
DDvO wants to merge 1 commit intoopenssl:masterfrom
Closed
Conversation
…ly enrolled cert Fixes openssl#29285
DDvO
added
branch: master
There was a problem hiding this comment.
Pull request overview
This PR fixes missing null checks and improves the check_cert_path_3gpp() function to properly handle retrieval of newly enrolled certificates when the PERMIT_TA_IN_EXTRACERTS_FOR_IR option is enabled.
Key Changes:
- Added message type check to ensure newly enrolled cert validation only runs for IP (Initialization Response) messages
- Improved error handling with proper null checks before attempting to retrieve and validate the newly enrolled certificate
- Enhanced debug logging to indicate when 3GPP mode is used for validation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
The GitHub CI / external-tests-misc (pull_request) failure is unrelated. |
t8m
approved these changes
Dec 4, 2025
esyr
approved these changes
Dec 4, 2025
esyr
added
approval: done
openssl-machine
added
approval: ready to merge
Collaborator
|
This pull request is ready to merge |
openssl-machine
pushed a commit
that referenced
this pull request
Dec 5, 2025
…ly enrolled cert Fixes #29285 Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Eugene Syromiatnikov <[email protected]> (Merged from #29302) (cherry picked from commit 8482cb8)
openssl-machine
pushed a commit
that referenced
this pull request
Dec 5, 2025
…ly enrolled cert Fixes #29285 Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Eugene Syromiatnikov <[email protected]> (Merged from #29302)
openssl-machine
pushed a commit
that referenced
this pull request
Dec 5, 2025
…ly enrolled cert Fixes #29285 Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Eugene Syromiatnikov <[email protected]> (Merged from #29302) (cherry picked from commit 8482cb8)
Contributor
Author
|
Merged to master, 3.6, and 3.5. |
cxx194832
pushed a commit
to cxx194832/openssl
that referenced
this pull request
Dec 12, 2025
…ly enrolled cert Fixes openssl#29285 Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Eugene Syromiatnikov <[email protected]> (Merged from openssl#29302)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29285