Skip to content

Comments

Clang format 3.4#29260

Closed
bob-beck wants to merge 2 commits intoopenssl:openssl-3.4from
bob-beck:clang-format-3.4
Closed

Clang format 3.4#29260
bob-beck wants to merge 2 commits intoopenssl:openssl-3.4from
bob-beck:clang-format-3.4

Conversation

@bob-beck
Copy link
Contributor

@bob-beck bob-beck commented Nov 28, 2025

clang format 3.4

For openssl/project#1741
!--
Thank you for your pull request. Please review these requirements:

Contributors guide: https://github.com/openssl/openssl/blob/master/CONTRIBUTING.md

Other than that, provide a description above this comment if there isn't one already

If this fixes a GitHub issue, make sure to have a line saying 'Fixes #XXXX' (without quotes) in the commit message.
-->

Checklist
  • documentation is added or updated
  • tests are added or updated

@github-actions github-actions bot added the severity: fips change The pull request changes FIPS provider sources label Nov 28, 2025
@bob-beck bob-beck requested review from Sashan, nhorman and npajkovsky and removed request for Sashan, nhorman and npajkovsky December 1, 2025 17:26
@bob-beck bob-beck marked this pull request as ready for review December 2, 2025 16:46
@bob-beck bob-beck force-pushed the clang-format-3.4 branch 2 times, most recently from 22a17c2 to 4d6dba5 Compare December 9, 2025 09:52
@jogme jogme added approval: done This pull request has the required number of approvals approval: ready to merge The 24 hour grace period has passed, ready to merge labels Dec 9, 2025
Copy link
Contributor

@Sashan Sashan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

openssl-machine pushed a commit that referenced this pull request Dec 9, 2025
Reviewed-by: Saša Nedvědický <[email protected]>
Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Norbert Pocs <[email protected]>
(Merged from #29260)
openssl-machine pushed a commit that referenced this pull request Dec 9, 2025
Reviewed-by: Saša Nedvědický <[email protected]>
Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Norbert Pocs <[email protected]>
(Merged from #29260)
@nhorman
Copy link
Contributor

nhorman commented Dec 9, 2025

merged to 3.4, thank you!

@nhorman nhorman closed this Dec 9, 2025
openssl-machine pushed a commit that referenced this pull request Jan 27, 2026
3.4.4 CHANGES.md includes the following:
 * #28760
   "Improve the CPUINFO display for RISC-V"
 * #29214
   "s390x: Check and fail on invalid malformed ECDSA signatures"
 * #29260
   "Clang format 3.4"

Co-Authored-by: Tomáš Mráz <[email protected]>
Signed-off-by: Eugene Syromiatnikov <[email protected]>

Reviewed-by: Saša Nedvědický <[email protected]>
Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
MergeDate: Mon Jan 26 20:04:13 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval: done This pull request has the required number of approvals approval: ready to merge The 24 hour grace period has passed, ready to merge severity: fips change The pull request changes FIPS provider sources

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Freeze/Unfreeze tree and land clang-format changes Dec 9.

4 participants