Closed
Conversation
bob-beck
force-pushed
the
clang-format-head
branch
2 times, most recently
from
0cb397a to
b21a693
Compare
github-actions
bot
added
the
severity: fips change
Contributor
Author
|
grumph.. how the heck is the sparc64v9 perlasm breaking? I don't think this touches any of that. |
Contributor
Author
Oh god, I found it. Going to get garlic, stakes and holy water. pray for me. |
bob-beck
force-pushed
the
clang-format-head
branch
3 times, most recently
from
ef4cb66 to
1e4c9c2
Compare
2 tasks
|
Do we really want this style? int ASN1_TYPE_set_int_octetstring(ASN1_TYPE *a, long num,
- unsigned char *data, int len);
+ unsigned char *data, int len);I would definitely tweak this option. |
Member
|
Please also consider #28691 (comment) |
bob-beck
force-pushed
the
clang-format-head
branch
3 times, most recently
from
d894169 to
528c18d
Compare
bob-beck
force-pushed
the
clang-format-head
branch
from
528c18d to
263d1d3
Compare
bob-beck
force-pushed
the
clang-format-head
branch
from
263d1d3 to
7e36277
Compare
nhorman
added
severity: urgent
npajkovsky
approved these changes
Dec 9, 2025
nhorman
approved these changes
Dec 9, 2025
Sashan
added
the
approval: done
nhorman
added
approval: ready to merge
openssl-machine
pushed a commit
that referenced
this pull request
Dec 9, 2025
Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Nikola Pajkovsky <[email protected]> (Merged from #29242)
openssl-machine
pushed a commit
that referenced
this pull request
Dec 9, 2025
Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Nikola Pajkovsky <[email protected]> (Merged from #29242)
Contributor
|
merged to master, thank you all! |
cxx194832
pushed a commit
to cxx194832/openssl
that referenced
this pull request
Dec 12, 2025
Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Nikola Pajkovsky <[email protected]> (Merged from openssl#29242)
cxx194832
pushed a commit
to cxx194832/openssl
that referenced
this pull request
Dec 12, 2025
Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Nikola Pajkovsky <[email protected]> (Merged from openssl#29242)
abajk
reviewed
Jan 24, 2026
| MIDR_IS_CPU_MODEL(OPENSSL_arm_midr, ARM_CPU_IMP_ARM, ARM_CPU_PART_V3) || | ||
| MIDR_IMPLEMENTER(OPENSSL_arm_midr) == ARM_CPU_IMP_AMPERE) && | ||
| (OPENSSL_armcap_P & ARMV8_SHA3)) | ||
| if ((MIDR_IS_CPU_MODEL(OPENSSL_arm_midr, ARM_CPU_IMP_ARM, ARM_CPU_PART_V1) || MIDR_IS_CPU_MODEL(OPENSSL_arm_midr, ARM_CPU_IMP_ARM, ARM_CPU_PART_N2) || MIDR_IS_CPU_MODEL(OPENSSL_arm_midr, ARM_CPU_IMP_QCOMM, QCOM_CPU_PART_ORYON_X1) || MIDR_IS_CPU_MODEL(OPENSSL_arm_midr, ARM_CPU_IMP_MICROSOFT, MICROSOFT_CPU_PART_COBALT_100) || MIDR_IS_CPU_MODEL(OPENSSL_arm_midr, ARM_CPU_IMP_ARM, ARM_CPU_PART_V2) || MIDR_IS_CPU_MODEL(OPENSSL_arm_midr, ARM_CPU_IMP_ARM, ARM_CPU_PART_N3) || MIDR_IS_CPU_MODEL(OPENSSL_arm_midr, ARM_CPU_IMP_ARM, ARM_CPU_PART_V3_AE) || MIDR_IS_CPU_MODEL(OPENSSL_arm_midr, ARM_CPU_IMP_ARM, ARM_CPU_PART_V3) || MIDR_IMPLEMENTER(OPENSSL_arm_midr) == ARM_CPU_IMP_AMPERE) && (OPENSSL_armcap_P & ARMV8_SHA3)) |
Contributor
There was a problem hiding this comment.
These super long lines are now unreadable :/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be the day-of-change PR - it will remain draft until that day as it will be constantly
redone to test until the tree is frozen
It contains the changes in the preparatory commit pr ( #29241 ) and will be rebased
once that lands.
The last four commits in this stack is what will be left. On the day of, I believe the first two should
be merged, then the last two should be squashed together and merged as one.
The reason for squashing the last two is to get one commit hash that then must be added to
the top level .git-blame-ignore-revs, as this will be the reformatting commit nobody wants
to see in git blame.
1741
Checklist