Skip to content

Comments

doc/man3: Add OPENSSL_ppccap.pod#29230

Closed
gcwilson wants to merge 1 commit intoopenssl:masterfrom
gcwilson:feature/OPENSSL_ppccap-manpage
Closed

doc/man3: Add OPENSSL_ppccap.pod#29230
gcwilson wants to merge 1 commit intoopenssl:masterfrom
gcwilson:feature/OPENSSL_ppccap-manpage

Conversation

@gcwilson
Copy link

This patch adds a man page documenting the OPENSSL_ppccap environment variable that is analogous to capability environment variable man pages for other architectures.

Fixes #17046

Checklist
  • documentation is added or updated

@kroeckx
Copy link
Member

kroeckx commented Nov 27, 2025

Can you update openssl-env.pod and openssl.pod to add a reference to the new file?

@gcwilson gcwilson force-pushed the feature/OPENSSL_ppccap-manpage branch 2 times, most recently from f39bf9f to e064f45 Compare December 1, 2025 16:53
beldmit
beldmit previously approved these changes Dec 1, 2025
Copy link
Member

@beldmit beldmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beldmit beldmit added branch: master Applies to master branch approval: review pending This pull request needs review by a committer triaged: documentation The issue/pr deals with documentation (errors) labels Dec 1, 2025
paulidale
paulidale previously approved these changes Dec 1, 2025
@paulidale
Copy link
Contributor

I'm okay to back port this to relevant branches.

@paulidale paulidale added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Dec 1, 2025
@gcwilson gcwilson dismissed stale reviews from paulidale and beldmit via 38f221a December 2, 2025 15:31
@gcwilson gcwilson force-pushed the feature/OPENSSL_ppccap-manpage branch from e064f45 to 38f221a Compare December 2, 2025 15:31
@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests. Once the tests pass it will get moved to 'approval: ready to merge' automatically,alternatively please review and set the label manually.

This patch adds a man page documenting the OPENSSL_ppccap environment
variable that is analogous to capability environment variable man pages
for other architectures.

Fixes openssl#17046

Signed-off-by: George Wilson <[email protected]>
@gcwilson gcwilson force-pushed the feature/OPENSSL_ppccap-manpage branch from 38f221a to 0f71207 Compare December 2, 2025 22:52
@paulidale paulidale added approval: review pending This pull request needs review by a committer and removed approval: done This pull request has the required number of approvals labels Dec 2, 2025
@jogme jogme requested review from beldmit and esyr December 8, 2025 14:58
Copy link
Member

@beldmit beldmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beldmit beldmit added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Dec 8, 2025
@beldmit
Copy link
Member

beldmit commented Dec 8, 2025

I wouldn't mind if it is backported, however

@github-actions github-actions bot added severity: fips change The pull request changes FIPS provider sources severity: ABI change This pull request contains ABI changes labels Dec 8, 2025
@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

Copy link
Member

@esyr esyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Multiple extensions are enabled by logically OR-ing the values that represent the
desired extensions.

B<Notes>: Enabling an extension on a CPU that does not support the extension
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant a separate =head1 NOTES, but oh well.

@esyr esyr added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Dec 10, 2025
@t8m t8m added tests: exempted The PR is exempt from requirements for testing branch: 3.5 Applies to openssl-3.5 branch: 3.6 Applies to openssl-3.6 labels Dec 11, 2025
@t8m t8m closed this Dec 11, 2025
@t8m t8m reopened this Dec 11, 2025
openssl-machine pushed a commit that referenced this pull request Dec 11, 2025
This patch adds a man page documenting the OPENSSL_ppccap environment
variable that is analogous to capability environment variable man pages
for other architectures.

Fixes #17046

Signed-off-by: George Wilson <[email protected]>

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Dmitry Belyavskiy <[email protected]>
Reviewed-by: Eugene Syromiatnikov <[email protected]>
(Merged from #29230)
openssl-machine pushed a commit that referenced this pull request Dec 11, 2025
This patch adds a man page documenting the OPENSSL_ppccap environment
variable that is analogous to capability environment variable man pages
for other architectures.

Fixes #17046

Signed-off-by: George Wilson <[email protected]>

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Dmitry Belyavskiy <[email protected]>
Reviewed-by: Eugene Syromiatnikov <[email protected]>
(Merged from #29230)

(cherry picked from commit ba26e3f)
@t8m
Copy link
Member

t8m commented Dec 11, 2025

Merged to the master, 3.6 and 3.5 branches. Thank you for your contribution.

@t8m t8m closed this Dec 11, 2025
openssl-machine pushed a commit that referenced this pull request Dec 11, 2025
This patch adds a man page documenting the OPENSSL_ppccap environment
variable that is analogous to capability environment variable man pages
for other architectures.

Fixes #17046

Signed-off-by: George Wilson <[email protected]>

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Dmitry Belyavskiy <[email protected]>
Reviewed-by: Eugene Syromiatnikov <[email protected]>
(Merged from #29230)

(cherry picked from commit ba26e3f)
@github-actions github-actions bot removed severity: fips change The pull request changes FIPS provider sources severity: ABI change This pull request contains ABI changes labels Dec 11, 2025
cxx194832 pushed a commit to cxx194832/openssl that referenced this pull request Dec 12, 2025
This patch adds a man page documenting the OPENSSL_ppccap environment
variable that is analogous to capability environment variable man pages
for other architectures.

Fixes openssl#17046

Signed-off-by: George Wilson <[email protected]>

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Dmitry Belyavskiy <[email protected]>
Reviewed-by: Eugene Syromiatnikov <[email protected]>
(Merged from openssl#29230)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Applies to master branch branch: 3.5 Applies to openssl-3.5 branch: 3.6 Applies to openssl-3.6 tests: exempted The PR is exempt from requirements for testing triaged: documentation The issue/pr deals with documentation (errors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document OPENSSL_ppccap environment variable

7 participants