Skip to content

Comments

Start the 4.0 migration guide#29220

Closed
bob-beck wants to merge 4 commits intoopenssl:masterfrom
bob-beck:function-removal
Closed

Start the 4.0 migration guide#29220
bob-beck wants to merge 4 commits intoopenssl:masterfrom
bob-beck:function-removal

Conversation

@bob-beck
Copy link
Contributor

@bob-beck bob-beck commented Nov 25, 2025

This includes adding a little internal procedure for when functions are removed, and a special ossl-ex-api page to document what API has been removed.

Starts 1610

Checklist
  • documentation is added or updated
  • tests are added or updated

@bob-beck bob-beck force-pushed the function-removal branch 2 times, most recently from 0a124af to a96b5ef Compare November 25, 2025 19:43
@bob-beck bob-beck requested review from esyr, jogme and t8m November 25, 2025 19:44
@bob-beck bob-beck marked this pull request as ready for review November 25, 2025 19:44
@bob-beck bob-beck force-pushed the function-removal branch 3 times, most recently from c96babb to 0b35d51 Compare November 25, 2025 20:19
Copy link
Member

@slontis slontis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe ossl-removed-api.pod as the name??

'ex' is what we tack onto new API's with the same name, so this is not a great name.

@bob-beck
Copy link
Contributor Author

Maybe ossl-removed-api.pod as the name??

'ex' is what we tack onto new API's with the same name, so this is not a great name.

yeah, I know. I just couldn't stop the monty python skit playing in my head...

@bob-beck
Copy link
Contributor Author

bob-beck commented Nov 28, 2025

Maybe ossl-removed-api.pod as the name??

'ex' is what we tack onto new API's with the same name, so this is not a great name.

Changed to ossl-removed-api.pod.

@bob-beck bob-beck requested a review from slontis November 28, 2025 21:22
mattcaswell
mattcaswell previously approved these changes Dec 2, 2025
@t8m t8m added branch: master Applies to master branch approval: review pending This pull request needs review by a committer triaged: documentation The issue/pr deals with documentation (errors) tests: exempted The PR is exempt from requirements for testing labels Dec 3, 2025
This includes adding a little internal procedure for when functions
are removed, and a special ossl-ex-api page to document what API has
been removed.
Copy link
Contributor

@jogme jogme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@jogme jogme added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Dec 4, 2025
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Dec 5, 2025
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@t8m
Copy link
Member

t8m commented Dec 5, 2025

Merged to the master branch. Thank you.

@t8m t8m closed this Dec 5, 2025
openssl-machine pushed a commit that referenced this pull request Dec 5, 2025
This includes adding a little internal procedure for when functions
are removed, and a special ossl-ex-api page to document what API has
been removed.

Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Norbert Pocs <[email protected]>
(Merged from #29220)
cxx194832 pushed a commit to cxx194832/openssl that referenced this pull request Dec 12, 2025
This includes adding a little internal procedure for when functions
are removed, and a special ossl-ex-api page to document what API has
been removed.

Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Norbert Pocs <[email protected]>
(Merged from openssl#29220)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Applies to master branch tests: exempted The PR is exempt from requirements for testing triaged: documentation The issue/pr deals with documentation (errors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants