Make engine permanent disable and clean engine test configs#29219
Closed
mbroz wants to merge 3 commits intoopenssl:feature/engineremovalfrom
Closed
Make engine permanent disable and clean engine test configs#29219mbroz wants to merge 3 commits intoopenssl:feature/engineremovalfrom
mbroz wants to merge 3 commits intoopenssl:feature/engineremovalfrom
Conversation
Member
Author
|
ok, apparently it needs also CI modifications.... |
This was
linked to
issues
Nov 25, 2025
mbroz
force-pushed
the
engine-pernament-disable
branch
from
a6c1c19 to
74cf9af
Compare
2 tasks
jogme
requested changes
Nov 26, 2025
mbroz
force-pushed
the
engine-pernament-disable
branch
from
74cf9af to
ff84a46
Compare
jogme
approved these changes
Nov 26, 2025
Contributor
jogme
left a comment
jogme
left a comment
There was a problem hiding this comment.
The %deprecated_disablables will warn if the option is used, but the config will not fail. The presence in %disabled and the cascade later will create the macros OPENSSL_NO_[STATIC|DYNAMIC]_ENGINE. no-engine, no-static-engine and no-dynamic-engine will always be defined.
Not sure if we need to document no static and dynamic engine presence. Otherwise LGTM, thanks!
mbroz
changed the title
Sashan
added
approval: done
openssl-machine
added
approval: ready to merge
Collaborator
|
This pull request is ready to merge |
openssl-machine
force-pushed
the
feature/engineremoval
branch
from
b1efec7 to
90e2bc1
Compare
As engines are no longer included in test, these configuration options make no longer sense. All other test should be already enabled. Fixes openssl/project#1376 Signed-off-by: Milan Broz <[email protected]>
It enables configuration defines: OPENSSL_NO_DYNAMIC_ENGINE OPENSSL_NO_STATIC_ENGINE OPENSSL_NO_ENGINE Fixes openssl/project#1711 Signed-off-by: Milan Broz <[email protected]>
Signed-off-by: Milan Broz <[email protected]>
mbroz
force-pushed
the
engine-pernament-disable
branch
from
ff84a46 to
3758d8b
Compare
openssl-machine
pushed a commit
that referenced
this pull request
Dec 2, 2025
As engines are no longer included in test, these configuration options make no longer sense. All other test should be already enabled. Fixes openssl/project#1376 Signed-off-by: Milan Broz <[email protected]> Reviewed-by: Norbert Pocs <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> (Merged from #29219)
openssl-machine
pushed a commit
that referenced
this pull request
Dec 2, 2025
It enables configuration defines: OPENSSL_NO_DYNAMIC_ENGINE OPENSSL_NO_STATIC_ENGINE OPENSSL_NO_ENGINE Fixes openssl/project#1711 Signed-off-by: Milan Broz <[email protected]> Reviewed-by: Norbert Pocs <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> (Merged from #29219)
openssl-machine
pushed a commit
that referenced
this pull request
Dec 2, 2025
Signed-off-by: Milan Broz <[email protected]> Reviewed-by: Norbert Pocs <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> (Merged from #29219)
Contributor
|
looks like the openssl-machine pushed the commit already. closing PR |
mbroz
added a commit
to mbroz/openssl
that referenced
this pull request
Dec 4, 2025
As engines are no longer included in test, these configuration options make no longer sense. All other test should be already enabled. Fixes openssl/project#1376 Signed-off-by: Milan Broz <[email protected]> Reviewed-by: Norbert Pocs <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> (Merged from openssl#29219)
mbroz
added a commit
to mbroz/openssl
that referenced
this pull request
Dec 4, 2025
It enables configuration defines: OPENSSL_NO_DYNAMIC_ENGINE OPENSSL_NO_STATIC_ENGINE OPENSSL_NO_ENGINE Fixes openssl/project#1711 Signed-off-by: Milan Broz <[email protected]> Reviewed-by: Norbert Pocs <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> (Merged from openssl#29219)
mbroz
added a commit
to mbroz/openssl
that referenced
this pull request
Dec 4, 2025
Signed-off-by: Milan Broz <[email protected]> Reviewed-by: Norbert Pocs <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> (Merged from openssl#29219)
nhorman
pushed a commit
to nhorman/openssl
that referenced
this pull request
Dec 4, 2025
As engines are no longer included in test, these configuration options make no longer sense. All other test should be already enabled. Fixes openssl/project#1376 Signed-off-by: Milan Broz <[email protected]> Reviewed-by: Norbert Pocs <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> (Merged from openssl#29219)
nhorman
pushed a commit
to nhorman/openssl
that referenced
this pull request
Dec 4, 2025
It enables configuration defines: OPENSSL_NO_DYNAMIC_ENGINE OPENSSL_NO_STATIC_ENGINE OPENSSL_NO_ENGINE Fixes openssl/project#1711 Signed-off-by: Milan Broz <[email protected]> Reviewed-by: Norbert Pocs <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> (Merged from openssl#29219)
nhorman
pushed a commit
to nhorman/openssl
that referenced
this pull request
Dec 4, 2025
Signed-off-by: Milan Broz <[email protected]> Reviewed-by: Norbert Pocs <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> (Merged from openssl#29219)
mbroz
added a commit
to mbroz/openssl
that referenced
this pull request
Dec 4, 2025
As engines are no longer included in test, these configuration options make no longer sense. All other test should be already enabled. Fixes openssl/project#1376 Signed-off-by: Milan Broz <[email protected]> Reviewed-by: Norbert Pocs <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> (Merged from openssl#29219)
mbroz
added a commit
to mbroz/openssl
that referenced
this pull request
Dec 4, 2025
It enables configuration defines: OPENSSL_NO_DYNAMIC_ENGINE OPENSSL_NO_STATIC_ENGINE OPENSSL_NO_ENGINE Fixes openssl/project#1711 Signed-off-by: Milan Broz <[email protected]> Reviewed-by: Norbert Pocs <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> (Merged from openssl#29219)
mbroz
added a commit
to mbroz/openssl
that referenced
this pull request
Dec 4, 2025
Signed-off-by: Milan Broz <[email protected]> Reviewed-by: Norbert Pocs <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> (Merged from openssl#29219)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not allow usert to reenable engines but set proper defines in configuration.h.
Also remove all engine build configurations as the code is gone. The test no longe contains engine as well.
(pls check if Configure is not setup correctly, it is kind of magic...)