Updating the Client's parsing of the Cert Status Body#29207
Closed
rsith71 wants to merge 3 commits intoopenssl:masterfrom
Closed
Updating the Client's parsing of the Cert Status Body#29207rsith71 wants to merge 3 commits intoopenssl:masterfrom
rsith71 wants to merge 3 commits intoopenssl:masterfrom
Conversation
1 task
mattcaswell
previously approved these changes
Nov 24, 2025
mattcaswell
added
branch: master
1 task
t8m
added
triaged: bug
bob-beck
approved these changes
Nov 25, 2025
ssl/statem/statem_clnt.c
Outdated
| } | ||
| p = respder; | ||
| resp = d2i_OCSP_RESPONSE(NULL, &p, (long)resplen); | ||
| if (respder == NULL) { |
Contributor
There was a problem hiding this comment.
nit: consider if ((respder = OPENSSL_malloc(resplen)) == NULL) {
When a Cert status body is received and the length of the response is zero error out. This PR is dependent on openssl#28955 It will not pass tests until this PR is merged into master.
rsith71
force-pushed
the
multi_ocsp_fix_receiver
branch
from
986a9d2 to
1c9d986
Compare
t8m
requested changes
Dec 2, 2025
ssl/statem/statem_clnt.c
Outdated
Comment on lines
2950
to
2951
| ; | ||
|
|
Member
There was a problem hiding this comment.
Please remove these two spurious lines.
mattcaswell
approved these changes
Dec 2, 2025
t8m
approved these changes
Dec 2, 2025
t8m
added
approval: done
openssl-machine
added
approval: ready to merge
Collaborator
|
This pull request is ready to merge |
openssl-machine
pushed a commit
that referenced
this pull request
Dec 3, 2025
When a CertStatus message is received and the length of the OCSP response is zero error out. Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from #29207)
openssl-machine
pushed a commit
that referenced
this pull request
Dec 3, 2025
When a CertStatus message is received and the length of the OCSP response is zero error out. Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from #29207) (cherry picked from commit ccd8451)
Member
|
Merged to the master and 3.6 branches with tweaked commit message. Thank you. |
cxx194832
pushed a commit
to cxx194832/openssl
that referenced
this pull request
Dec 12, 2025
When a CertStatus message is received and the length of the OCSP response is zero error out. Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from openssl#29207)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a Cert status body is received and the length of the response is zero error out.
This PR is dependent on
#28955
It will not pass tests until this PR is merged into master.
Checklist