dtls: fix DTLSv1_listen msg_callback to report HelloVerifyRequest#28916
Closed
MegaManSec wants to merge 1 commit intoopenssl:masterfrom
Closed
dtls: fix DTLSv1_listen msg_callback to report HelloVerifyRequest#28916MegaManSec wants to merge 1 commit intoopenssl:masterfrom
MegaManSec wants to merge 1 commit intoopenssl:masterfrom
Conversation
Contributor
|
ping @mattcaswell DTLSv1 is not my department, will appreciate if you take a look. thanks. |
fwh-dc
added
branch: master
mattcaswell
previously approved these changes
Oct 16, 2025
mattcaswell
added
approval: done
openssl-machine
added
approval: ready to merge
Collaborator
|
This pull request is ready to merge |
t8m
added
triaged: feature
Member
|
As there is now a conflict, can you please rebase this? |
DTLSv1_listen built the HelloVerifyRequest in wbuf but invoked msg_callback with buf and DTLS1_RT_HEADER_LENGTH, and version 0. That caused incorrect logging and could disclose the ClientHello to write callbacks. Use wbuf and the actual record version for the record header, and add a second callback that reports the handshake message bytes. No change to on-wire behavior. Signed-off-by: Joshua Rogers <[email protected]>
fwh-dc
approved these changes
Oct 20, 2025
Contributor
fwh-dc
left a comment
fwh-dc
left a comment
There was a problem hiding this comment.
Failed CI job is irrelevant.
Collaborator
|
This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago |
Contributor
|
ping @mattcaswell for re-approval |
mattcaswell
approved these changes
Dec 8, 2025
mattcaswell
added
approval: done
openssl-machine
added
approval: ready to merge
Collaborator
|
This pull request is ready to merge |
Member
|
Merged to the master branch after applying clang-format. Thank you for your contribution. |
openssl-machine
pushed a commit
that referenced
this pull request
Dec 11, 2025
DTLSv1_listen built the HelloVerifyRequest in wbuf but invoked msg_callback with buf and DTLS1_RT_HEADER_LENGTH, and version 0. That caused incorrect logging and could disclose the ClientHello to write callbacks. Use wbuf and the actual record version for the record header, and add a second callback that reports the handshake message bytes. No change to on-wire behavior. Signed-off-by: Joshua Rogers <[email protected]> Reviewed-by: Frederik Wedel-Heinen <[email protected]> Reviewed-by: Matt Caswell <[email protected]> (Merged from #28916)
cxx194832
pushed a commit
to cxx194832/openssl
that referenced
this pull request
Dec 12, 2025
DTLSv1_listen built the HelloVerifyRequest in wbuf but invoked msg_callback with buf and DTLS1_RT_HEADER_LENGTH, and version 0. That caused incorrect logging and could disclose the ClientHello to write callbacks. Use wbuf and the actual record version for the record header, and add a second callback that reports the handshake message bytes. No change to on-wire behavior. Signed-off-by: Joshua Rogers <[email protected]> Reviewed-by: Frederik Wedel-Heinen <[email protected]> Reviewed-by: Matt Caswell <[email protected]> (Merged from openssl#28916)
Member
|
This should also be back-ported like #28816 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DTLSv1_listen built the HelloVerifyRequest in wbuf but invoked msg_callback with buf and DTLS1_RT_HEADER_LENGTH, and version 0. That caused incorrect logging and could disclose the ClientHello to write callbacks. Use wbuf and the actual record version for the record header, and add a second callback that reports the handshake message bytes. No change to on-wire behavior.