Skip to content

Comments

freebsd ktls: avoid unaligned 16 bit length store in ktls_read_record#28860

Closed
MegaManSec wants to merge 1 commit intoopenssl:masterfrom
MegaManSec:23
Closed

freebsd ktls: avoid unaligned 16 bit length store in ktls_read_record#28860
MegaManSec wants to merge 1 commit intoopenssl:masterfrom
MegaManSec:23

Conversation

@MegaManSec
Copy link
Contributor

@MegaManSec MegaManSec commented Oct 11, 2025

This prevents SIGBUS on strict alignment architectures when p+3 is not aligned for 16 bit access. Behavior is unchanged on x86 and matches the Linux path.

@MegaManSec
freebsd ktls: avoid unaligned 16 bit length store in ktls_read_record
6ea5da5 
This prevents SIGBUS on strict alignment architectures when p+3 is not aligned
for 16 bit access. Behavior is unchanged on x86 and matches the Linux path.

Signed-off-by: Joshua Rogers <[email protected]>
Sashan
Sashan reviewed Oct 13, 2025
View reviewed changes
Copy link
Contributor

@Sashan Sashan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change has no effect. do you have a crashdump triggered by SIGBUS? also what platform is on your mind here?

@MegaManSec
Copy link
Contributor Author

MegaManSec commented Oct 14, 2025

what platform is on your mind here?

ARM FreeBSD, mostly.

This is already done in the Linux path, here, seemingly because (p+3) is not guaranteed to be aigned for uint16_t. it's just an UB fix. can be closed if it's not wanted

t8m
t8m approved these changes Oct 14, 2025
View reviewed changes
Copy link
Member

@t8m t8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is better than the current code.

@t8m t8m added branch: master Applies to master branch approval: review pending This pull request needs review by a committer triaged: bug The issue/pr is/fixes a bug branch: 3.0 Applies to openssl-3.0 branch tests: exempted The PR is exempt from requirements for testing branch: 3.2 Applies to openssl-3.2 (EOL) branch: 3.3 Applies to openssl-3.3 branch: 3.4 Applies to openssl-3.4 branch: 3.5 Applies to openssl-3.5 branch: 3.6 Applies to openssl-3.6 labels Oct 14, 2025
@t8m t8m closed this Oct 14, 2025
@t8m t8m reopened this Oct 14, 2025
@mattcaswell mattcaswell added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Oct 14, 2025
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Oct 15, 2025
@openssl-machine
Copy link
Collaborator

openssl-machine commented Oct 15, 2025

This pull request is ready to merge

@t8m
Copy link
Member

t8m commented Oct 17, 2025

Merged to all the active branches. Thank you for your contribution.

openssl-machine pushed a commit that referenced this pull request Oct 17, 2025
@MegaManSec @t8m
freebsd ktls: avoid unaligned 16 bit length store in ktls_read_record
c33120d 
This prevents SIGBUS on strict alignment architectures when p+3 is not aligned
for 16 bit access. Behavior is unchanged on x86 and matches the Linux path.

Signed-off-by: Joshua Rogers <[email protected]>

Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from #28860)
@t8m t8m closed this Oct 17, 2025
openssl-machine pushed a commit that referenced this pull request Oct 17, 2025
@MegaManSec @t8m
freebsd ktls: avoid unaligned 16 bit length store in ktls_read_record
abc5079 
This prevents SIGBUS on strict alignment architectures when p+3 is not aligned
for 16 bit access. Behavior is unchanged on x86 and matches the Linux path.

Signed-off-by: Joshua Rogers <[email protected]>

Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from #28860)

(cherry picked from commit c33120d)
openssl-machine pushed a commit that referenced this pull request Oct 17, 2025
@MegaManSec @t8m
freebsd ktls: avoid unaligned 16 bit length store in ktls_read_record
a59b9de 
This prevents SIGBUS on strict alignment architectures when p+3 is not aligned
for 16 bit access. Behavior is unchanged on x86 and matches the Linux path.

Signed-off-by: Joshua Rogers <[email protected]>

Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from #28860)

(cherry picked from commit c33120d)
openssl-machine pushed a commit that referenced this pull request Oct 17, 2025
@MegaManSec @t8m
freebsd ktls: avoid unaligned 16 bit length store in ktls_read_record
749049f 
This prevents SIGBUS on strict alignment architectures when p+3 is not aligned
for 16 bit access. Behavior is unchanged on x86 and matches the Linux path.

Signed-off-by: Joshua Rogers <[email protected]>

Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from #28860)

(cherry picked from commit c33120d)
openssl-machine pushed a commit that referenced this pull request Oct 17, 2025
@MegaManSec @t8m
freebsd ktls: avoid unaligned 16 bit length store in ktls_read_record
47b4851 
This prevents SIGBUS on strict alignment architectures when p+3 is not aligned
for 16 bit access. Behavior is unchanged on x86 and matches the Linux path.

Signed-off-by: Joshua Rogers <[email protected]>

Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from #28860)

(cherry picked from commit c33120d)
openssl-machine pushed a commit that referenced this pull request Oct 17, 2025
@MegaManSec @t8m
freebsd ktls: avoid unaligned 16 bit length store in ktls_read_record
4327b93 
This prevents SIGBUS on strict alignment architectures when p+3 is not aligned
for 16 bit access. Behavior is unchanged on x86 and matches the Linux path.

Signed-off-by: Joshua Rogers <[email protected]>

Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from #28860)

(cherry picked from commit c33120d)
openssl-machine pushed a commit that referenced this pull request Oct 17, 2025
@MegaManSec @t8m
freebsd ktls: avoid unaligned 16 bit length store in ktls_read_record
22233f1 
This prevents SIGBUS on strict alignment architectures when p+3 is not aligned
for 16 bit access. Behavior is unchanged on x86 and matches the Linux path.

Signed-off-by: Joshua Rogers <[email protected]>

Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from #28860)

(cherry picked from commit c33120d)
MegaManSec added a commit to MegaManSec/openssl that referenced this pull request Nov 11, 2025
@MegaManSec
freebsd ktls: avoid unaligned 16 bit length store in ktls_read_record
a247136 
This prevents SIGBUS on strict alignment architectures when p+3 is not aligned
for 16 bit access. Behavior is unchanged on x86 and matches the Linux path.

Signed-off-by: Joshua Rogers <[email protected]>

Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from openssl#28860)
@MegaManSec MegaManSec mentioned this pull request Dec 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sashan Sashan Sashan left review comments

@t8m t8m t8m approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

Assignees

No one assigned

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Applies to master branch branch: 3.0 Applies to openssl-3.0 branch branch: 3.2 Applies to openssl-3.2 (EOL) branch: 3.3 Applies to openssl-3.3 branch: 3.4 Applies to openssl-3.4 branch: 3.5 Applies to openssl-3.5 branch: 3.6 Applies to openssl-3.6 tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MegaManSec @openssl-machine @t8m @Sashan @mattcaswell