Remove ENGINESDIR variable and engines installation from Makefiles.#28702
Closed
mbroz wants to merge 1 commit intoopenssl:feature/engineremovalfrom
Closed
Remove ENGINESDIR variable and engines installation from Makefiles.#28702mbroz wants to merge 1 commit intoopenssl:feature/engineremovalfrom
mbroz wants to merge 1 commit intoopenssl:feature/engineremovalfrom
Conversation
github-actions
bot
added
the
severity: fips change
mbroz
force-pushed
the
remove-engine-install
branch
from
becc38f to
b905f3c
Compare
t8m
added
approval: review pending
t8m
approved these changes
Oct 1, 2025
mbroz
force-pushed
the
remove-engine-install
branch
from
b905f3c to
c42346f
Compare
t8m
approved these changes
Oct 1, 2025
Sashan
approved these changes
Oct 1, 2025
Contributor
Sashan
left a comment
Sashan
left a comment
There was a problem hiding this comment.
looks good to me with/or without the nit pointed out here addressed.
Sashan
added
approval: done
jogme
requested changes
Oct 1, 2025
Contributor
jogme
left a comment
jogme
left a comment
There was a problem hiding this comment.
The ENGINESDIR remained in some windows github workflows. Can they be also removed?
For compatibility reasons, OPENSSL_ENGINES_DIR and OPENSSL_INFO_ENGINES_DIR are still supported but return values like with engines disabled. The OPENSSL_ENGINES environment variable will be removed with engine removal later. Resolves: openssl/project#1425 Signed-off-by: Milan Broz <[email protected]>
mbroz
force-pushed
the
remove-engine-install
branch
from
c42346f to
8043bca
Compare
Member
Author
|
One update, I forgot to remove regedit entries in .github scripts (thanks @jogme) . Perpahs the whole registry things shuld be kept separatery for later (with environment variable), but guess it can go away even in this part. |
Collaborator
|
24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually. |
t8m
approved these changes
Oct 2, 2025
Member
|
@Sashan still OK? If so, please merge (or I'll do it). |
Contributor
still looks good ot me. |
t8m
added
approval: ready to merge
openssl-machine
pushed a commit
that referenced
this pull request
Oct 2, 2025
For compatibility reasons, OPENSSL_ENGINES_DIR and OPENSSL_INFO_ENGINES_DIR are still supported but return values like with engines disabled. The OPENSSL_ENGINES environment variable will be removed with engine removal later. Resolves: openssl/project#1425 Signed-off-by: Milan Broz <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> (Merged from #28702)
Contributor
|
merged via 4a53ed6 |
mbroz
added a commit
to mbroz/openssl
that referenced
this pull request
Oct 3, 2025
For compatibility reasons, OPENSSL_ENGINES_DIR and OPENSSL_INFO_ENGINES_DIR are still supported but return values like with engines disabled. The OPENSSL_ENGINES environment variable will be removed with engine removal later. Resolves: openssl/project#1425 Signed-off-by: Milan Broz <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> (Merged from openssl#28702)
nhorman
pushed a commit
to nhorman/openssl
that referenced
this pull request
Oct 3, 2025
For compatibility reasons, OPENSSL_ENGINES_DIR and OPENSSL_INFO_ENGINES_DIR are still supported but return values like with engines disabled. The OPENSSL_ENGINES environment variable will be removed with engine removal later. Resolves: openssl/project#1425 Signed-off-by: Milan Broz <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> (Merged from openssl#28702)
mbroz
added a commit
to mbroz/openssl
that referenced
this pull request
Dec 1, 2025
For compatibility reasons, OPENSSL_ENGINES_DIR and OPENSSL_INFO_ENGINES_DIR are still supported but return values like with engines disabled. The OPENSSL_ENGINES environment variable will be removed with engine removal later. Resolves: openssl/project#1425 Signed-off-by: Milan Broz <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> (Merged from openssl#28702)
nhorman
pushed a commit
to nhorman/openssl
that referenced
this pull request
Dec 1, 2025
For compatibility reasons, OPENSSL_ENGINES_DIR and OPENSSL_INFO_ENGINES_DIR are still supported but return values like with engines disabled. The OPENSSL_ENGINES environment variable will be removed with engine removal later. Resolves: openssl/project#1425 Signed-off-by: Milan Broz <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> (Merged from openssl#28702)
nhorman
pushed a commit
to nhorman/openssl
that referenced
this pull request
Dec 1, 2025
For compatibility reasons, OPENSSL_ENGINES_DIR and OPENSSL_INFO_ENGINES_DIR are still supported but return values like with engines disabled. The OPENSSL_ENGINES environment variable will be removed with engine removal later. Resolves: openssl/project#1425 Signed-off-by: Milan Broz <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> (Merged from openssl#28702)
mbroz
added a commit
to mbroz/openssl
that referenced
this pull request
Dec 4, 2025
For compatibility reasons, OPENSSL_ENGINES_DIR and OPENSSL_INFO_ENGINES_DIR are still supported but return values like with engines disabled. The OPENSSL_ENGINES environment variable will be removed with engine removal later. Resolves: openssl/project#1425 Signed-off-by: Milan Broz <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> (Merged from openssl#28702)
nhorman
pushed a commit
to nhorman/openssl
that referenced
this pull request
Dec 4, 2025
For compatibility reasons, OPENSSL_ENGINES_DIR and OPENSSL_INFO_ENGINES_DIR are still supported but return values like with engines disabled. The OPENSSL_ENGINES environment variable will be removed with engine removal later. Resolves: openssl/project#1425 Signed-off-by: Milan Broz <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> (Merged from openssl#28702)
mbroz
added a commit
to mbroz/openssl
that referenced
this pull request
Dec 4, 2025
For compatibility reasons, OPENSSL_ENGINES_DIR and OPENSSL_INFO_ENGINES_DIR are still supported but return values like with engines disabled. The OPENSSL_ENGINES environment variable will be removed with engine removal later. Resolves: openssl/project#1425 Signed-off-by: Milan Broz <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> (Merged from openssl#28702)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes support for ENGINESDIR and install/unistall Makefile targets.
For compatibility reasons, OPENSSL_ENGINES_DIR and OPENSSL_INFO_ENGINES_DIR are still supported but return values like with engines disabled.
The OPENSSL_ENGINES environment variable will be removed with engine removal later.
Resolves: openssl/project#1425
This should be not so controversial change as engines will be not installed even if compiled, but who knows :)