Revert "fips: remove redundant RSA encrypt/decrypt KAT"#28676
Closed
nhorman wants to merge 2 commits intoopenssl:masterfrom
Closed
Revert "fips: remove redundant RSA encrypt/decrypt KAT"#28676nhorman wants to merge 2 commits intoopenssl:masterfrom
nhorman wants to merge 2 commits intoopenssl:masterfrom
Conversation
This reverts commit 635bf49. During code review for FIPS-140-3 certification, our lab noticed that the known answer test for RSA was removed. This was done in the above commit, as part of openssl#25988 Under the assertion that FIPS 140-3 Imlementation Guidance section D.G had relaxed the requirements for testing, obviating the need for this test. However, for the 3.5 FIPS-140-3 certification we are adding assertions for support of KAS-IFC-SSC, which follows FIPS-140-e I.G section D.F, which does not contain the same relaxed constraints. As such we need to reintroduce the test. While the specifics of the I.G requirements are slightly different in D.F (allowing for other, potentially less time-consuming tests), the most expedient path forward here is to simply re-introduce the test as it existed previously, hence the reversion of the above commit. Fixes openssl/private#832
nhorman
requested review from
Sashan,
bob-beck,
jogme,
levitte,
mattcaswell,
npajkovsky,
t-j-h,
t8m and
vdukhovni
nhorman
added
branch: master
Revert "fips: remove redundant RSA encrypt/decrypt KAT" This reverts commit 635bf49. During code review for FIPS-140-3 certification, our lab noticed that the known answer test for RSA was removed. This was done in the above commit, as part of openssl#25988 Under the assertion that FIPS 140-3 Implementation Guidance section D.G had relaxed the requirements for testing, obviating the need for this test. However, for the 3.5 FIPS-140-3 certification we are adding assertions for support of KAS-IFC-SSC, which follows FIPS-140-3 I.G section D.F, which does not contain the same relaxed constraints. As such we need to reintroduce the test. While the specifics of the I.G requirements are slightly different in D.F (allowing for other, potentially less time-consuming tests), the most expedient path forward here is to simply re-introduce the test as it existed previously, hence the reversion of the above commit. Fixes openssl/private#832
github-actions
bot
added
the
severity: fips change
t8m
added
triaged: bug
jogme
approved these changes
Sep 26, 2025
t8m
approved these changes
Sep 26, 2025
Member
t8m
left a comment
t8m
left a comment
There was a problem hiding this comment.
OK for 3.5 and 3.6 (the backports CI failure is not relevant as the job does not cope well with empty commits).
mattcaswell
approved these changes
Sep 26, 2025
mattcaswell
added
approval: done
t-j-h
approved these changes
Sep 26, 2025
Member
|
Okay for backfit to noted branches |
bob-beck
approved these changes
Sep 26, 2025
Contributor
|
Typo in PR text and commit message : Imlementation |
Contributor
Author
|
@FdaSilvaYY see the fixup reword commit, in which that is fixed |
Collaborator
|
24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually. |
nhorman
added
approval: ready to merge
openssl-machine
pushed a commit
that referenced
this pull request
Sep 27, 2025
This reverts commit 635bf49. During code review for FIPS-140-3 certification, our lab noticed that the known answer test for RSA was removed. This was done in the above commit, as part of #25988 Under the assertion that FIPS 140-3 Implementation Guidance section D.G had relaxed the requirements for testing, obviating the need for this test. However, for the 3.5 FIPS-140-3 certification we are adding assertions for support of KAS-IFC-SSC, which follows FIPS-140-3 I.G section D.F, which does not contain the same relaxed constraints. As such we need to reintroduce the test. While the specifics of the I.G requirements are slightly different in D.F (allowing for other, potentially less time-consuming tests), the most expedient path forward here is to simply re-introduce the test as it existed previously, hence the reversion of the above commit. Fixes openssl/private#832 Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Tim Hudson <[email protected]> Reviewed-by: Matt Caswell <[email protected]> (Merged from #28676)
Contributor
Author
|
merged to master/3.6/3.5, thank you! |
openssl-machine
pushed a commit
that referenced
this pull request
Sep 27, 2025
This reverts commit 635bf49. During code review for FIPS-140-3 certification, our lab noticed that the known answer test for RSA was removed. This was done in the above commit, as part of #25988 Under the assertion that FIPS 140-3 Implementation Guidance section D.G had relaxed the requirements for testing, obviating the need for this test. However, for the 3.5 FIPS-140-3 certification we are adding assertions for support of KAS-IFC-SSC, which follows FIPS-140-3 I.G section D.F, which does not contain the same relaxed constraints. As such we need to reintroduce the test. While the specifics of the I.G requirements are slightly different in D.F (allowing for other, potentially less time-consuming tests), the most expedient path forward here is to simply re-introduce the test as it existed previously, hence the reversion of the above commit. Fixes openssl/private#832 Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Tim Hudson <[email protected]> Reviewed-by: Matt Caswell <[email protected]> (Merged from #28676) (cherry picked from commit 3206bb7)
openssl-machine
pushed a commit
that referenced
this pull request
Sep 27, 2025
This reverts commit 635bf49. During code review for FIPS-140-3 certification, our lab noticed that the known answer test for RSA was removed. This was done in the above commit, as part of #25988 Under the assertion that FIPS 140-3 Implementation Guidance section D.G had relaxed the requirements for testing, obviating the need for this test. However, for the 3.5 FIPS-140-3 certification we are adding assertions for support of KAS-IFC-SSC, which follows FIPS-140-3 I.G section D.F, which does not contain the same relaxed constraints. As such we need to reintroduce the test. While the specifics of the I.G requirements are slightly different in D.F (allowing for other, potentially less time-consuming tests), the most expedient path forward here is to simply re-introduce the test as it existed previously, hence the reversion of the above commit. Fixes openssl/private#832 Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Tim Hudson <[email protected]> Reviewed-by: Matt Caswell <[email protected]> (Merged from #28676) (cherry picked from commit 3206bb7)
esyr
added a commit
to esyr/openssl
that referenced
this pull request
Sep 30, 2025
3.5.4 CHANGES.md includes the following: * openssl#28098 * openssl#28415 * openssl#28504 * openssl#28535 * openssl#28569 * openssl#28573 * openssl#28576 * openssl#28591 * openssl#28603 * openssl#28624 * openssl#28642 * openssl#28676 3.5.4 NEWS.md includes the following: * openssl#28603 Updated the changes and news in the previous branches. Removed the attribution in NEWS.md incorrectly introduced in e551da6 "Update news and changes for the 3.5.3 release". Release: Yes Signed-off-by: Eugene Syromiatnikov <[email protected]>
esyr
added a commit
to esyr/openssl
that referenced
this pull request
Sep 30, 2025
3.5.4 CHANGES.md includes the following: * openssl#28098 * openssl#28415 * openssl#28504 * openssl#28535 * openssl#28569 * openssl#28573 * openssl#28576 * openssl#28591 * openssl#28603 * openssl#28624 * openssl#28642 * openssl#28676 3.5.4 NEWS.md includes the following: * openssl#28603 Updated the changes and news in the previous branches. Removed the attribution in NEWS.md incorrectly introduced in e551da6 "Update news and changes for the 3.5.3 release". Release: Yes Signed-off-by: Eugene Syromiatnikov <[email protected]>
esyr
added a commit
to esyr/openssl
that referenced
this pull request
Sep 30, 2025
3.5.4 CHANGES.md includes the following: * openssl#28098 * openssl#28415 * openssl#28504 * openssl#28535 * openssl#28569 * openssl#28573 * openssl#28576 * openssl#28591 * openssl#28603 * openssl#28624 * openssl#28642 * openssl#28676 3.5.4 NEWS.md includes the following: * openssl#28603 Updated the changes and news in the previous branches. Removed the attribution in NEWS.md incorrectly introduced in e551da6 "Update news and changes for the 3.5.3 release". Release: Yes Signed-off-by: Eugene Syromiatnikov <[email protected]>
esyr
added a commit
to esyr/openssl
that referenced
this pull request
Sep 30, 2025
3.5.4 CHANGES.md includes the following: * openssl#28098 * openssl#28415 * openssl#28504 * openssl#28535 * openssl#28569 * openssl#28573 * openssl#28576 * openssl#28591 * openssl#28603 * openssl#28624 * openssl#28642 * openssl#28676 3.5.4 NEWS.md includes the following: * openssl#28603 Updated the changes and news in the previous branches. Removed the attribution in NEWS.md incorrectly introduced in e551da6 "Update news and changes for the 3.5.3 release". Release: Yes Signed-off-by: Eugene Syromiatnikov <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 635bf49.
During code review for FIPS-140-3 certification, our lab noticed that the known answer test for RSA was removed. This was done in the above commit, as part of
#25988
Under the assertion that FIPS 140-3 Implementation Guidance section D.G had relaxed the requirements for testing, obviating the need for this test.
However, for the 3.5 FIPS-140-3 certification we are adding assertions for support of KAS-IFC-SSC, which follows FIPS-140-3 I.G section D.F, which does not contain the same relaxed constraints. As such we need to reintroduce the test.
While the specifics of the I.G requirements are slightly different in D.F (allowing for other, potentially less time-consuming tests), the most expedient path forward here is to simply re-introduce the test as it existed previously, hence the reversion of the above commit.
Fixes openssl/private#832
Checklist