Remove ENGINE usage from crypto subdirs#28629
Closed
jogme wants to merge 3 commits intoopenssl:feature/engineremovalfrom
Closed
Remove ENGINE usage from crypto subdirs#28629jogme wants to merge 3 commits intoopenssl:feature/engineremovalfrom
jogme wants to merge 3 commits intoopenssl:feature/engineremovalfrom
Conversation
jogme
changed the title
github-actions
bot
added
the
severity: fips change
openssl-machine
force-pushed
the
feature/engineremoval
branch
from
8132702 to
f70450f
Compare
jogme
force-pushed
the
1625
branch
2 times, most recently
from
9237be8 to
bcbdda0
Compare
mattcaswell
reviewed
Nov 11, 2025
mattcaswell
reviewed
Nov 11, 2025
jogme
force-pushed
the
1625
branch
2 times, most recently
from
ded7b50 to
a21b9c8
Compare
mattcaswell
reviewed
Nov 11, 2025
jogme
force-pushed
the
1625
branch
2 times, most recently
from
e229d4a to
7c70e29
Compare
t8m
reviewed
Nov 11, 2025
t8m
reviewed
Nov 11, 2025
mbroz
suggested changes
Nov 12, 2025
Member
mbroz
left a comment
mbroz
left a comment
There was a problem hiding this comment.
I think the ossl_unused attribute is not correct for most API calls, but please correct me if it has different meaning than attribute((unused)) (defined in e_os2.h) ...
jogme
force-pushed
the
1625
branch
2 times, most recently
from
6883e71 to
84c23a3
Compare
mbroz
approved these changes
Nov 13, 2025
Member
mbroz
left a comment
mbroz
left a comment
There was a problem hiding this comment.
LGTM
Deprecated OSSL_STORE_LOADER_get0_engine could be also replaced by a stub, but I think it is better to keep it returning NULL.
jogme
force-pushed
the
1625
branch
2 times, most recently
from
6b8cb63 to
c6388b7
Compare
esyr
requested changes
Nov 18, 2025
Member
There was a problem hiding this comment.
It's unfortunate that changes in internal functions are intermixed with NULL checks for the engine parameters in publicly facing functions, as well as ossl_unused additions/removals in the same commit, but I guess that's immaterial. The only meaningful change required is the leak fix, everything else is good enough as it is.
jogme
force-pushed
the
1625
branch
2 times, most recently
from
c7d9244 to
eda0770
Compare
Sashan
approved these changes
Dec 1, 2025
Contributor
Sashan
left a comment
Sashan
left a comment
There was a problem hiding this comment.
looks good to me. thanks.
Sashan
added
approval: review pending
openssl-machine
force-pushed
the
feature/engineremoval
branch
from
b1efec7 to
90e2bc1
Compare
t8m
approved these changes
Dec 2, 2025
t8m
added
approval: done
Engines can be removed safely from static and internal functions clearing out our codebase. Resolves: openssl/project#1625 Signed-off-by: Norbert Pocs <[email protected]>
Signed-off-by: Norbert Pocs <[email protected]>
Signed-off-by: Norbert Pocs <[email protected]>
openssl-machine
added
approval: ready to merge
Collaborator
|
This pull request is ready to merge |
openssl-machine
pushed a commit
that referenced
this pull request
Dec 3, 2025
Engines can be removed safely from static and internal functions clearing out our codebase. Resolves: openssl/project#1625 Signed-off-by: Norbert Pocs <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Eugene Syromiatnikov <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> (Merged from #28629)
Contributor
|
CI is not relevant. changes were merged to feature branch via |
mbroz
pushed a commit
to mbroz/openssl
that referenced
this pull request
Dec 4, 2025
Engines can be removed safely from static and internal functions clearing out our codebase. Resolves: openssl/project#1625 Signed-off-by: Norbert Pocs <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Eugene Syromiatnikov <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> (Merged from openssl#28629)
nhorman
pushed a commit
to nhorman/openssl
that referenced
this pull request
Dec 4, 2025
Engines can be removed safely from static and internal functions clearing out our codebase. Resolves: openssl/project#1625 Signed-off-by: Norbert Pocs <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Eugene Syromiatnikov <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> (Merged from openssl#28629)
mbroz
pushed a commit
to mbroz/openssl
that referenced
this pull request
Dec 4, 2025
Engines can be removed safely from static and internal functions clearing out our codebase. Resolves: openssl/project#1625 Signed-off-by: Norbert Pocs <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Eugene Syromiatnikov <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> (Merged from openssl#28629)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The functiontality here was already removed by the OPENSSL_NO_ENGINE guard.
This PR makes the internal function shiny.
Resolves: openssl/project#1625
Checklist