crypto/ml_dsa: fix public_from_private() error path to return failure#28576
Closed
rodeka wants to merge 2 commits intoopenssl:masterfrom
Closed
crypto/ml_dsa: fix public_from_private() error path to return failure#28576rodeka wants to merge 2 commits intoopenssl:masterfrom
rodeka wants to merge 2 commits intoopenssl:masterfrom
Conversation
The error label returned success (1) even on failure. Make it return failure (0) instead. Fixes openssl#28562 CLA: trivial
t8m
requested changes
Sep 16, 2025
t8m
added
branch: master
github-actions
bot
added
the
severity: fips change
Set the ret variable to return as in other functions. CLA: trivial
Contributor
Author
|
Set the ret variable to return as in other functions. |
paulidale
approved these changes
Sep 16, 2025
paulidale
added
the
approval: done
openssl-machine
removed
the
approval: done
Collaborator
|
This pull request is ready to merge |
openssl-machine
added
the
approval: ready to merge
openssl-machine
pushed a commit
that referenced
this pull request
Sep 17, 2025
The error label returned success (1) even on failure. Make it return failure (0) instead. Fixes #28562 CLA: trivial Reviewed-by: Todd Short <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from #28576)
Contributor
|
Merged to 3.5, 3.6 and master. Thanks for the fix. I assumed trivial was okay for @tmshort too. |
openssl-machine
pushed a commit
that referenced
this pull request
Sep 17, 2025
The error label returned success (1) even on failure. Make it return failure (0) instead. Fixes #28562 CLA: trivial Reviewed-by: Todd Short <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from #28576) (cherry picked from commit 925e4fb)
openssl-machine
pushed a commit
that referenced
this pull request
Sep 17, 2025
The error label returned success (1) even on failure. Make it return failure (0) instead. Fixes #28562 CLA: trivial Reviewed-by: Todd Short <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from #28576) (cherry picked from commit 925e4fb)
esyr
added a commit
to esyr/openssl
that referenced
this pull request
Sep 30, 2025
3.5.4 CHANGES.md includes the following: * openssl#28098 * openssl#28415 * openssl#28504 * openssl#28535 * openssl#28569 * openssl#28573 * openssl#28576 * openssl#28591 * openssl#28603 * openssl#28624 * openssl#28642 * openssl#28676 3.5.4 NEWS.md includes the following: * openssl#28603 Updated the changes and news in the previous branches. Removed the attribution in NEWS.md incorrectly introduced in e551da6 "Update news and changes for the 3.5.3 release". Release: Yes Signed-off-by: Eugene Syromiatnikov <[email protected]>
esyr
added a commit
to esyr/openssl
that referenced
this pull request
Sep 30, 2025
3.5.4 CHANGES.md includes the following: * openssl#28098 * openssl#28415 * openssl#28504 * openssl#28535 * openssl#28569 * openssl#28573 * openssl#28576 * openssl#28591 * openssl#28603 * openssl#28624 * openssl#28642 * openssl#28676 3.5.4 NEWS.md includes the following: * openssl#28603 Updated the changes and news in the previous branches. Removed the attribution in NEWS.md incorrectly introduced in e551da6 "Update news and changes for the 3.5.3 release". Release: Yes Signed-off-by: Eugene Syromiatnikov <[email protected]>
esyr
added a commit
to esyr/openssl
that referenced
this pull request
Sep 30, 2025
3.5.4 CHANGES.md includes the following: * openssl#28098 * openssl#28415 * openssl#28504 * openssl#28535 * openssl#28569 * openssl#28573 * openssl#28576 * openssl#28591 * openssl#28603 * openssl#28624 * openssl#28642 * openssl#28676 3.5.4 NEWS.md includes the following: * openssl#28603 Updated the changes and news in the previous branches. Removed the attribution in NEWS.md incorrectly introduced in e551da6 "Update news and changes for the 3.5.3 release". Release: Yes Signed-off-by: Eugene Syromiatnikov <[email protected]>
esyr
added a commit
to esyr/openssl
that referenced
this pull request
Sep 30, 2025
3.5.4 CHANGES.md includes the following: * openssl#28098 * openssl#28415 * openssl#28504 * openssl#28535 * openssl#28569 * openssl#28573 * openssl#28576 * openssl#28591 * openssl#28603 * openssl#28624 * openssl#28642 * openssl#28676 3.5.4 NEWS.md includes the following: * openssl#28603 Updated the changes and news in the previous branches. Removed the attribution in NEWS.md incorrectly introduced in e551da6 "Update news and changes for the 3.5.3 release". Release: Yes Signed-off-by: Eugene Syromiatnikov <[email protected]>
Member
|
I wrote about new contributions on the blog and this one got a mention, @rodeka . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error label returned success (1) even on failure. Make it return failure (0) instead. Fixes #28562
I audited all references to public_from_private() in the tree. The function is internal. All call sites treat its return value as a boolean success (1) / failure (0) and propagate failures accordingly; none rely on the previous (buggy) success-on-error behavior. Therefore, no behavior changes or follow-up adjustments are required.