Skip to content

Comments

providers/implementations/keymgmt/ecx_kmgmt.c.in: remove PCT on ECX import#28573

Closed
esyr wants to merge 1 commit intoopenssl:masterfrom
esyr:esyr/remove-ecx-import-pct
Closed

providers/implementations/keymgmt/ecx_kmgmt.c.in: remove PCT on ECX import#28573
esyr wants to merge 1 commit intoopenssl:masterfrom
esyr:esyr/remove-ecx-import-pct

Conversation

@esyr
Copy link
Member

@esyr esyr commented Sep 16, 2025

While PCT on import has been removed for DH, EC, RSA, and SLH-DSA, ECX seems to be overlooked. Correct that omission.

Complements: 7f7f758 "import pct: remove import PCTs for most algorithms"

@esyr
providers/implementations/keymgmt/ecx_kmgmt.c.in: remove PCT on ECX i…
19625f1 
…mport

While PCT on import has been removed for DH, EC, RSA, and SLH-DSA,
ECX seems to be overlooked.  Correct that omission.

Complements: 7f7f758 "import pct: remove import PCTs for most algorithms"
Signed-off-by: Eugene Syromiatnikov <[email protected]>
@esyr esyr added branch: master Applies to master branch approval: review pending This pull request needs review by a committer triaged: cleanup The issue/pr deals with cleanup of comments/docs not altering code significantly branch: 3.5 Applies to openssl-3.5 branch: 3.6 Applies to openssl-3.6 labels Sep 16, 2025
@github-actions github-actions bot added the severity: fips change The pull request changes FIPS provider sources label Sep 16, 2025
paulidale
paulidale approved these changes Sep 16, 2025
View reviewed changes
Copy link
Contributor

@paulidale paulidale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I missed this one. Sigh.

@paulidale
Copy link
Contributor

paulidale commented Sep 16, 2025

Suggestion: rename the ecx_import function to something that indicates that it also does Ed imports?

@esyr
Copy link
Member Author

esyr commented Sep 17, 2025 •
edited
Loading

Suggestion: rename the ecx_import function to something that indicates that it also does Ed imports?

Well, my understanding is that the majority of the ecx_* functions also handle Ed curves (ecx_gen, ecx_export, ecx_dup, ossl_ecx_key_new, and so on), as well as the macro names like ECX_KEY_TYPE_ED25519 are pretty telling, so that is probably implied at this point.

@t8m t8m added triaged: bug The issue/pr is/fixes a bug tests: exempted The PR is exempt from requirements for testing and removed triaged: cleanup The issue/pr deals with cleanup of comments/docs not altering code significantly labels Sep 17, 2025
@t8m t8m closed this Sep 17, 2025
@t8m t8m reopened this Sep 17, 2025
@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Sep 17, 2025
@openssl-machine
Copy link
Collaborator

openssl-machine commented Sep 18, 2025

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

@t8m t8m added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Sep 18, 2025
@t8m
Copy link
Member

t8m commented Sep 18, 2025

Merged to the master, 3.6 and 3.5 branches. Thank you.

@t8m t8m closed this Sep 18, 2025
openssl-machine pushed a commit that referenced this pull request Sep 18, 2025
@esyr @t8m
providers/implementations/keymgmt/ecx_kmgmt.c.in: remove PCT on ECX i…
588bc2e 
…mport

While PCT on import has been removed for DH, EC, RSA, and SLH-DSA,
ECX seems to be overlooked.  Correct that omission.

Complements: 7f7f758 "import pct: remove import PCTs for most algorithms"
Signed-off-by: Eugene Syromiatnikov <[email protected]>

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from #28573)

(cherry picked from commit 05d12fd)
openssl-machine pushed a commit that referenced this pull request Sep 18, 2025
@esyr @t8m
providers/implementations/keymgmt/ecx_kmgmt.c.in: remove PCT on ECX i…
44b8c00 
…mport

While PCT on import has been removed for DH, EC, RSA, and SLH-DSA,
ECX seems to be overlooked.  Correct that omission.

Complements: 7f7f758 "import pct: remove import PCTs for most algorithms"
Signed-off-by: Eugene Syromiatnikov <[email protected]>

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from #28573)

(cherry picked from commit 05d12fd)
openssl-machine pushed a commit that referenced this pull request Sep 18, 2025
@esyr @t8m
providers/implementations/keymgmt/ecx_kmgmt.c.in: remove PCT on ECX i…
05d12fd 
…mport

While PCT on import has been removed for DH, EC, RSA, and SLH-DSA,
ECX seems to be overlooked.  Correct that omission.

Complements: 7f7f758 "import pct: remove import PCTs for most algorithms"
Signed-off-by: Eugene Syromiatnikov <[email protected]>

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from #28573)
esyr added a commit to esyr/openssl that referenced this pull request Sep 30, 2025
@esyr
CHANGES.md, NEWS.md: update for 3.5.4
08b91a2 
3.5.4 CHANGES.md includes the following:
 * openssl#28098
 * openssl#28415
 * openssl#28504
 * openssl#28535
 * openssl#28569
 * openssl#28573
 * openssl#28576
 * openssl#28591
 * openssl#28603
 * openssl#28624
 * openssl#28642
 * openssl#28676

3.5.4 NEWS.md includes the following:
 * openssl#28603

Updated the changes and news in the previous branches.

Removed the attribution in NEWS.md incorrectly introduced in e551da6
"Update news and changes for the 3.5.3 release".

Release: Yes
Signed-off-by: Eugene Syromiatnikov <[email protected]>
@esyr esyr mentioned this pull request Sep 30, 2025
Closed
esyr added a commit to esyr/openssl that referenced this pull request Sep 30, 2025
@esyr
CHANGES.md, NEWS.md: update for 3.5.4
0ab493c 
3.5.4 CHANGES.md includes the following:
 * openssl#28098
 * openssl#28415
 * openssl#28504
 * openssl#28535
 * openssl#28569
 * openssl#28573
 * openssl#28576
 * openssl#28591
 * openssl#28603
 * openssl#28624
 * openssl#28642
 * openssl#28676

3.5.4 NEWS.md includes the following:
 * openssl#28603

Updated the changes and news in the previous branches.

Removed the attribution in NEWS.md incorrectly introduced in e551da6
"Update news and changes for the 3.5.3 release".

Release: Yes
Signed-off-by: Eugene Syromiatnikov <[email protected]>
esyr added a commit to esyr/openssl that referenced this pull request Sep 30, 2025
@esyr
CHANGES.md, NEWS.md: update for 3.5.4
c0aaf28 
3.5.4 CHANGES.md includes the following:
 * openssl#28098
 * openssl#28415
 * openssl#28504
 * openssl#28535
 * openssl#28569
 * openssl#28573
 * openssl#28576
 * openssl#28591
 * openssl#28603
 * openssl#28624
 * openssl#28642
 * openssl#28676

3.5.4 NEWS.md includes the following:
 * openssl#28603

Updated the changes and news in the previous branches.

Removed the attribution in NEWS.md incorrectly introduced in e551da6
"Update news and changes for the 3.5.3 release".

Release: Yes
Signed-off-by: Eugene Syromiatnikov <[email protected]>
esyr added a commit to esyr/openssl that referenced this pull request Sep 30, 2025
@esyr
CHANGES.md, NEWS.md: update for 3.5.4
28ed120 
3.5.4 CHANGES.md includes the following:
 * openssl#28098
 * openssl#28415
 * openssl#28504
 * openssl#28535
 * openssl#28569
 * openssl#28573
 * openssl#28576
 * openssl#28591
 * openssl#28603
 * openssl#28624
 * openssl#28642
 * openssl#28676

3.5.4 NEWS.md includes the following:
 * openssl#28603

Updated the changes and news in the previous branches.

Removed the attribution in NEWS.md incorrectly introduced in e551da6
"Update news and changes for the 3.5.3 release".

Release: Yes
Signed-off-by: Eugene Syromiatnikov <[email protected]>
openssl-machine pushed a commit that referenced this pull request Sep 30, 2025
@esyr
CHANGES.md, NEWS.md: update for 3.5.4
33eed23 
3.5.4 CHANGES.md includes the following:
 * #28415
 * #28573
 * #28603

3.5.4 NEWS.md includes the following:
 * #28603

Release: Yes
Signed-off-by: Eugene Syromiatnikov <[email protected]>

Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
esyr added a commit to esyr/openssl that referenced this pull request Oct 1, 2025
@esyr
CHANGES.md, NEWS.md: update for 3.5.4
f72f664 
3.5.4 CHANGES.md includes the following:
 * openssl#28415
 * openssl#28573
 * openssl#28603

3.5.4 NEWS.md includes the following:
 * openssl#28603

Release: Yes
Signed-off-by: Eugene Syromiatnikov <[email protected]>

Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
openssl-machine pushed a commit that referenced this pull request Oct 1, 2025
@esyr
CHANGES.md, NEWS.md: update for 3.5.4
2735778 
3.5.4 CHANGES.md includes the following:
 * #28415
 * #28573
 * #28603

3.5.4 NEWS.md includes the following:
 * #28603

Release: Yes
Signed-off-by: Eugene Syromiatnikov <[email protected]>

Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from #28712)
esyr added a commit to esyr/openssl that referenced this pull request Oct 2, 2025
@esyr
CHANGES.md, NEWS.md: update for 3.5.4
871089a 
3.5.4 CHANGES.md includes the following:
 * openssl#28415
 * openssl#28573
 * openssl#28603

3.5.4 NEWS.md includes the following:
 * openssl#28603

Release: Yes
Signed-off-by: Eugene Syromiatnikov <[email protected]>

Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from openssl#28712)
openssl-machine pushed a commit that referenced this pull request Oct 17, 2025
@esyr @t8m
CHANGES.md, NEWS.md: update for 3.5.4
481eb62 
3.5.4 CHANGES.md includes the following:
 * #28415
 * #28573
 * #28603

3.5.4 NEWS.md includes the following:
 * #28603

Release: Yes
Signed-off-by: Eugene Syromiatnikov <[email protected]>

Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from #28734)
MegaManSec pushed a commit to MegaManSec/openssl that referenced this pull request Nov 11, 2025
@esyr @MegaManSec
CHANGES.md, NEWS.md: update for 3.5.4
5fc2988 
3.5.4 CHANGES.md includes the following:
 * openssl#28415
 * openssl#28573
 * openssl#28603

3.5.4 NEWS.md includes the following:
 * openssl#28603

Release: Yes
Signed-off-by: Eugene Syromiatnikov <[email protected]>

Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from openssl#28734)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@t8m t8m t8m approved these changes

@paulidale paulidale paulidale approved these changes

@npajkovsky npajkovsky Awaiting requested review from npajkovsky

Assignees

No one assigned

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Applies to master branch branch: 3.5 Applies to openssl-3.5 branch: 3.6 Applies to openssl-3.6 severity: fips change The pull request changes FIPS provider sources tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@esyr @paulidale @openssl-machine @t8m