Skip to content

Comments

Remove ENGINE usage from crypto/ec/*#28570

Closed
jogme wants to merge 1 commit intoopenssl:feature/engineremovalfrom
jogme:1615
Closed

Remove ENGINE usage from crypto/ec/*#28570
jogme wants to merge 1 commit intoopenssl:feature/engineremovalfrom
jogme:1615

Conversation

@jogme
Copy link
Contributor

@jogme jogme commented Sep 16, 2025

Resolves: openssl/project#1615

Signed-off-by: Norbert Pocs [email protected]

Checklist
  • documentation is added or updated
  • tests are added or updated

@github-actions github-actions bot added severity: fips change The pull request changes FIPS provider sources severity: ABI change This pull request contains ABI changes labels Sep 16, 2025
@levitte levitte added branch: master Applies to master branch approval: review pending This pull request needs review by a committer labels Sep 16, 2025
@jogme jogme linked an issue Sep 16, 2025 that may be closed by this pull request
Remove engines from crypto/ec directory openssl/project#1615
Closed
t8m
t8m requested changes Sep 16, 2025
View reviewed changes
@nhorman nhorman force-pushed the feature/engineremoval branch from e107df0 to d1d5468 Compare September 17, 2025 18:37
@nhorman nhorman force-pushed the feature/engineremoval branch from 34c1245 to aad1c4e Compare September 17, 2025 20:44
@jogme jogme force-pushed the 1615 branch 3 times, most recently from 38877e3 to 0bb2b39 Compare September 18, 2025 07:01
@github-actions github-actions bot removed the severity: ABI change This pull request contains ABI changes label Sep 18, 2025
@jogme
Copy link
Contributor Author

jogme commented Sep 18, 2025

The removed functions were restored as agreed and rebased to the current feature/engineremoval. PTAL

@slontis
Copy link
Member

slontis commented Sep 19, 2025

If this PR contains commits from other PR's then it should state that it is dependant on another PR.
This looks like it needs to be rebased after another PR is merged?

@jogme
Copy link
Contributor Author

jogme commented Sep 19, 2025

If this PR contains commits from other PR's then it should state that it is dependant on another PR. This looks like it needs to be rebased after another PR is merged?

Yes, there was a rebase of the feature branch and it caused some trash here. It was rebased

slontis
slontis reviewed Sep 21, 2025
View reviewed changes
@t8m t8m added triaged: refactor The issue/pr requests/implements refactoring and removed branch: master Applies to master branch labels Sep 22, 2025
@t8m t8m added tests: exempted The PR is exempt from requirements for testing branch: feature The issue or PR is relevant only to one of the feature branches. labels Sep 22, 2025
@t8m t8m requested review from levitte and paulidale September 22, 2025 10:45
@paulidale paulidale added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Sep 22, 2025
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Sep 23, 2025
@openssl-machine
Copy link
Collaborator

openssl-machine commented Sep 23, 2025

This pull request is ready to merge

@t8m
Copy link
Member

t8m commented Sep 25, 2025

Merged to the feature branch. Thank you.

@t8m t8m closed this Sep 25, 2025
openssl-machine pushed a commit that referenced this pull request Sep 25, 2025
@jogme @t8m
crypto/ec: Remove ENGINE usage
c4850cf 
Resolves: openssl/project#1615

Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from #28570)
mbroz pushed a commit to mbroz/openssl that referenced this pull request Oct 3, 2025
@jogme @mbroz
crypto/ec: Remove ENGINE usage
8a6092b 
Resolves: openssl/project#1615

Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from openssl#28570)
nhorman pushed a commit to nhorman/openssl that referenced this pull request Oct 3, 2025
@jogme @nhorman
crypto/ec: Remove ENGINE usage
a91f4ac 
Resolves: openssl/project#1615

Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from openssl#28570)
mbroz pushed a commit to mbroz/openssl that referenced this pull request Dec 1, 2025
@jogme @mbroz
crypto/ec: Remove ENGINE usage
88a3736 
Resolves: openssl/project#1615

Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from openssl#28570)
nhorman pushed a commit to nhorman/openssl that referenced this pull request Dec 1, 2025
@jogme @nhorman
crypto/ec: Remove ENGINE usage
e310450 
Resolves: openssl/project#1615

Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from openssl#28570)
nhorman pushed a commit to nhorman/openssl that referenced this pull request Dec 1, 2025
@jogme @nhorman
crypto/ec: Remove ENGINE usage
9d93b92 
Resolves: openssl/project#1615

Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from openssl#28570)
mbroz pushed a commit to mbroz/openssl that referenced this pull request Dec 4, 2025
@jogme @mbroz
crypto/ec: Remove ENGINE usage
ef5da8a 
Resolves: openssl/project#1615

Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from openssl#28570)
nhorman pushed a commit to nhorman/openssl that referenced this pull request Dec 4, 2025
@jogme @nhorman
crypto/ec: Remove ENGINE usage
f7acd24 
Resolves: openssl/project#1615

Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from openssl#28570)
mbroz pushed a commit to mbroz/openssl that referenced this pull request Dec 4, 2025
@jogme @mbroz
crypto/ec: Remove ENGINE usage
e820fdd 
Resolves: openssl/project#1615

Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from openssl#28570)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slontis slontis slontis left review comments

@t8m t8m t8m approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

@paulidale paulidale paulidale approved these changes

@levitte levitte Awaiting requested review from levitte

Assignees

No one assigned

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge branch: feature The issue or PR is relevant only to one of the feature branches. severity: fips change The pull request changes FIPS provider sources tests: exempted The PR is exempt from requirements for testing triaged: refactor The issue/pr requests/implements refactoring

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove engines from crypto/ec directory

7 participants

@jogme @slontis @openssl-machine @t8m @levitte @mattcaswell @paulidale