Skip to content

Comments

p_lib.c: Remove engine from pkey_set_type#28560

Closed
jogme wants to merge 1 commit intoopenssl:feature/engineremovalfrom
jogme:pkey_set_type
Closed

p_lib.c: Remove engine from pkey_set_type#28560
jogme wants to merge 1 commit intoopenssl:feature/engineremovalfrom
jogme:pkey_set_type

Conversation

@jogme
Copy link
Contributor

@jogme jogme commented Sep 16, 2025

Resolves: openssl/project#1437

Signed-off-by: Norbert Pocs [email protected]

Checklist
  • documentation is added or updated
  • tests are added or updated

@jogme jogme linked an issue Sep 16, 2025 that may be closed by this pull request
Remove ENGINE from pkey_set_type openssl/project#1437
Closed
@github-actions github-actions bot added the severity: fips change The pull request changes FIPS provider sources label Sep 16, 2025
@mattcaswell mattcaswell added approval: review pending This pull request needs review by a committer triaged: refactor The issue/pr requests/implements refactoring tests: exempted The PR is exempt from requirements for testing labels Sep 16, 2025
@jogme
Copy link
Contributor Author

jogme commented Sep 16, 2025

rebased on top of feature/engineremoval

@nhorman nhorman added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Sep 16, 2025
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Sep 17, 2025
@openssl-machine
Copy link
Collaborator

openssl-machine commented Sep 17, 2025

This pull request is ready to merge

@nhorman nhorman force-pushed the feature/engineremoval branch from e107df0 to d1d5468 Compare September 17, 2025 18:37
@nhorman
Copy link
Contributor

nhorman commented Sep 17, 2025

merged to feature branch, thank you!

@nhorman nhorman closed this Sep 17, 2025
openssl-machine pushed a commit that referenced this pull request Sep 17, 2025
@jogme @nhorman
p_lib.c: Remove engine from pkey_set_type
34c1245 
Resolves: openssl/project#1437

Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from #28560)
nhorman pushed a commit that referenced this pull request Sep 17, 2025
@jogme @nhorman
p_lib.c: Remove engine from pkey_set_type
aad1c4e 
Resolves: openssl/project#1437

Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from #28560)
nhorman pushed a commit to nhorman/openssl that referenced this pull request Sep 18, 2025
@jogme @nhorman
p_lib.c: Remove engine from pkey_set_type
df837d9 
Resolves: openssl/project#1437

Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from openssl#28560)
mbroz pushed a commit to mbroz/openssl that referenced this pull request Sep 18, 2025
@jogme @mbroz
p_lib.c: Remove engine from pkey_set_type
1265d68 
Resolves: openssl/project#1437

Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from openssl#28560)
nhorman pushed a commit to nhorman/openssl that referenced this pull request Sep 18, 2025
@jogme @nhorman
p_lib.c: Remove engine from pkey_set_type
4cb8566 
Resolves: openssl/project#1437

Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from openssl#28560)
nhorman pushed a commit to nhorman/openssl that referenced this pull request Sep 18, 2025
@jogme @nhorman
p_lib.c: Remove engine from pkey_set_type
bd2cba7 
Resolves: openssl/project#1437

Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from openssl#28560)
mbroz pushed a commit to mbroz/openssl that referenced this pull request Oct 3, 2025
@jogme @mbroz
p_lib.c: Remove engine from pkey_set_type
6eeea55 
Resolves: openssl/project#1437

Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from openssl#28560)
nhorman pushed a commit to nhorman/openssl that referenced this pull request Oct 3, 2025
@jogme @nhorman
p_lib.c: Remove engine from pkey_set_type
452756f 
Resolves: openssl/project#1437

Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from openssl#28560)
mbroz pushed a commit to mbroz/openssl that referenced this pull request Dec 1, 2025
@jogme @mbroz
p_lib.c: Remove engine from pkey_set_type
2839dc2 
Resolves: openssl/project#1437

Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from openssl#28560)
nhorman pushed a commit to nhorman/openssl that referenced this pull request Dec 1, 2025
@jogme @nhorman
p_lib.c: Remove engine from pkey_set_type
a3fa892 
Resolves: openssl/project#1437

Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from openssl#28560)
nhorman pushed a commit to nhorman/openssl that referenced this pull request Dec 1, 2025
@jogme @nhorman
p_lib.c: Remove engine from pkey_set_type
a0dbd54 
Resolves: openssl/project#1437

Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from openssl#28560)
mbroz pushed a commit to mbroz/openssl that referenced this pull request Dec 4, 2025
@jogme @mbroz
p_lib.c: Remove engine from pkey_set_type
8b8a466 
Resolves: openssl/project#1437

Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from openssl#28560)
nhorman pushed a commit to nhorman/openssl that referenced this pull request Dec 4, 2025
@jogme @nhorman
p_lib.c: Remove engine from pkey_set_type
be34253 
Resolves: openssl/project#1437

Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from openssl#28560)
mbroz pushed a commit to mbroz/openssl that referenced this pull request Dec 4, 2025
@jogme @mbroz
p_lib.c: Remove engine from pkey_set_type
472778b 
Resolves: openssl/project#1437

Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from openssl#28560)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nhorman nhorman nhorman approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

@paulidale paulidale paulidale approved these changes

Assignees

No one assigned

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge severity: fips change The pull request changes FIPS provider sources tests: exempted The PR is exempt from requirements for testing triaged: refactor The issue/pr requests/implements refactoring

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove ENGINE from pkey_set_type

5 participants

@jogme @openssl-machine @nhorman @mattcaswell @paulidale