Remove ENGINE_TABLE and ENGINE_REF_COUNT trace categories#28556
Closed
nhorman wants to merge 8 commits intoopenssl:feature/engineremovalfrom
Closed
Remove ENGINE_TABLE and ENGINE_REF_COUNT trace categories#28556nhorman wants to merge 8 commits intoopenssl:feature/engineremovalfrom
nhorman wants to merge 8 commits intoopenssl:feature/engineremovalfrom
Conversation
As we can't do every change in one big PR (and we also don't want), therefore there always will be failing tests until everything is resolved/cleaned up. This way we silence the CI about engine tests and later we can reenable them to see what else needs to be fixed. Resolves: openssl/project#1371 Signed-off-by: Norbert Pocs <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Richard Levitte <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Matt Caswell <[email protected]> (Merged from openssl#28440)
Signed-off-by: Norbert Pocs <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Richard Levitte <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Matt Caswell <[email protected]> (Merged from openssl#28440)
Signed-off-by: Norbert Pocs <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Richard Levitte <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Matt Caswell <[email protected]> (Merged from openssl#28440)
This patch removes apps/engine.c and associated man pages. Resolves: openssl/project#1370 Signed-off-by: Milan Broz <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Richard Levitte <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from openssl#28481)
With ENGINES going away we need to remove these trace catagories
As the subject indicates, with these trace categories gone, we shouldn't reference them in the docs anymore.
nhorman
requested review from
Sashan,
andrewkdinh,
esyr,
jogme,
mattcaswell,
npajkovsky and
t8m
nhorman
added
the
approval: review pending
github-actions
bot
added
the
severity: fips change
paulidale
approved these changes
Sep 15, 2025
jogme
approved these changes
Sep 16, 2025
t8m
added
triaged: feature
t8m
approved these changes
Sep 16, 2025
t8m
added
approval: done
Contributor
Author
|
merged to feature branch |
openssl-machine
pushed a commit
that referenced
this pull request
Sep 17, 2025
With ENGINES going away we need to remove these trace catagories Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from #28556)
openssl-machine
pushed a commit
that referenced
this pull request
Sep 17, 2025
As the subject indicates, with these trace categories gone, we shouldn't reference them in the docs anymore. Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from #28556)
nhorman
added a commit
that referenced
this pull request
Sep 17, 2025
With ENGINES going away we need to remove these trace catagories Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from #28556)
nhorman
added a commit
that referenced
this pull request
Sep 17, 2025
As the subject indicates, with these trace categories gone, we shouldn't reference them in the docs anymore. Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from #28556)
nhorman
added a commit
to nhorman/openssl
that referenced
this pull request
Sep 18, 2025
With ENGINES going away we need to remove these trace catagories Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from openssl#28556)
nhorman
added a commit
to nhorman/openssl
that referenced
this pull request
Sep 18, 2025
As the subject indicates, with these trace categories gone, we shouldn't reference them in the docs anymore. Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from openssl#28556)
mbroz
pushed a commit
to mbroz/openssl
that referenced
this pull request
Sep 18, 2025
With ENGINES going away we need to remove these trace catagories Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from openssl#28556)
mbroz
pushed a commit
to mbroz/openssl
that referenced
this pull request
Sep 18, 2025
As the subject indicates, with these trace categories gone, we shouldn't reference them in the docs anymore. Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from openssl#28556)
nhorman
added a commit
to nhorman/openssl
that referenced
this pull request
Sep 18, 2025
With ENGINES going away we need to remove these trace catagories Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from openssl#28556)
nhorman
added a commit
to nhorman/openssl
that referenced
this pull request
Sep 18, 2025
As the subject indicates, with these trace categories gone, we shouldn't reference them in the docs anymore. Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from openssl#28556)
nhorman
added a commit
to nhorman/openssl
that referenced
this pull request
Sep 18, 2025
With ENGINES going away we need to remove these trace catagories Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from openssl#28556)
nhorman
added a commit
to nhorman/openssl
that referenced
this pull request
Sep 18, 2025
As the subject indicates, with these trace categories gone, we shouldn't reference them in the docs anymore. Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from openssl#28556)
mbroz
pushed a commit
to mbroz/openssl
that referenced
this pull request
Oct 3, 2025
With ENGINES going away we need to remove these trace catagories Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from openssl#28556)
mbroz
pushed a commit
to mbroz/openssl
that referenced
this pull request
Oct 3, 2025
As the subject indicates, with these trace categories gone, we shouldn't reference them in the docs anymore. Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from openssl#28556)
nhorman
added a commit
to nhorman/openssl
that referenced
this pull request
Oct 3, 2025
With ENGINES going away we need to remove these trace catagories Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from openssl#28556)
nhorman
added a commit
to nhorman/openssl
that referenced
this pull request
Oct 3, 2025
As the subject indicates, with these trace categories gone, we shouldn't reference them in the docs anymore. Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from openssl#28556)
mbroz
pushed a commit
to mbroz/openssl
that referenced
this pull request
Dec 1, 2025
With ENGINES going away we need to remove these trace catagories Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from openssl#28556)
mbroz
pushed a commit
to mbroz/openssl
that referenced
this pull request
Dec 1, 2025
As the subject indicates, with these trace categories gone, we shouldn't reference them in the docs anymore. Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from openssl#28556)
nhorman
added a commit
to nhorman/openssl
that referenced
this pull request
Dec 1, 2025
With ENGINES going away we need to remove these trace catagories Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from openssl#28556)
nhorman
added a commit
to nhorman/openssl
that referenced
this pull request
Dec 1, 2025
As the subject indicates, with these trace categories gone, we shouldn't reference them in the docs anymore. Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from openssl#28556)
nhorman
added a commit
to nhorman/openssl
that referenced
this pull request
Dec 1, 2025
With ENGINES going away we need to remove these trace catagories Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from openssl#28556)
nhorman
added a commit
to nhorman/openssl
that referenced
this pull request
Dec 1, 2025
As the subject indicates, with these trace categories gone, we shouldn't reference them in the docs anymore. Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from openssl#28556)
mbroz
pushed a commit
to mbroz/openssl
that referenced
this pull request
Dec 4, 2025
With ENGINES going away we need to remove these trace catagories Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from openssl#28556)
mbroz
pushed a commit
to mbroz/openssl
that referenced
this pull request
Dec 4, 2025
As the subject indicates, with these trace categories gone, we shouldn't reference them in the docs anymore. Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from openssl#28556)
nhorman
added a commit
to nhorman/openssl
that referenced
this pull request
Dec 4, 2025
With ENGINES going away we need to remove these trace catagories Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from openssl#28556)
nhorman
added a commit
to nhorman/openssl
that referenced
this pull request
Dec 4, 2025
As the subject indicates, with these trace categories gone, we shouldn't reference them in the docs anymore. Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from openssl#28556)
mbroz
pushed a commit
to mbroz/openssl
that referenced
this pull request
Dec 4, 2025
With ENGINES going away we need to remove these trace catagories Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from openssl#28556)
mbroz
pushed a commit
to mbroz/openssl
that referenced
this pull request
Dec 4, 2025
As the subject indicates, with these trace categories gone, we shouldn't reference them in the docs anymore. Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from openssl#28556)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Engines going away we should eliminate these trace categories.
Remove them from the trace list, and any references to them, and update the documentation to exclude them
Checklist