Skip to content

Comments

25-test_verify.t: fix misleading test case names and file variable name#28469

Closed
DDvO wants to merge 1 commit intoopenssl:masterfrom
siemens:fix_25-test_verify_naming
Closed

25-test_verify.t: fix misleading test case names and file variable name#28469
DDvO wants to merge 1 commit intoopenssl:masterfrom
siemens:fix_25-test_verify_naming

Conversation

@DDvO
Copy link
Contributor

@DDvO DDvO commented Sep 8, 2025

This just fixes misleading test case names and a file variable name,
which recently came up further discussing #27984.
BTW, that discussion was tedious and did not bring up any further points to fix here.

@DDvO DDvO added branch: master Applies to master branch approval: review pending This pull request needs review by a committer triaged: refactor The issue/pr requests/implements refactoring tests: exempted The PR is exempt from requirements for testing labels Sep 8, 2025
This was referenced Sep 8, 2025
Closed
Closed
tom-cosgrove-arm
tom-cosgrove-arm reviewed Sep 11, 2025
View reviewed changes
tom-cosgrove-arm
tom-cosgrove-arm approved these changes Sep 11, 2025
View reviewed changes
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Sashan
Sashan approved these changes Sep 11, 2025
View reviewed changes
Copy link
Contributor

@Sashan Sashan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me thanks.

@tom-cosgrove-arm tom-cosgrove-arm added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Sep 11, 2025
paulidale
paulidale reviewed Sep 11, 2025
View reviewed changes
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Sep 12, 2025
@openssl-machine
Copy link
Collaborator

openssl-machine commented Sep 12, 2025

This pull request is ready to merge

@DDvO
Copy link
Contributor Author

DDvO commented Sep 17, 2025

Merged to master - thank you for the approvals.

@DDvO DDvO closed this Sep 17, 2025
openssl-machine pushed a commit that referenced this pull request Sep 17, 2025
@DDvO
25-test_verify.t: fix misleading test case names and file variable name
a5eaa0e 
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Tom Cosgrove <[email protected]>
Reviewed-by: Saša Nedvědický <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from #28469)
@nhorman
Copy link
Contributor

nhorman commented Sep 17, 2025

ping @DDvO , it appears that something in this PR may have broken 3.5:
https://github.com/openssl/openssl/actions/runs/17812910580

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tom-cosgrove-arm tom-cosgrove-arm tom-cosgrove-arm approved these changes

@Sashan Sashan Sashan approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

@paulidale paulidale paulidale approved these changes

@jogme jogme jogme approved these changes

Assignees

No one assigned

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Applies to master branch tests: exempted The PR is exempt from requirements for testing triaged: refactor The issue/pr requests/implements refactoring

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@DDvO @openssl-machine @nhorman @Sashan @mattcaswell @paulidale @jogme @tom-cosgrove-arm