Skip to content

Comments

Engine removal: Silence the CI tests about engines#28440

Closed
jogme wants to merge 3 commits intoopenssl:feature/engineremovalfrom
jogme:silence_engine_tests
Closed

Engine removal: Silence the CI tests about engines#28440
jogme wants to merge 3 commits intoopenssl:feature/engineremovalfrom
jogme:silence_engine_tests

Conversation

@jogme
Copy link
Contributor

@jogme jogme commented Sep 4, 2025

As we can't do every change in one big PR (and we also don't want),
therefore there always will be failing tests until everything is
resolved/cleaned up. This way we silence the CI about engine tests and
later we can reenable them to see what else needs to be fixed.

Resolves: openssl/project#1371

Checklist
  • documentation is added or updated
  • tests are added or updated

@jogme jogme force-pushed the silence_engine_tests branch from 09107f2 to 608f6e9 Compare September 4, 2025 14:38
@github-actions github-actions bot added severity: fips change The pull request changes FIPS provider sources severity: ABI change This pull request contains ABI changes labels Sep 4, 2025
@jogme jogme force-pushed the silence_engine_tests branch from 608f6e9 to 7f9e236 Compare September 4, 2025 14:57
@jogme jogme linked an issue Sep 4, 2025 that may be closed by this pull request
@bob-beck
Copy link
Contributor

bob-beck commented Sep 4, 2025

IS the CI failure due to this not being enabled? or due to your disabling of the gost engine test not doing what it is supposed to?

@jogme jogme force-pushed the silence_engine_tests branch from 7f9e236 to 8ed1ee7 Compare September 4, 2025 15:29
@jogme
Copy link
Contributor Author

jogme commented Sep 4, 2025

IS the CI failure due to this not being enabled? or due to your disabling of the gost engine test not doing what it is supposed to?

If the test pass now, then it was a typo It was a typo

@jogme jogme force-pushed the silence_engine_tests branch from 8ed1ee7 to 501ff7a Compare September 5, 2025 09:01
@jogme jogme force-pushed the silence_engine_tests branch from 501ff7a to 7bf4d67 Compare September 5, 2025 09:39
@jogme jogme mentioned this pull request Sep 5, 2025
2 tasks
Copy link
Contributor

@andrewkdinh andrewkdinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as an issue is created for each test skipped. Maybe one parent issue which is then a child of openssl/project#1318

@jogme
Copy link
Contributor Author

jogme commented Sep 5, 2025

LGTM as long as an issue is created for each test skipped. Maybe one parent issue which is then a child of openssl/project#1318

Issues were created. If I missed some, please add them there

@jogme jogme requested a review from Sashan September 6, 2025 06:18
@mbroz mbroz mentioned this pull request Sep 8, 2025
2 tasks
@t8m t8m added approval: review pending This pull request needs review by a committer triaged: refactor The issue/pr requests/implements refactoring labels Sep 8, 2025
nhorman pushed a commit to nhorman/openssl that referenced this pull request Sep 18, 2025
As we can't do every change in one big PR (and we also don't want),
therefore there always will be failing tests until everything is
resolved/cleaned up. This way we silence the CI about engine tests and
later we can reenable them to see what else needs to be fixed.

Resolves: openssl/project#1371

Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Saša Nedvědický <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from openssl#28440)
nhorman pushed a commit to nhorman/openssl that referenced this pull request Sep 18, 2025
Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Saša Nedvědický <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from openssl#28440)
nhorman pushed a commit to nhorman/openssl that referenced this pull request Sep 18, 2025
Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Saša Nedvědický <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from openssl#28440)
mbroz pushed a commit to mbroz/openssl that referenced this pull request Sep 18, 2025
As we can't do every change in one big PR (and we also don't want),
therefore there always will be failing tests until everything is
resolved/cleaned up. This way we silence the CI about engine tests and
later we can reenable them to see what else needs to be fixed.

Resolves: openssl/project#1371

Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Saša Nedvědický <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from openssl#28440)
mbroz pushed a commit to mbroz/openssl that referenced this pull request Sep 18, 2025
Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Saša Nedvědický <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from openssl#28440)
mbroz pushed a commit to mbroz/openssl that referenced this pull request Sep 18, 2025
Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Saša Nedvědický <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from openssl#28440)
nhorman pushed a commit to nhorman/openssl that referenced this pull request Sep 18, 2025
As we can't do every change in one big PR (and we also don't want),
therefore there always will be failing tests until everything is
resolved/cleaned up. This way we silence the CI about engine tests and
later we can reenable them to see what else needs to be fixed.

Resolves: openssl/project#1371

Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Saša Nedvědický <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from openssl#28440)
nhorman pushed a commit to nhorman/openssl that referenced this pull request Sep 18, 2025
Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Saša Nedvědický <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from openssl#28440)
nhorman pushed a commit to nhorman/openssl that referenced this pull request Sep 18, 2025
Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Saša Nedvědický <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from openssl#28440)
mbroz pushed a commit to mbroz/openssl that referenced this pull request Oct 3, 2025
As we can't do every change in one big PR (and we also don't want),
therefore there always will be failing tests until everything is
resolved/cleaned up. This way we silence the CI about engine tests and
later we can reenable them to see what else needs to be fixed.

Resolves: openssl/project#1371

Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Saša Nedvědický <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from openssl#28440)
mbroz pushed a commit to mbroz/openssl that referenced this pull request Oct 3, 2025
Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Saša Nedvědický <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from openssl#28440)
mbroz pushed a commit to mbroz/openssl that referenced this pull request Oct 3, 2025
Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Saša Nedvědický <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from openssl#28440)
nhorman pushed a commit to nhorman/openssl that referenced this pull request Oct 3, 2025
As we can't do every change in one big PR (and we also don't want),
therefore there always will be failing tests until everything is
resolved/cleaned up. This way we silence the CI about engine tests and
later we can reenable them to see what else needs to be fixed.

Resolves: openssl/project#1371

Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Saša Nedvědický <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from openssl#28440)
nhorman pushed a commit to nhorman/openssl that referenced this pull request Oct 3, 2025
Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Saša Nedvědický <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from openssl#28440)
nhorman pushed a commit to nhorman/openssl that referenced this pull request Oct 3, 2025
Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Saša Nedvědický <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from openssl#28440)
mbroz pushed a commit to mbroz/openssl that referenced this pull request Dec 1, 2025
As we can't do every change in one big PR (and we also don't want),
therefore there always will be failing tests until everything is
resolved/cleaned up. This way we silence the CI about engine tests and
later we can reenable them to see what else needs to be fixed.

Resolves: openssl/project#1371

Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Saša Nedvědický <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from openssl#28440)
mbroz pushed a commit to mbroz/openssl that referenced this pull request Dec 1, 2025
Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Saša Nedvědický <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from openssl#28440)
mbroz pushed a commit to mbroz/openssl that referenced this pull request Dec 1, 2025
Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Saša Nedvědický <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from openssl#28440)
nhorman pushed a commit to nhorman/openssl that referenced this pull request Dec 1, 2025
As we can't do every change in one big PR (and we also don't want),
therefore there always will be failing tests until everything is
resolved/cleaned up. This way we silence the CI about engine tests and
later we can reenable them to see what else needs to be fixed.

Resolves: openssl/project#1371

Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Saša Nedvědický <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from openssl#28440)
nhorman pushed a commit to nhorman/openssl that referenced this pull request Dec 1, 2025
Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Saša Nedvědický <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from openssl#28440)
nhorman pushed a commit to nhorman/openssl that referenced this pull request Dec 1, 2025
Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Saša Nedvědický <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from openssl#28440)
mbroz pushed a commit to mbroz/openssl that referenced this pull request Dec 4, 2025
As we can't do every change in one big PR (and we also don't want),
therefore there always will be failing tests until everything is
resolved/cleaned up. This way we silence the CI about engine tests and
later we can reenable them to see what else needs to be fixed.

Resolves: openssl/project#1371

Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Saša Nedvědický <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from openssl#28440)
mbroz pushed a commit to mbroz/openssl that referenced this pull request Dec 4, 2025
Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Saša Nedvědický <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from openssl#28440)
mbroz pushed a commit to mbroz/openssl that referenced this pull request Dec 4, 2025
Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Saša Nedvědický <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from openssl#28440)
nhorman pushed a commit to nhorman/openssl that referenced this pull request Dec 4, 2025
As we can't do every change in one big PR (and we also don't want),
therefore there always will be failing tests until everything is
resolved/cleaned up. This way we silence the CI about engine tests and
later we can reenable them to see what else needs to be fixed.

Resolves: openssl/project#1371

Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Saša Nedvědický <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from openssl#28440)
nhorman pushed a commit to nhorman/openssl that referenced this pull request Dec 4, 2025
Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Saša Nedvědický <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from openssl#28440)
nhorman pushed a commit to nhorman/openssl that referenced this pull request Dec 4, 2025
Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Saša Nedvědický <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from openssl#28440)
mbroz pushed a commit to mbroz/openssl that referenced this pull request Dec 4, 2025
As we can't do every change in one big PR (and we also don't want),
therefore there always will be failing tests until everything is
resolved/cleaned up. This way we silence the CI about engine tests and
later we can reenable them to see what else needs to be fixed.

Resolves: openssl/project#1371

Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Saša Nedvědický <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from openssl#28440)
mbroz pushed a commit to mbroz/openssl that referenced this pull request Dec 4, 2025
Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Saša Nedvědický <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from openssl#28440)
mbroz pushed a commit to mbroz/openssl that referenced this pull request Dec 4, 2025
Signed-off-by: Norbert Pocs <[email protected]>

Reviewed-by: Saša Nedvědický <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from openssl#28440)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge severity: ABI change This pull request contains ABI changes severity: fips change The pull request changes FIPS provider sources tests: exempted The PR is exempt from requirements for testing triaged: refactor The issue/pr requests/implements refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skip the engine dependent tests