fix length of digestinfo_sm3_der#28415
Closed
xiaoloudongfeng wants to merge 1 commit intoopenssl:masterfrom
Closed
fix length of digestinfo_sm3_der#28415xiaoloudongfeng wants to merge 1 commit intoopenssl:masterfrom
xiaoloudongfeng wants to merge 1 commit intoopenssl:masterfrom
Conversation
Member
slontis
added
branch: master
Member
|
(Not sure what branches this affects) |
Contributor
Author
|
Is there anything I can do to help keep things moving forward? @slontis |
Member
|
ping @openssl/committers for approval.. @t8m could this go into 3.6? |
slontis
approved these changes
Sep 15, 2025
github-actions
bot
added
severity: fips change
Contributor
Author
|
Hi, @t8m , this PR is a small fix, please take a look when you have a moment |
CLA: trivial
xiaoloudongfeng
force-pushed
the
fix-length-of-digestinfo_sm3_der
branch
from
0a4d469 to
1de979d
Compare
Member
|
ping @openssl/committers |
github-actions
bot
removed
the
severity: ABI change
paulidale
approved these changes
Sep 23, 2025
paulidale
added
approval: done
Contributor
|
Okay with trivial. Style failure is not relevant. |
paulidale
added
approval: done
Member
|
From a security viewpoint there are no buffer related issues arising from this. |
Contributor
|
Would signatures even have verified? |
Member
Yes because it runs the same code for the verify to generate the blob, and then does a verify. |
t8m
approved these changes
Sep 24, 2025
Member
|
OK with CLA: trivial |
Collaborator
|
24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually. |
t8m
added
approval: ready to merge
openssl-machine
pushed a commit
that referenced
this pull request
Sep 25, 2025
This fixes the RSA-SM3 signatures to conform to the standard. CLA: trivial Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Shane Lontis <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from #28415) (cherry picked from commit de0944c)
openssl-machine
pushed a commit
that referenced
this pull request
Sep 25, 2025
This fixes the RSA-SM3 signatures to conform to the standard. CLA: trivial Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Shane Lontis <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from #28415)
openssl-machine
pushed a commit
that referenced
this pull request
Sep 25, 2025
This fixes the RSA-SM3 signatures to conform to the standard. CLA: trivial Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Shane Lontis <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from #28415) (cherry picked from commit de0944c)
openssl-machine
pushed a commit
that referenced
this pull request
Sep 25, 2025
This fixes the RSA-SM3 signatures to conform to the standard. CLA: trivial Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Shane Lontis <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from #28415) (cherry picked from commit de0944c)
Member
|
Merged to the master, 3.6, 3.5 and 3.4 branches. Thank you for your contribution. |
esyr
added a commit
to esyr/openssl
that referenced
this pull request
Sep 30, 2025
3.5.4 CHANGES.md includes the following: * openssl#28098 * openssl#28415 * openssl#28504 * openssl#28535 * openssl#28569 * openssl#28573 * openssl#28576 * openssl#28591 * openssl#28603 * openssl#28624 * openssl#28642 * openssl#28676 3.5.4 NEWS.md includes the following: * openssl#28603 Updated the changes and news in the previous branches. Removed the attribution in NEWS.md incorrectly introduced in e551da6 "Update news and changes for the 3.5.3 release". Release: Yes Signed-off-by: Eugene Syromiatnikov <[email protected]>
esyr
added a commit
to esyr/openssl
that referenced
this pull request
Sep 30, 2025
3.4.3 CHANGES.md includes the following: * openssl#28098 * openssl#28415 * openssl#28504 * openssl#28535 * openssl#28591 * openssl#28603 * openssl#28624 * openssl#28642 3.4.3 NEWS.md do not have any updates. Updated the changes and news in the previous branches. Release: Yes Signed-off-by: Eugene Syromiatnikov <[email protected]>
esyr
added a commit
to esyr/openssl
that referenced
this pull request
Sep 30, 2025
3.5.4 CHANGES.md includes the following: * openssl#28098 * openssl#28415 * openssl#28504 * openssl#28535 * openssl#28569 * openssl#28573 * openssl#28576 * openssl#28591 * openssl#28603 * openssl#28624 * openssl#28642 * openssl#28676 3.5.4 NEWS.md includes the following: * openssl#28603 Updated the changes and news in the previous branches. Removed the attribution in NEWS.md incorrectly introduced in e551da6 "Update news and changes for the 3.5.3 release". Release: Yes Signed-off-by: Eugene Syromiatnikov <[email protected]>
esyr
added a commit
to esyr/openssl
that referenced
this pull request
Sep 30, 2025
3.4.3 CHANGES.md includes the following: * openssl#28098 * openssl#28198 * openssl#28398 * openssl#28411 * openssl#28415 * openssl#28449 * openssl#28504 * openssl#28535 * openssl#28591 * openssl#28603 * openssl#28624 * openssl#28642 3.4.3 NEWS.md do not have any updates. Updated the changes and news in the previous branches. Release: Yes Signed-off-by: Eugene Syromiatnikov <[email protected]>
esyr
added a commit
to esyr/openssl
that referenced
this pull request
Sep 30, 2025
3.5.4 CHANGES.md includes the following: * openssl#28098 * openssl#28415 * openssl#28504 * openssl#28535 * openssl#28569 * openssl#28573 * openssl#28576 * openssl#28591 * openssl#28603 * openssl#28624 * openssl#28642 * openssl#28676 3.5.4 NEWS.md includes the following: * openssl#28603 Updated the changes and news in the previous branches. Removed the attribution in NEWS.md incorrectly introduced in e551da6 "Update news and changes for the 3.5.3 release". Release: Yes Signed-off-by: Eugene Syromiatnikov <[email protected]>
esyr
added a commit
to esyr/openssl
that referenced
this pull request
Sep 30, 2025
3.5.4 CHANGES.md includes the following: * openssl#28098 * openssl#28415 * openssl#28504 * openssl#28535 * openssl#28569 * openssl#28573 * openssl#28576 * openssl#28591 * openssl#28603 * openssl#28624 * openssl#28642 * openssl#28676 3.5.4 NEWS.md includes the following: * openssl#28603 Updated the changes and news in the previous branches. Removed the attribution in NEWS.md incorrectly introduced in e551da6 "Update news and changes for the 3.5.3 release". Release: Yes Signed-off-by: Eugene Syromiatnikov <[email protected]>
esyr
added a commit
to esyr/openssl
that referenced
this pull request
Sep 30, 2025
3.4.3 CHANGES.md includes the following: * openssl#28098 * openssl#28198 * openssl#28398 * openssl#28411 * openssl#28415 * openssl#28449 * openssl#28504 * openssl#28535 * openssl#28591 * openssl#28603 * openssl#28624 * openssl#28642 3.4.3 NEWS.md do not have any updates. Updated the changes and news in the previous branches. Release: Yes Signed-off-by: Eugene Syromiatnikov <[email protected]>
openssl-machine
pushed a commit
that referenced
this pull request
Sep 30, 2025
3.5.4 CHANGES.md includes the following: * #28415 * #28573 * #28603 3.5.4 NEWS.md includes the following: * #28603 Release: Yes Signed-off-by: Eugene Syromiatnikov <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Tomas Mraz <[email protected]>
openssl-machine
pushed a commit
that referenced
this pull request
Sep 30, 2025
3.4.3 CHANGES.md includes the following: * #28198 * #28398 * #28411 * #28415 * #28449 Release: Yes Signed-off-by: Eugene Syromiatnikov <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Tomas Mraz <[email protected]>
esyr
added a commit
to esyr/openssl
that referenced
this pull request
Oct 1, 2025
3.5.4 CHANGES.md includes the following: * openssl#28415 * openssl#28573 * openssl#28603 3.5.4 NEWS.md includes the following: * openssl#28603 Release: Yes Signed-off-by: Eugene Syromiatnikov <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Tomas Mraz <[email protected]>
esyr
added a commit
to esyr/openssl
that referenced
this pull request
Oct 1, 2025
CHANGES.md: * Added mentions of CVE-2025-9230, CVE-2025-9231, CVE-2025-9232 * openssl#28415 * Add the release date for 3.5.4 * Various touch-ups aimed at improving consistency of the changes * ffixes, wfixes NEWS.md: * Added mentions of CVE-2025-9230, CVE-2025-9231, CVE-2025-9232 * Add the release date for 3.5.4 * Various touch-ups aimed at improving consistency of the news * ffixes, wfixes Release: Yes Signed-off-by: Eugene Syromiatnikov <[email protected]>
openssl-machine
pushed a commit
that referenced
this pull request
Oct 1, 2025
3.5.4 CHANGES.md includes the following: * #28415 * #28573 * #28603 3.5.4 NEWS.md includes the following: * #28603 Release: Yes Signed-off-by: Eugene Syromiatnikov <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from #28712)
esyr
added a commit
to esyr/openssl
that referenced
this pull request
Oct 2, 2025
3.5.4 CHANGES.md includes the following: * openssl#28415 * openssl#28573 * openssl#28603 3.5.4 NEWS.md includes the following: * openssl#28603 Release: Yes Signed-off-by: Eugene Syromiatnikov <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from openssl#28712)
openssl-machine
pushed a commit
that referenced
this pull request
Oct 17, 2025
3.5.4 CHANGES.md includes the following: * #28415 * #28573 * #28603 3.5.4 NEWS.md includes the following: * #28603 Release: Yes Signed-off-by: Eugene Syromiatnikov <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from #28734)
Member
|
FYI @xiaoloudongfeng : I included this PR in this blog post. |
MegaManSec
pushed a commit
to MegaManSec/openssl
that referenced
this pull request
Nov 11, 2025
3.5.4 CHANGES.md includes the following: * openssl#28415 * openssl#28573 * openssl#28603 3.5.4 NEWS.md includes the following: * openssl#28603 Release: Yes Signed-off-by: Eugene Syromiatnikov <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from openssl#28734)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ASN1 SEQUENCE length of digestinfo_sm3_der is 0x10 + SM3_DIGEST_LENGTH
CLA: trivial