hmac: stop using secure memory for the HMAC key (versions 3.3 and before)#28412
Closed
paulidale wants to merge 1 commit intoopenssl:openssl-3.3from
Closed
hmac: stop using secure memory for the HMAC key (versions 3.3 and before)#28412paulidale wants to merge 1 commit intoopenssl:openssl-3.3from
paulidale wants to merge 1 commit intoopenssl:openssl-3.3from
Conversation
Secure memory is design for long term storage of private material. HMAC keys are not this. Secure memory use was introduced in July 2020 by commit 3fddbb2. Fixes openssl#28346
paulidale
added
approval: review pending
paulidale
changed the title
github-actions
bot
added
the
severity: fips change
t8m
approved these changes
Sep 2, 2025
Contributor
Author
|
Ping for second review please |
esyr
approved these changes
Sep 3, 2025
Contributor
Author
|
Ping for second review please @openssl/committers |
beldmit
added
approval: done
openssl-machine
added
approval: ready to merge
Collaborator
|
This pull request is ready to merge |
openssl-machine
pushed a commit
that referenced
this pull request
Sep 7, 2025
Secure memory is design for long term storage of private material. HMAC keys are not this. Secure memory use was introduced in July 2020 by commit 3fddbb2. Fixes #28346 Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> (Merged from #28412)
Contributor
Author
|
Merged to 3.3, 3.2 and 3.0. |
openssl-machine
pushed a commit
that referenced
this pull request
Sep 7, 2025
Secure memory is design for long term storage of private material. HMAC keys are not this. Secure memory use was introduced in July 2020 by commit 3fddbb2. Fixes #28346 Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> (Merged from #28412) (cherry picked from commit 8e3c760)
openssl-machine
pushed a commit
that referenced
this pull request
Sep 7, 2025
Secure memory is design for long term storage of private material. HMAC keys are not this. Secure memory use was introduced in July 2020 by commit 3fddbb2. Fixes #28346 Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> (Merged from #28412) (cherry picked from commit 8e3c760)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Secure memory is design for long term storage of private material. HMAC keys are not this.
Secure memory use was introduced in July 2020 by commit 3fddbb2.
Fixes #28346
Back port after merge fix.