Skip to content

Comments

hmac: stop using secure memory for the HMAC key#28411

Closed
paulidale wants to merge 1 commit intoopenssl:masterfrom
paulidale:hmac-insecure-memory
Closed

hmac: stop using secure memory for the HMAC key#28411
paulidale wants to merge 1 commit intoopenssl:masterfrom
paulidale:hmac-insecure-memory

Conversation

@paulidale
Copy link
Contributor

Secure memory is designed for long term storage of private material. HMAC keys are not this.

Fixes #28346

Secure memory use was introduced in July 2020 by commit 3fddbb2.

Secure memory is design for long term storage of private material.
HMAC keys are not this.

Secure memory use was introduced in July 2020 by commit
3fddbb2.

Fixes openssl#28346
@paulidale paulidale self-assigned this Sep 1, 2025
@paulidale paulidale added branch: master Applies to master branch approval: review pending This pull request needs review by a committer triaged: bug The issue/pr is/fixes a bug branch: 3.0 Applies to openssl-3.0 branch tests: exempted The PR is exempt from requirements for testing branch: 3.2 Applies to openssl-3.2 (EOL) branch: 3.3 Applies to openssl-3.3 branch: 3.4 Applies to openssl-3.4 branch: 3.5 Applies to openssl-3.5 labels Sep 1, 2025
@github-actions github-actions bot added the severity: fips change The pull request changes FIPS provider sources label Sep 1, 2025
@paulidale paulidale added branch: 3.0 Applies to openssl-3.0 branch branch: 3.2 Applies to openssl-3.2 (EOL) branch: 3.3 Applies to openssl-3.3 and removed branch: 3.0 Applies to openssl-3.0 branch branch: 3.2 Applies to openssl-3.2 (EOL) branch: 3.3 Applies to openssl-3.3 labels Sep 1, 2025
@paulidale
Copy link
Contributor Author

paulidale commented Sep 1, 2025

Trivial conflict merging to 3.0, 3.2 and 3.3, so separate PR for them over in #28412.

@paulidale paulidale removed branch: 3.0 Applies to openssl-3.0 branch branch: 3.2 Applies to openssl-3.2 (EOL) branch: 3.3 Applies to openssl-3.3 labels Sep 1, 2025
@paulidale paulidale closed this Sep 1, 2025
@paulidale paulidale reopened this Sep 1, 2025
@paulidale
Copy link
Contributor Author

Since this is unlikely to make it into the 3.6 release, it should go there too.

@nhorman nhorman added the branch: 3.6 Applies to openssl-3.6 label Sep 2, 2025
@paulidale paulidale requested a review from a team September 2, 2025 23:27
@paulidale
Copy link
Contributor Author

Ping for second review please

openssl-machine pushed a commit that referenced this pull request Sep 7, 2025
Secure memory is design for long term storage of private material.
HMAC keys are not this.

Secure memory use was introduced in July 2020 by commit
3fddbb2.

Fixes #28346

Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Dmitry Belyavskiy <[email protected]>
(Merged from #28411)

(cherry picked from commit 362739d)
openssl-machine pushed a commit that referenced this pull request Sep 7, 2025
Secure memory is design for long term storage of private material.
HMAC keys are not this.

Secure memory use was introduced in July 2020 by commit
3fddbb2.

Fixes #28346

Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Dmitry Belyavskiy <[email protected]>
(Merged from #28411)
openssl-machine pushed a commit that referenced this pull request Sep 7, 2025
Secure memory is design for long term storage of private material.
HMAC keys are not this.

Secure memory use was introduced in July 2020 by commit
3fddbb2.

Fixes #28346

Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Dmitry Belyavskiy <[email protected]>
(Merged from #28411)

(cherry picked from commit 362739d)
@paulidale
Copy link
Contributor Author

Merged to 3.6, 3.5 and 3.4.

@paulidale paulidale closed this Sep 7, 2025
@paulidale paulidale deleted the hmac-insecure-memory branch September 7, 2025 07:26
esyr added a commit to esyr/openssl that referenced this pull request Sep 11, 2025
CHANGES.md:
 * openssl#28398
 * openssl#28411
 * openssl#28447
 * openssl#28449

NEWS.md:
 * openssl#28447

Release: yes
Signed-off-by: Eugene Syromiatnikov <[email protected]>
esyr added a commit to esyr/openssl that referenced this pull request Sep 11, 2025
CHANGES.md:
 * openssl#28398
 * openssl#28411
 * openssl#28447
 * openssl#28449

NEWS.md:
 * openssl#28447

Release: yes
Signed-off-by: Eugene Syromiatnikov <[email protected]>
esyr added a commit to esyr/openssl that referenced this pull request Sep 11, 2025
CHANGES.md:
 * openssl#28398
 * openssl#28411
 * openssl#28447
 * openssl#28449

NEWS.md:
 * openssl#28447

Release: yes
Signed-off-by: Eugene Syromiatnikov <[email protected]>
openssl-machine pushed a commit that referenced this pull request Sep 13, 2025
CHANGES.md:
 * #28398
 * #28411
 * #28447
 * #28449

NEWS.md:
 * #28447

Release: yes
Signed-off-by: Eugene Syromiatnikov <[email protected]>

Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from #28521)
esyr added a commit to esyr/openssl that referenced this pull request Sep 15, 2025
CHANGES.md:
 * openssl#28398
 * openssl#28411
 * openssl#28447
 * openssl#28449

NEWS.md:
 * openssl#28447

Release: yes
Signed-off-by: Eugene Syromiatnikov <[email protected]>
esyr added a commit to esyr/openssl that referenced this pull request Sep 15, 2025
CHANGES.md:
 * openssl#28198
 * openssl#28398
 * openssl#28411
 * openssl#28447
 * openssl#28449

NEWS.md:
 * openssl#28447

Release: Yes
Signed-off-by: Eugene Syromiatnikov <[email protected]>
esyr added a commit to esyr/openssl that referenced this pull request Sep 16, 2025
CHANGES.md:
 * openssl#28198
 * openssl#28398
 * openssl#28411
 * openssl#28447
 * openssl#28449

NEWS.md:
 * openssl#28447

Release: Yes
Signed-off-by: Eugene Syromiatnikov <[email protected]>
openssl-machine pushed a commit that referenced this pull request Sep 16, 2025
CHANGES.md:
 * #28198
 * #28398
 * #28411
 * #28447
 * #28449

NEWS.md:
 * #28447

Release: Yes
Signed-off-by: Eugene Syromiatnikov <[email protected]>

Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from #28558)
openssl-machine pushed a commit that referenced this pull request Sep 16, 2025
CHANGES.md:
 * #28398
 * #28411
 * #28447
 * #28449

NEWS.md:
 * #28447

Release: yes
Signed-off-by: Eugene Syromiatnikov <[email protected]>

Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from #28547)
esyr added a commit to esyr/openssl that referenced this pull request Sep 30, 2025
3.0.18 CHANGES.md includes the following:
 * openssl#28098
 * openssl#28198
 * openssl#28398
 * openssl#28411
 * openssl#28449
 * openssl#28504
 * openssl#28535
 * openssl#28591
 * openssl#28624

Release: Yes
Signed-off-by: Eugene Syromiatnikov <[email protected]>
esyr added a commit to esyr/openssl that referenced this pull request Sep 30, 2025
3.2.6 CHANGES.md includes the following:
 * openssl#28098
 * openssl#28198
 * openssl#28398
 * openssl#28411
 * openssl#28449
 * openssl#28504
 * openssl#28535
 * openssl#28591
 * openssl#28603
 * openssl#28624
 * openssl#28642

3.2.6 NEWS.md do not have any updates.

Updated the changes and news in the previous branches.

Release: Yes
Signed-off-by: Eugene Syromiatnikov <[email protected]>
esyr added a commit to esyr/openssl that referenced this pull request Sep 30, 2025
3.3.5 CHANGES.md includes the following:
 * openssl#28098
 * openssl#28198
 * openssl#28398
 * openssl#28411
 * openssl#28449
 * openssl#28504
 * openssl#28535
 * openssl#28591
 * openssl#28603
 * openssl#28624
 * openssl#28642

3.3.5 NEWS.md do not have any updates.

Updated the changes and news in the previous branches.

Release: Yes
Signed-off-by: Eugene Syromiatnikov <[email protected]>
esyr added a commit to esyr/openssl that referenced this pull request Sep 30, 2025
3.4.3 CHANGES.md includes the following:
 * openssl#28098
 * openssl#28198
 * openssl#28398
 * openssl#28411
 * openssl#28415
 * openssl#28449
 * openssl#28504
 * openssl#28535
 * openssl#28591
 * openssl#28603
 * openssl#28624
 * openssl#28642

3.4.3 NEWS.md do not have any updates.

Updated the changes and news in the previous branches.

Release: Yes
Signed-off-by: Eugene Syromiatnikov <[email protected]>
esyr added a commit to esyr/openssl that referenced this pull request Sep 30, 2025
3.3.5 CHANGES.md includes the following:
 * openssl#28098
 * openssl#28198
 * openssl#28398
 * openssl#28411
 * openssl#28449
 * openssl#28504
 * openssl#28535
 * openssl#28591
 * openssl#28603
 * openssl#28624
 * openssl#28642

3.3.5 NEWS.md do not have any updates.

Updated the changes and news in the previous branches.

Release: Yes
Signed-off-by: Eugene Syromiatnikov <[email protected]>
esyr added a commit to esyr/openssl that referenced this pull request Sep 30, 2025
3.4.3 CHANGES.md includes the following:
 * openssl#28098
 * openssl#28198
 * openssl#28398
 * openssl#28411
 * openssl#28415
 * openssl#28449
 * openssl#28504
 * openssl#28535
 * openssl#28591
 * openssl#28603
 * openssl#28624
 * openssl#28642

3.4.3 NEWS.md do not have any updates.

Updated the changes and news in the previous branches.

Release: Yes
Signed-off-by: Eugene Syromiatnikov <[email protected]>
esyr added a commit to esyr/openssl that referenced this pull request Sep 30, 2025
3.2.6 CHANGES.md includes the following:
 * openssl#28098
 * openssl#28198
 * openssl#28398
 * openssl#28411
 * openssl#28449
 * openssl#28504
 * openssl#28535
 * openssl#28591
 * openssl#28603
 * openssl#28624
 * openssl#28642

3.2.6 NEWS.md do not have any updates.

Updated the changes and news in the previous branches.

Release: Yes
Signed-off-by: Eugene Syromiatnikov <[email protected]>
esyr added a commit to esyr/openssl that referenced this pull request Sep 30, 2025
3.0.18 CHANGES.md includes the following:
 * openssl#28098
 * openssl#28198
 * openssl#28398
 * openssl#28411
 * openssl#28449
 * openssl#28504
 * openssl#28535
 * openssl#28591
 * openssl#28624

Release: Yes
Signed-off-by: Eugene Syromiatnikov <[email protected]>
openssl-machine pushed a commit that referenced this pull request Sep 30, 2025
3.4.3 CHANGES.md includes the following:
 * #28198
 * #28398
 * #28411
 * #28415
 * #28449

Release: Yes
Signed-off-by: Eugene Syromiatnikov <[email protected]>

Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
openssl-machine pushed a commit that referenced this pull request Sep 30, 2025
3.3.5 CHANGES.md includes the following:
 * #28198
 * #28398
 * #28411
 * #28449

Release: Yes
Signed-off-by: Eugene Syromiatnikov <[email protected]>

Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
openssl-machine pushed a commit that referenced this pull request Sep 30, 2025
3.2.6 CHANGES.md includes the following:
 * #28198
 * #28398
 * #28411
 * #28449

Release: Yes
Signed-off-by: Eugene Syromiatnikov <[email protected]>

Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
openssl-machine pushed a commit that referenced this pull request Sep 30, 2025
3.0.18 CHANGES.md includes the following:
 * #28198
 * #28398
 * #28411
 * #28449

Release: Yes
Signed-off-by: Eugene Syromiatnikov <[email protected]>

Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Applies to master branch branch: 3.4 Applies to openssl-3.4 branch: 3.5 Applies to openssl-3.5 branch: 3.6 Applies to openssl-3.6 severity: fips change The pull request changes FIPS provider sources tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants