Remove OPENSSL_NO_ENGINE guarded code#28384
Closed
jogme wants to merge 15 commits intoopenssl:feature/engineremovalfrom
Closed
Remove OPENSSL_NO_ENGINE guarded code#28384jogme wants to merge 15 commits intoopenssl:feature/engineremovalfrom
jogme wants to merge 15 commits intoopenssl:feature/engineremovalfrom
Conversation
Contributor
Author
|
Keeping in draft for now, because the tests will be failing for the above mentioned issues |
github-actions
bot
added
severity: fips change
This was
linked to
issues
Sep 2, 2025
jogme
force-pushed
the
engine_removal
branch
2 times, most recently
from
8d79b32 to
a5f8bf8
Compare
vavroch2010
requested review from
Sashan,
mattcaswell,
mbroz,
nhorman and
t8m
This was
linked to
issues
Sep 2, 2025
nhorman
requested changes
Sep 2, 2025
jogme
force-pushed
the
engine_removal
branch
4 times, most recently
from
be54e7d to
97b1a32
Compare
Contributor
Author
|
I reverted the file removals, as it can be addressed in later stages and should be out of scope of this PR |
jogme
force-pushed
the
engine_removal
branch
3 times, most recently
from
b787a0d to
a3a97b4
Compare
This was
linked to
issues
Sep 4, 2025
jogme
force-pushed
the
engine_removal
branch
from
636f131 to
b3be0f6
Compare
nhorman
pushed a commit
to nhorman/openssl
that referenced
this pull request
Dec 4, 2025
Signed-off-by: Norbert Pocs <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> (Merged from openssl#28384)
nhorman
pushed a commit
to nhorman/openssl
that referenced
this pull request
Dec 4, 2025
Signed-off-by: Norbert Pocs <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> (Merged from openssl#28384)
nhorman
pushed a commit
to nhorman/openssl
that referenced
this pull request
Dec 4, 2025
Resolves: openssl/project#1354 Signed-off-by: Norbert Pocs <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> (Merged from openssl#28384)
nhorman
pushed a commit
to nhorman/openssl
that referenced
this pull request
Dec 4, 2025
Signed-off-by: Norbert Pocs <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> (Merged from openssl#28384)
nhorman
pushed a commit
to nhorman/openssl
that referenced
this pull request
Dec 4, 2025
Signed-off-by: Norbert Pocs <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> (Merged from openssl#28384)
nhorman
pushed a commit
to nhorman/openssl
that referenced
this pull request
Dec 4, 2025
Signed-off-by: Norbert Pocs <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> (Merged from openssl#28384)
nhorman
pushed a commit
to nhorman/openssl
that referenced
this pull request
Dec 4, 2025
Signed-off-by: Norbert Pocs <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> (Merged from openssl#28384)
nhorman
pushed a commit
to nhorman/openssl
that referenced
this pull request
Dec 4, 2025
Signed-off-by: Norbert Pocs <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> (Merged from openssl#28384)
nhorman
pushed a commit
to nhorman/openssl
that referenced
this pull request
Dec 4, 2025
Signed-off-by: Norbert Pocs <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> (Merged from openssl#28384)
nhorman
pushed a commit
to nhorman/openssl
that referenced
this pull request
Dec 4, 2025
Signed-off-by: Norbert Pocs <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> (Merged from openssl#28384)
nhorman
pushed a commit
to nhorman/openssl
that referenced
this pull request
Dec 4, 2025
Most of the ifdefs were removed, but we want to rewrite the dasync engine to a provider. Therefore that code was not removed; instead a new temporary macro was added named TODO_REWRITE_ME_DASYNC_PROVIDER. Resolves: openssl/project#1363 Signed-off-by: Norbert Pocs <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> (Merged from openssl#28384)
nhorman
pushed a commit
to nhorman/openssl
that referenced
this pull request
Dec 4, 2025
Resolves: openssl/project#1364 Signed-off-by: Norbert Pocs <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> (Merged from openssl#28384)
nhorman
pushed a commit
to nhorman/openssl
that referenced
this pull request
Dec 4, 2025
Resolves: openssl/project#1352 Resolves: openssl/project#1353 Signed-off-by: Milan Broz <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> (Merged from openssl#28384)
nhorman
pushed a commit
to nhorman/openssl
that referenced
this pull request
Dec 4, 2025
Resolves: openssl/project#1368 Signed-off-by: Milan Broz <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> (Merged from openssl#28384)
nhorman
pushed a commit
to nhorman/openssl
that referenced
this pull request
Dec 4, 2025
Signed-off-by: Norbert Pocs <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> (Merged from openssl#28384)
mbroz
pushed a commit
to mbroz/openssl
that referenced
this pull request
Dec 4, 2025
Signed-off-by: Norbert Pocs <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> (Merged from openssl#28384)
mbroz
pushed a commit
to mbroz/openssl
that referenced
this pull request
Dec 4, 2025
Signed-off-by: Norbert Pocs <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> (Merged from openssl#28384)
mbroz
pushed a commit
to mbroz/openssl
that referenced
this pull request
Dec 4, 2025
Resolves: openssl/project#1354 Signed-off-by: Norbert Pocs <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> (Merged from openssl#28384)
mbroz
pushed a commit
to mbroz/openssl
that referenced
this pull request
Dec 4, 2025
Signed-off-by: Norbert Pocs <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> (Merged from openssl#28384)
mbroz
pushed a commit
to mbroz/openssl
that referenced
this pull request
Dec 4, 2025
Signed-off-by: Norbert Pocs <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> (Merged from openssl#28384)
mbroz
pushed a commit
to mbroz/openssl
that referenced
this pull request
Dec 4, 2025
Signed-off-by: Norbert Pocs <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> (Merged from openssl#28384)
mbroz
pushed a commit
to mbroz/openssl
that referenced
this pull request
Dec 4, 2025
Signed-off-by: Norbert Pocs <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> (Merged from openssl#28384)
mbroz
pushed a commit
to mbroz/openssl
that referenced
this pull request
Dec 4, 2025
Signed-off-by: Norbert Pocs <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> (Merged from openssl#28384)
mbroz
pushed a commit
to mbroz/openssl
that referenced
this pull request
Dec 4, 2025
Signed-off-by: Norbert Pocs <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> (Merged from openssl#28384)
mbroz
pushed a commit
to mbroz/openssl
that referenced
this pull request
Dec 4, 2025
Signed-off-by: Norbert Pocs <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> (Merged from openssl#28384)
mbroz
pushed a commit
to mbroz/openssl
that referenced
this pull request
Dec 4, 2025
Most of the ifdefs were removed, but we want to rewrite the dasync engine to a provider. Therefore that code was not removed; instead a new temporary macro was added named TODO_REWRITE_ME_DASYNC_PROVIDER. Resolves: openssl/project#1363 Signed-off-by: Norbert Pocs <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> (Merged from openssl#28384)
mbroz
pushed a commit
to mbroz/openssl
that referenced
this pull request
Dec 4, 2025
Resolves: openssl/project#1364 Signed-off-by: Norbert Pocs <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> (Merged from openssl#28384)
mbroz
added a commit
to mbroz/openssl
that referenced
this pull request
Dec 4, 2025
Resolves: openssl/project#1352 Resolves: openssl/project#1353 Signed-off-by: Milan Broz <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> (Merged from openssl#28384)
mbroz
added a commit
to mbroz/openssl
that referenced
this pull request
Dec 4, 2025
Resolves: openssl/project#1368 Signed-off-by: Milan Broz <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> (Merged from openssl#28384)
mbroz
pushed a commit
to mbroz/openssl
that referenced
this pull request
Dec 4, 2025
Signed-off-by: Norbert Pocs <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Neil Horman <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> (Merged from openssl#28384)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-enginecli flag which is tracked at fix up tests that use engines project#1338) and this will probably be blocked by translate ossltest engine to a provider project#1336Resolves: openssl/project#1335
Resolves: openssl/project#1355
Checklist