Fix a crash or unbounded allocation in RSA_padding_add_PKCS1_PSS_mgf1#2801
Closed
bernd-edlinger wants to merge 2 commits intoopenssl:masterfrom
Closed
Fix a crash or unbounded allocation in RSA_padding_add_PKCS1_PSS_mgf1#2801bernd-edlinger wants to merge 2 commits intoopenssl:masterfrom
bernd-edlinger wants to merge 2 commits intoopenssl:masterfrom
Conversation
and RSA_verify_PKCS1_PSS_mgf1 with 512-bit RSA vs. sha-512.
bernd-edlinger
force-pushed
the
fix_crash_in_RSA_padding_add_PKCS1_PSS_mgf1
branch
from
41f282b to
93e60f4
Compare
Member
Author
|
rebased. |
mattcaswell
approved these changes
Mar 8, 2017
Member
mattcaswell
left a comment
mattcaswell
left a comment
There was a problem hiding this comment.
LGTM. What branches is this for?
Member
Author
|
This is for master, I need to make an extra PRs for 1.1.0 and 1.0.2. PS: Should I squash the two commits? |
Member
|
No need to squash the commits IMO. |
dot-asm
approved these changes
Mar 13, 2017
dot-asm
added
the
approval: done
Contributor
|
Applied to master. Thanks! |
levitte
pushed a commit
that referenced
this pull request
Mar 13, 2017
and RSA_verify_PKCS1_PSS_mgf1 with 512-bit RSA vs. sha-512. Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Andy Polyakov <[email protected]> (Merged from #2801)
levitte
pushed a commit
that referenced
this pull request
Mar 13, 2017
Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Andy Polyakov <[email protected]> (Merged from #2801)
This was referenced Dec 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and RSA_verify_PKCS1_PSS_mgf1 with 512-bit RSA vs. sha-512.
@guidovranken: here is how I would like to fix the pss signature functions.
I hope this makes it clear what I meant with the comments on #2699.
I have test cases but don't know how to integrate that in the test framework.
for the problem in RSA_padding_verify I need first a data block
that can be decrypted by the RSA key and clear text ends with 0xBC.