Relax absolut path checking in our 'file' scheme implementation#27482
Closed
levitte wants to merge 1 commit intoopenssl:masterfrom
Closed
Relax absolut path checking in our 'file' scheme implementation#27482levitte wants to merge 1 commit intoopenssl:masterfrom
levitte wants to merge 1 commit intoopenssl:masterfrom
Conversation
levitte
force-pushed
the
fix-27461
branch
2 times, most recently
from
63f1f68 to
f704c6c
Compare
Contributor
|
Nice that this generalization even simplifies the code. |
|
This is not correction to #27461 . |
Member
Author
|
"by store" is the OSSL_STORE replacement of "by file" and "by dir". |
levitte
added
branch: master
mattcaswell
previously approved these changes
Apr 24, 2025
Member
mattcaswell
left a comment
mattcaswell
left a comment
There was a problem hiding this comment.
I wonder if this is worthy of a CHANGES.md entry?
Member
Author
Good idea. I added it just now... which means that you will have to re-approve as soon as I've also rebased... |
So far, we strictly obeyed [RFC 8089], which only allows absolute paths in a 'file:' URI. However, this seems to give a confusing user experience, where something like 'file:foo.pem' wouldn't open foo.pem, even though it's there in the current directory, but 'file:$(pwd)/foo.pem' would. To be less surprising for such use cases, we relax our implementation visavi [RFC 8089] to allow relative paths. [RFC 8089]: https://datatracker.ietf.org/doc/html/rfc8089 Fixes openssl#27461
t8m
approved these changes
Apr 24, 2025
mattcaswell
approved these changes
Apr 24, 2025
t8m
added
approval: done
openssl-machine
added
approval: ready to merge
Collaborator
|
This pull request is ready to merge |
Member
|
Merged to the master branch. Thank you. |
openssl-machine
pushed a commit
that referenced
this pull request
Apr 25, 2025
So far, we strictly obeyed [RFC 8089], which only allows absolute paths in a 'file:' URI. However, this seems to give a confusing user experience, where something like 'file:foo.pem' wouldn't open foo.pem, even though it's there in the current directory, but 'file:$(pwd)/foo.pem' would. To be less surprising for such use cases, we relax our implementation visavi [RFC 8089] to allow relative paths. [RFC 8089]: https://datatracker.ietf.org/doc/html/rfc8089 Fixes #27461 Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from #27482)
This was referenced Apr 26, 2025
DDvO
pushed a commit
to siemens/openssl
that referenced
this pull request
Jun 16, 2025
So far, we strictly obeyed [RFC 8089], which only allows absolute paths in a 'file:' URI. However, this seems to give a confusing user experience, where something like 'file:foo.pem' wouldn't open foo.pem, even though it's there in the current directory, but 'file:$(pwd)/foo.pem' would. To be less surprising for such use cases, we relax our implementation visavi [RFC 8089] to allow relative paths. [RFC 8089]: https://datatracker.ietf.org/doc/html/rfc8089 Fixes openssl#27461 Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from openssl#27482)
MichaelA-Fireblocks
pushed a commit
to MichaelA-Fireblocks/openssl
that referenced
this pull request
Jul 15, 2025
So far, we strictly obeyed [RFC 8089], which only allows absolute paths in a 'file:' URI. However, this seems to give a confusing user experience, where something like 'file:foo.pem' wouldn't open foo.pem, even though it's there in the current directory, but 'file:$(pwd)/foo.pem' would. To be less surprising for such use cases, we relax our implementation visavi [RFC 8089] to allow relative paths. [RFC 8089]: https://datatracker.ietf.org/doc/html/rfc8089 Fixes openssl#27461 Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from openssl#27482)
MichaelA-Fireblocks
pushed a commit
to MichaelA-Fireblocks/openssl
that referenced
this pull request
Jul 15, 2025
So far, we strictly obeyed [RFC 8089], which only allows absolute paths in a 'file:' URI. However, this seems to give a confusing user experience, where something like 'file:foo.pem' wouldn't open foo.pem, even though it's there in the current directory, but 'file:$(pwd)/foo.pem' would. To be less surprising for such use cases, we relax our implementation visavi [RFC 8089] to allow relative paths. [RFC 8089]: https://datatracker.ietf.org/doc/html/rfc8089 Fixes openssl#27461 Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from openssl#27482)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far, we strictly obeyed RFC 8089, which only allows absolute paths
in a
file:URI. However, this seems to give a confusing userexperience, where something like
file:foo.pemwouldn't open foo.pem,even though it's there in the current directory, but
file:$(pwd)/foo.pemwould.
To be less surprising for such use cases, we relax our implementation
visavi RFC 8089 to allow relative paths.
Fixes #27461