Skip to content

Log name of provided peer temp keys #26734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vdukhovni wants to merge 1 commit into from
Closed

Log name of provided peer temp keys #26734

vdukhovni wants to merge 1 commit into from

Conversation

@vdukhovni
Copy link

@vdukhovni vdukhovni commented Feb 13, 2025

Log the peer's temp key name when it is from a provider.

t8m
t8m reviewed Feb 13, 2025
View reviewed changes
@t8m t8m added branch: master Applies to master branch approval: review pending This pull request needs review by a committer triaged: feature The issue/pr requests/adds a feature tests: exempted The PR is exempt from requirements for testing labels Feb 13, 2025
@vdukhovni vdukhovni force-pushed the log-provided-peer-temp-keys branch from d1ee849 to 908294a Compare February 13, 2025 10:53
Log name of provided peer temp keys
c4a775b 
Log the peer's temp key name when it is from a provider.
@vdukhovni vdukhovni force-pushed the log-provided-peer-temp-keys branch from 908294a to c4a775b Compare February 13, 2025 10:58
@t-j-h t-j-h added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Feb 13, 2025
@t-j-h t-j-h added this to the 3.5.0 Feature Complete milestone Feb 13, 2025
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Feb 14, 2025
@openssl-machine
Copy link
Collaborator

openssl-machine commented Feb 14, 2025

This pull request is ready to merge

@t8m
Copy link
Member

t8m commented Feb 14, 2025

Merged to the master branch. Thank you.

@t8m t8m closed this Feb 14, 2025
openssl-machine pushed a commit that referenced this pull request Feb 14, 2025
@t8m
Log name of provided peer temp keys
a39dc27 
Log the peer's temp key name when it is from a provider.

Reviewed-by: Tim Hudson <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from #26734)
definability pushed a commit to definability/openssl that referenced this pull request Feb 25, 2025
@definability
Log name of provided peer temp keys
d378240 
Log the peer's temp key name when it is from a provider.

Reviewed-by: Tim Hudson <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from openssl#26734)
quarckster pushed a commit to quarckster/openssl-fork that referenced this pull request Feb 27, 2025
@quarckster
Log name of provided peer temp keys
0a23f18 
Log the peer's temp key name when it is from a provider.

Reviewed-by: Tim Hudson <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from openssl#26734)
This was referenced Mar 15, 2025
Merged
Merged
nodejs-github-bot pushed a commit to nodejs/node that referenced this pull request Mar 17, 2025
@richardlau
test: update parallel/test-tls-dhe for OpenSSL 3.5
fab6906 
The output of the `s_client` command invoked by the test has changed
in the OpenSSL 3.5.0 version of `s_client`. Update the test so that
it works with both the old and new output -- the `s_client` binary
being run may not be at the exact same version of OpenSSL as used
by Node.js so the updated test allows either output.

PR-URL: #57477
Refs: openssl/openssl#26734
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
aduh95 pushed a commit to nodejs/node that referenced this pull request Mar 23, 2025
@richardlau @aduh95
test: update parallel/test-tls-dhe for OpenSSL 3.5
27b01ed 
The output of the `s_client` command invoked by the test has changed
in the OpenSSL 3.5.0 version of `s_client`. Update the test so that
it works with both the old and new output -- the `s_client` binary
being run may not be at the exact same version of OpenSSL as used
by Node.js so the updated test allows either output.

PR-URL: #57477
Refs: openssl/openssl#26734
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS pushed a commit to nodejs/node that referenced this pull request Apr 1, 2025
@richardlau @RafaelGSS
test: update parallel/test-tls-dhe for OpenSSL 3.5
afaede4 
The output of the `s_client` command invoked by the test has changed
in the OpenSSL 3.5.0 version of `s_client`. Update the test so that
it works with both the old and new output -- the `s_client` binary
being run may not be at the exact same version of OpenSSL as used
by Node.js so the updated test allows either output.

PR-URL: #57477
Refs: openssl/openssl#26734
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS pushed a commit to nodejs/node that referenced this pull request Apr 1, 2025
@richardlau @RafaelGSS
test: update parallel/test-tls-dhe for OpenSSL 3.5
a0bf0e8 
The output of the `s_client` command invoked by the test has changed
in the OpenSSL 3.5.0 version of `s_client`. Update the test so that
it works with both the old and new output -- the `s_client` binary
being run may not be at the exact same version of OpenSSL as used
by Node.js so the updated test allows either output.

PR-URL: #57477
Refs: openssl/openssl#26734
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
richardlau added a commit to nodejs/node that referenced this pull request Apr 4, 2025
@richardlau
test: update parallel/test-tls-dhe for OpenSSL 3.5
91a771d 
The output of the `s_client` command invoked by the test has changed
in the OpenSSL 3.5.0 version of `s_client`. Update the test so that
it works with both the old and new output -- the `s_client` binary
being run may not be at the exact same version of OpenSSL as used
by Node.js so the updated test allows either output.

PR-URL: #57477
Refs: openssl/openssl#26734
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Apr 8, 2025
@richardlau @RafaelGSS
test: update parallel/test-tls-dhe for OpenSSL 3.5
fca3430 
The output of the `s_client` command invoked by the test has changed
in the OpenSSL 3.5.0 version of `s_client`. Update the test so that
it works with both the old and new output -- the `s_client` binary
being run may not be at the exact same version of OpenSSL as used
by Node.js so the updated test allows either output.

PR-URL: nodejs#57477
Refs: openssl/openssl#26734
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS pushed a commit to nodejs/node that referenced this pull request Apr 14, 2025
@richardlau @RafaelGSS
test: update parallel/test-tls-dhe for OpenSSL 3.5
439eced 
The output of the `s_client` command invoked by the test has changed
in the OpenSSL 3.5.0 version of `s_client`. Update the test so that
it works with both the old and new output -- the `s_client` binary
being run may not be at the exact same version of OpenSSL as used
by Node.js so the updated test allows either output.

PR-URL: #57477
Refs: openssl/openssl#26734
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS pushed a commit to nodejs/node that referenced this pull request Apr 14, 2025
@richardlau @RafaelGSS
test: update parallel/test-tls-dhe for OpenSSL 3.5
0b204c6 
The output of the `s_client` command invoked by the test has changed
in the OpenSSL 3.5.0 version of `s_client`. Update the test so that
it works with both the old and new output -- the `s_client` binary
being run may not be at the exact same version of OpenSSL as used
by Node.js so the updated test allows either output.

PR-URL: #57477
Refs: openssl/openssl#26734
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
aduh95 pushed a commit to nodejs/node that referenced this pull request Apr 14, 2025
@richardlau @aduh95
test: update parallel/test-tls-dhe for OpenSSL 3.5
b250783 
The output of the `s_client` command invoked by the test has changed
in the OpenSSL 3.5.0 version of `s_client`. Update the test so that
it works with both the old and new output -- the `s_client` binary
being run may not be at the exact same version of OpenSSL as used
by Node.js so the updated test allows either output.

PR-URL: #57477
Refs: openssl/openssl#26734
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
aduh95 pushed a commit to nodejs/node that referenced this pull request Apr 14, 2025
@richardlau @aduh95
test: update parallel/test-tls-dhe for OpenSSL 3.5
ce14938 
The output of the `s_client` command invoked by the test has changed
in the OpenSSL 3.5.0 version of `s_client`. Update the test so that
it works with both the old and new output -- the `s_client` binary
being run may not be at the exact same version of OpenSSL as used
by Node.js so the updated test allows either output.

PR-URL: #57477
Refs: openssl/openssl#26734
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
aduh95 pushed a commit to nodejs/node that referenced this pull request Apr 15, 2025
@richardlau @aduh95
test: update parallel/test-tls-dhe for OpenSSL 3.5
d854bc1 
The output of the `s_client` command invoked by the test has changed
in the OpenSSL 3.5.0 version of `s_client`. Update the test so that
it works with both the old and new output -- the `s_client` binary
being run may not be at the exact same version of OpenSSL as used
by Node.js so the updated test allows either output.

PR-URL: #57477
Refs: openssl/openssl#26734
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS pushed a commit to nodejs/node that referenced this pull request Apr 16, 2025
@richardlau @RafaelGSS
test: update parallel/test-tls-dhe for OpenSSL 3.5
fa93bb2 
The output of the `s_client` command invoked by the test has changed
in the OpenSSL 3.5.0 version of `s_client`. Update the test so that
it works with both the old and new output -- the `s_client` binary
being run may not be at the exact same version of OpenSSL as used
by Node.js so the updated test allows either output.

PR-URL: #57477
Refs: openssl/openssl#26734
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS pushed a commit to nodejs/node that referenced this pull request Apr 16, 2025
@richardlau @RafaelGSS
test: update parallel/test-tls-dhe for OpenSSL 3.5
664b3b8 
The output of the `s_client` command invoked by the test has changed
in the OpenSSL 3.5.0 version of `s_client`. Update the test so that
it works with both the old and new output -- the `s_client` binary
being run may not be at the exact same version of OpenSSL as used
by Node.js so the updated test allows either output.

PR-URL: #57477
Refs: openssl/openssl#26734
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS pushed a commit to nodejs/node that referenced this pull request Apr 17, 2025
@richardlau @RafaelGSS
test: update parallel/test-tls-dhe for OpenSSL 3.5
cac9a4e 
The output of the `s_client` command invoked by the test has changed
in the OpenSSL 3.5.0 version of `s_client`. Update the test so that
it works with both the old and new output -- the `s_client` binary
being run may not be at the exact same version of OpenSSL as used
by Node.js so the updated test allows either output.

PR-URL: #57477
Refs: openssl/openssl#26734
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS pushed a commit to nodejs/node that referenced this pull request May 1, 2025
@richardlau @RafaelGSS
test: update parallel/test-tls-dhe for OpenSSL 3.5
4086492 
The output of the `s_client` command invoked by the test has changed
in the OpenSSL 3.5.0 version of `s_client`. Update the test so that
it works with both the old and new output -- the `s_client` binary
being run may not be at the exact same version of OpenSSL as used
by Node.js so the updated test allows either output.

PR-URL: #57477
Refs: openssl/openssl#26734
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS pushed a commit to nodejs/node that referenced this pull request May 2, 2025
@richardlau @RafaelGSS
test: update parallel/test-tls-dhe for OpenSSL 3.5
e2b862a 
The output of the `s_client` command invoked by the test has changed
in the OpenSSL 3.5.0 version of `s_client`. Update the test so that
it works with both the old and new output -- the `s_client` binary
being run may not be at the exact same version of OpenSSL as used
by Node.js so the updated test allows either output.

PR-URL: #57477
Refs: openssl/openssl#26734
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
DDvO pushed a commit to siemens/openssl that referenced this pull request Jun 16, 2025
@DDvO
Log name of provided peer temp keys
d88dfb0 
Log the peer's temp key name when it is from a provider.

Reviewed-by: Tim Hudson <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from openssl#26734)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@t8m t8m t8m approved these changes

@t-j-h t-j-h t-j-h approved these changes

Assignees

No one assigned

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Applies to master branch tests: exempted The PR is exempt from requirements for testing triaged: feature The issue/pr requests/adds a feature

Projects

Development Board
Status: Done

Milestone

3.5.0 Feature Complete

Development

Successfully merging this pull request may close these issues.

4 participants

@vdukhovni @openssl-machine @t8m @t-j-h