Closed
Conversation
Although this cannot really happen check for 0 block size to avoid division by 0. Fixes Coverity 1633936
t8m
added
branch: master
paulidale
approved these changes
Oct 29, 2024
mattcaswell
approved these changes
Oct 29, 2024
mattcaswell
added
approval: done
shahsb
approved these changes
Oct 30, 2024
Contributor
shahsb
left a comment
shahsb
left a comment
There was a problem hiding this comment.
LGTM.
Thanks for addressing this.
openssl-machine
added
approval: ready to merge
Collaborator
|
This pull request is ready to merge |
Member
Author
|
Merged to the master, 3.4, 3.3 and 3.2 branches. Thank you for the reviews. |
openssl-machine
pushed a commit
that referenced
this pull request
Oct 31, 2024
Although this cannot really happen check for 0 block size to avoid division by 0. Fixes Coverity 1633936 Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> (Merged from #25822) (cherry picked from commit 59f5f6c)
openssl-machine
pushed a commit
that referenced
this pull request
Oct 31, 2024
Although this cannot really happen check for 0 block size to avoid division by 0. Fixes Coverity 1633936 Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> (Merged from #25822)
openssl-machine
pushed a commit
that referenced
this pull request
Oct 31, 2024
Although this cannot really happen check for 0 block size to avoid division by 0. Fixes Coverity 1633936 Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> (Merged from #25822) (cherry picked from commit 59f5f6c)
openssl-machine
pushed a commit
that referenced
this pull request
Oct 31, 2024
Although this cannot really happen check for 0 block size to avoid division by 0. Fixes Coverity 1633936 Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> (Merged from #25822) (cherry picked from commit 59f5f6c)
coolshrid
pushed a commit
to coolshrid/openssl
that referenced
this pull request
Nov 9, 2024
Although this cannot really happen check for 0 block size to avoid division by 0. Fixes Coverity 1633936 Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Dmitry Belyavskiy <[email protected]> Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> (Merged from openssl#25822)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although this cannot really happen check for 0 block size to avoid division by 0.
Fixes Coverity 1633936