-
-
Notifications
You must be signed in to change notification settings - Fork 11k
[Docs] Notes about freeing objects #24478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ruslo
commented
May 23, 2024
- documentation is added or updated
|
I am not sure about this one. Factually it is of course true, however there are many other functions like this that obviously construct some new objects either in clean state or by decoding some data. I would not like to confuse users that only these PEM_read functions create objects to be owned by caller. If we documented all the similar places then OK but just changing this place looks wrong to me. |
I'm just clarifying parts that cover my scenario, which I tested with valgrind. I haven't touched any other API. Can you give me a list of similar places? |
Dismissing my own review, as it may have been premature
|
I'm thinking that the page describing all the
So it seems that in some places, we do at least give a hint that something needs to be freed. |
- Free objects returned from PEM read - Free objects returned from d2i_*
A similar note added to Let me know what other pages you think need to be updated. |
|
This pull request is ready to merge |
- Free objects returned from PEM read - Free objects returned from d2i_* Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from #24478)
|
Merged to all the active branches. Thank you for your contribution. |
- Free objects returned from PEM read - Free objects returned from d2i_* Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from #24478) (cherry picked from commit d4700c0)
- Free objects returned from PEM read - Free objects returned from d2i_* Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from #24478) (cherry picked from commit d4700c0)
- Free objects returned from PEM read - Free objects returned from d2i_* Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from #24478) (cherry picked from commit d4700c0)
- Free objects returned from PEM read - Free objects returned from d2i_* Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from #24478) (cherry picked from commit d4700c0)