Skip to content

Comments

ossl_property_list_to_string: handle quoted strings#22182

Closed
paulidale wants to merge 1 commit intoopenssl:masterfrom
paulidale:fix-property-to-string
Closed

ossl_property_list_to_string: handle quoted strings#22182
paulidale wants to merge 1 commit intoopenssl:masterfrom
paulidale:fix-property-to-string

Conversation

@paulidale
Copy link
Contributor

ossl_property_list_to_string() didn't quote strings correctly which could result in a generated property string being unparsable.

  • documentation is added or updated
  • tests are added or updated

ossl_property_list_to_string() didn't quote strings correctly which
could result in a generated property string being unparsable.
@paulidale paulidale added branch: master Applies to master branch approval: review pending This pull request needs review by a committer approval: otc review pending triaged: bug The issue/pr is/fixes a bug branch: 3.0 Applies to openssl-3.0 branch branch: 3.1 Applies to openssl-3.1 (EOL) tests: present The PR has suitable tests present labels Sep 24, 2023
@paulidale paulidale self-assigned this Sep 24, 2023
@github-actions github-actions bot added the severity: fips change The pull request changes FIPS provider sources label Sep 24, 2023
@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Oct 3, 2023
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Oct 4, 2023
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Oct 4, 2023
ossl_property_list_to_string() didn't quote strings correctly which
could result in a generated property string being unparsable.

Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from #22182)

(cherry picked from commit fb20e66)
openssl-machine pushed a commit that referenced this pull request Oct 4, 2023
ossl_property_list_to_string() didn't quote strings correctly which
could result in a generated property string being unparsable.

Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from #22182)
openssl-machine pushed a commit that referenced this pull request Oct 4, 2023
ossl_property_list_to_string() didn't quote strings correctly which
could result in a generated property string being unparsable.

Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from #22182)

(cherry picked from commit fb20e66)
@paulidale paulidale closed this Oct 4, 2023
@paulidale paulidale deleted the fix-property-to-string branch October 4, 2023 21:14
wanghao75 pushed a commit to openeuler-mirror/openssl that referenced this pull request Oct 9, 2023
ossl_property_list_to_string() didn't quote strings correctly which
could result in a generated property string being unparsable.

Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from openssl/openssl#22182)

(cherry picked from commit fb20e66)
Signed-off-by: fly2x <[email protected]>
wanghao75 pushed a commit to openeuler-mirror/openssl that referenced this pull request Oct 9, 2023
ossl_property_list_to_string() didn't quote strings correctly which
could result in a generated property string being unparsable.

Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from openssl/openssl#22182)

Signed-off-by: fly2x <[email protected]>
wanghao75 pushed a commit to openeuler-mirror/openssl that referenced this pull request Oct 9, 2023
ossl_property_list_to_string() didn't quote strings correctly which
could result in a generated property string being unparsable.

Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from openssl/openssl#22182)

(cherry picked from commit fb20e66)
Signed-off-by: fly2x <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Applies to master branch branch: 3.0 Applies to openssl-3.0 branch branch: 3.1 Applies to openssl-3.1 (EOL) severity: fips change The pull request changes FIPS provider sources tests: present The PR has suitable tests present triaged: bug The issue/pr is/fixes a bug

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants