Skip to content

Comments

[design] Make it possible to use explicitly fetched signature implementation#22129

Closed
levitte wants to merge 9 commits intoopenssl:masterfrom
levitte:project-171-composite-algorithms
Closed

[design] Make it possible to use explicitly fetched signature implementation#22129
levitte wants to merge 9 commits intoopenssl:masterfrom
levitte:project-171-composite-algorithms

Conversation

@levitte
Copy link
Member

@levitte levitte commented Sep 18, 2023

This design is to allow the use of explicitly fetched EVP_SIGNATURE
implementations.

Ref: openssl/project#171

@levitte
[design] Make it possible to use explicitly fetched signature impleme…
6b96df4 
…ntation

This design is to allow the use of explicitly fetched EVP_SIGNATURE
implementations.

Ref: openssl/project#171
@levitte levitte added this to the Post 3.2.0 milestone Sep 18, 2023
mattcaswell
mattcaswell reviewed Sep 18, 2023
View reviewed changes
@levitte
Copy link
Member Author

levitte commented Sep 19, 2023

I just stumbled back on EVP_KEYEXCH and was reminded that we have the same implicit fetch construct there as we have with EVP_SIGNATURE... is this something I should address in this design as well?

@levitte
Copy link
Member Author

levitte commented Sep 19, 2023

Side note: I really hate our mixed header style rule for markdown (we use :setext_with_atx, see the mdlint header rules. It's jarring, at least to my eyes.

@mattcaswell
Copy link
Member

mattcaswell commented Sep 19, 2023

I just stumbled back on EVP_KEYEXCH and was reminded that we have the same implicit fetch construct there as we have with EVP_SIGNATURE... is this something I should address in this design as well?

It would be nice to have it all dealt with in the same way. Don't we have the same issue for asymcipher too?

@paulidale
Copy link
Contributor

paulidale commented Sep 19, 2023

#22140 might be relevant here too.

@levitte
Copy link
Member Author

levitte commented Sep 19, 2023

#22140 might be relevant here too.

Yes and no. This PR is a bit myopic in the sense that it's an answer to the information you get through the AlgorithmIndentifier.algorithm OID. I'd rather keep it to that scope, and deal with alternative complications elsewhere.

@levitte
Copy link
Member Author

levitte commented Sep 21, 2023

I think I've filled in all the missing pieces at this point, as indicated by @mattcaswell's comments. If something is still missing, I'd like to hear about it.

mattcaswell
mattcaswell requested changes Sep 21, 2023
View reviewed changes
paulidale
paulidale reviewed Sep 22, 2023
View reviewed changes
@levitte
Copy link
Member Author

levitte commented Sep 22, 2023 •
edited
Loading

There's one thing I hadn't thought of yet, but that might be suitable in some cases: having a public API for querying the key type to be used with an algorithm.

This would be useful, I imagine, for any application that holds a number of different keys, one per key type, and for which it would make sense to find the proper key to use with an algorithm, without having to try to init the operation with each key until one goes through fine.
libssl code would be seen as such an application, no?

Should I add something about that?

@arapov arapov mentioned this pull request Sep 26, 2023
Closed
This was referenced Sep 28, 2023
Closed
Open
Open
Closed
@levitte levitte added approval: otc review pending approval: review pending This pull request needs review by a committer triaged: design The issue/pr deals with a design document and removed approval: otc review pending labels Sep 30, 2023
@levitte levitte added the tests: exempted The PR is exempt from requirements for testing label Sep 30, 2023
paulidale
paulidale approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@paulidale paulidale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a need for the OTC to review this.

@levitte levitte added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Oct 4, 2023
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Oct 5, 2023
@openssl-machine
Copy link
Collaborator

openssl-machine commented Oct 5, 2023

This pull request is ready to merge

@levitte
Copy link
Member Author

levitte commented Oct 5, 2023

Merged

@levitte levitte closed this Oct 5, 2023
@levitte levitte deleted the project-171-composite-algorithms branch October 5, 2023 07:13
openssl-machine pushed a commit that referenced this pull request Oct 5, 2023
@levitte
[design] Make it possible to use explicitly fetched signature impleme…
e8e2b13 
…ntation

This design is to allow the use of explicitly fetched EVP_SIGNATURE
implementations.

Ref: openssl/project#171

Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from #22129)
wanghao75 pushed a commit to openeuler-mirror/openssl that referenced this pull request Oct 9, 2023
@levitte
[design] Make it possible to use explicitly fetched signature impleme…
2cc6d7b 
…ntation

This design is to allow the use of explicitly fetched EVP_SIGNATURE
implementations.

Ref: openssl/project#171

Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from openssl/openssl#22129)

Signed-off-by: fly2x <[email protected]>
@levitte levitte mentioned this pull request Nov 9, 2023
Closed
@nhorman nhorman mentioned this pull request Jul 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattcaswell mattcaswell mattcaswell approved these changes

@paulidale paulidale paulidale approved these changes

Assignees

No one assigned

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge tests: exempted The PR is exempt from requirements for testing triaged: design The issue/pr deals with a design document

Projects

None yet

Milestone

Post 3.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@levitte @mattcaswell @paulidale @openssl-machine