Conversation
Some tests were broken for no-ec in master
Previously we were omitting the extension information from ext_defs if the association no- option was defined. This doesn't work because the indexes into the table are no longer valid.
levitte
requested changes
Dec 28, 2016
| #We assume the EC extensions are sent | ||
| plan skip_all => "$test_name needs EC enabled" | ||
| if disabled("ec"); | ||
|
|
Member
There was a problem hiding this comment.
Isn't 70-test_sslmessages a general test of tls messages? In that case, I think this is a bad idea. There are other options where this particular test fails, shall we skip this test for them as well? That would be counter productive...
Member
Author
|
I moved the commits from this PR in #2153. Therefore I am closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
This fixes compilation with no-ec on the master branch.