Add section numbers that were missing in CMS_add0_cert.pod#20398
Closed
paulidale wants to merge 1 commit intoopenssl:openssl-3.1from
Closed
Add section numbers that were missing in CMS_add0_cert.pod#20398paulidale wants to merge 1 commit intoopenssl:openssl-3.1from
CMS_add0_cert.pod#20398paulidale wants to merge 1 commit intoopenssl:openssl-3.1from
Conversation
paulidale
added
approval: review pending
Member
|
@paulidale this was just not properly cherry picked to 3.1 and 3.0 in #20369 |
Contributor
Author
|
The doc-nits change would be considered a feature rather than a bug fix IMO. We shouldn't merge that. |
mattcaswell
approved these changes
Feb 28, 2023
DDvO
approved these changes
Feb 28, 2023
DDvO
added
approval: done
DDvO
changed the title
CMS_add0_cert.pod
Contributor
Author
|
Merged, thanks for the reviews. |
openssl-machine
pushed a commit
that referenced
this pull request
Mar 1, 2023
Reviewed-by: David von Oheimb <[email protected]> Reviewed-by: Matt Caswell <[email protected]> (Merged from #20398) (cherry picked from commit 2bb9e44)
openssl-machine
pushed a commit
that referenced
this pull request
Mar 1, 2023
Reviewed-by: David von Oheimb <[email protected]> Reviewed-by: Matt Caswell <[email protected]> (Merged from #20398)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some section numbers were missing which annoyed doc-nits.
This addresses this by putting them in.