Skip to content

Prevent double free for CMS_add1_cert() and fix doc - backport to 3.0 and 3.1#20275

Closed
DDvO wants to merge 2 commits intoopenssl:openssl-3.0from
siemens:fix_CMS_add1_crl_30_31
Closed

Prevent double free for CMS_add1_cert() and fix doc - backport to 3.0 and 3.1#20275
DDvO wants to merge 2 commits intoopenssl:openssl-3.0from
siemens:fix_CMS_add1_crl_30_31

Conversation

@DDvO
Copy link
Contributor

@DDvO DDvO commented Feb 13, 2023

Backport the parts of #19199 containing fixes for CMS_add1_cert().

@DDvO DDvO added approval: review pending This pull request needs review by a committer approval: otc review pending triaged: bug The issue/pr is/fixes a bug triaged: documentation The issue/pr deals with documentation (errors) branch: 3.0 Applies to openssl-3.0 branch branch: 3.1 Applies to openssl-3.1 (EOL) labels Feb 13, 2023
@DDvO DDvO added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Feb 23, 2023
@DDvO
Copy link
Contributor Author

DDvO commented Feb 23, 2023

Thank you for the approvals.

Interesting that this backport has been approved before the original PR: #19199.

@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

@DDvO DDvO added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Feb 24, 2023
openssl-machine pushed a commit that referenced this pull request Feb 24, 2023
Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Hugo Landau <[email protected]>
Reviewed-by: David von Oheimb <[email protected]>
(Merged from #20275)
openssl-machine pushed a commit that referenced this pull request Feb 24, 2023
… improvements

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Hugo Landau <[email protected]>
Reviewed-by: David von Oheimb <[email protected]>
(Merged from #20275)
openssl-machine pushed a commit that referenced this pull request Feb 24, 2023
Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Hugo Landau <[email protected]>
Reviewed-by: David von Oheimb <[email protected]>
(Merged from #20275)

(cherry picked from commit 416e155)
openssl-machine pushed a commit that referenced this pull request Feb 24, 2023
… improvements

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Hugo Landau <[email protected]>
Reviewed-by: David von Oheimb <[email protected]>
(Merged from #20275)

(cherry picked from commit 9fae775)
@DDvO
Copy link
Contributor Author

DDvO commented Feb 24, 2023

Merged to 3.0 and cherry-picked to 3.1 - thanks @paulidale and @hlandau for the approvals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge branch: 3.0 Applies to openssl-3.0 branch branch: 3.1 Applies to openssl-3.1 (EOL) triaged: bug The issue/pr is/fixes a bug triaged: documentation The issue/pr deals with documentation (errors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants