Use $config{build_file} instead of $target{build_file} [1.1.1]#20174
Closed
levitte wants to merge 1 commit intoopenssl:OpenSSL_1_1_1-stablefrom
Closed
Use $config{build_file} instead of $target{build_file} [1.1.1]#20174levitte wants to merge 1 commit intoopenssl:OpenSSL_1_1_1-stablefrom
levitte wants to merge 1 commit intoopenssl:OpenSSL_1_1_1-stablefrom
Conversation
levitte
added
approval: review pending
levitte
changed the title
t8m
added
triaged: bug
Member
|
I wouldn' t bother fixing this on 1.1.1. On the other hand the PR is here already. |
hlandau
approved these changes
Feb 2, 2023
mspncp
approved these changes
Feb 2, 2023
mspncp
added
approval: done
If the user specifies an alternative build file than the default, this
alternative is recorded in $config{build_file}, not $target{build_file}.
Therefore, the former should be used, leaving the latter as a mere default.
This is a bug.
levitte
force-pushed
the
fix-buildfile-settings-111
branch
from
4b6556a to
6f4a03e
Compare
Member
Author
|
Merged 1dc2ae4 Use $config{build_file} instead of $target{build_file} |
openssl-machine
pushed a commit
that referenced
this pull request
Feb 3, 2023
If the user specifies an alternative build file than the default, this
alternative is recorded in $config{build_file}, not $target{build_file}.
Therefore, the former should be used, leaving the latter as a mere default.
This is a bug.
Reviewed-by: Hugo Landau <[email protected]>
Reviewed-by: Matthias St. Pierre <[email protected]>
(Merged from #20174)
a-kromm-rogii
pushed a commit
to a-kromm-rogii/openssl
that referenced
this pull request
Mar 14, 2025
If the user specifies an alternative build file than the default, this
alternative is recorded in $config{build_file}, not $target{build_file}.
Therefore, the former should be used, leaving the latter as a mere default.
This is a bug.
Reviewed-by: Hugo Landau <[email protected]>
Reviewed-by: Matthias St. Pierre <[email protected]>
(Merged from openssl#20174)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the user specifies an alternative build file than the default, this alternative is recorded in $config{build_file}, not $target{build_file}. Therefore, the former should be used, leaving the latter as a mere default.
This is a bug.
This is #20173 backported to 1.1.1