Ensure our buffer allocation allows for the Explicit IV#20085
Closed
mattcaswell wants to merge 6 commits intoopenssl:masterfrom
Closed
Ensure our buffer allocation allows for the Explicit IV#20085mattcaswell wants to merge 6 commits intoopenssl:masterfrom
mattcaswell wants to merge 6 commits intoopenssl:masterfrom
Conversation
Test that sending large app data records works correctly.
Some ciphers/protocol versions have an explicit IV. We need to make sure we have sufficient room for it in the underlying buffer.
mattcaswell
added
branch: master
This was referenced Jan 19, 2023
2 tasks
t8m
added
triaged: bug
Member
|
CI is relevant |
Member
|
minimal CI fails still |
Member
Author
|
Fixup pushed hopefully addressing the minimal CI failure. I also added a commit to extend the test to include DTLS. |
mattcaswell
force-pushed
the
large-app-data
branch
from
569c714 to
1e5f366
Compare
t8m
approved these changes
Jan 20, 2023
paulidale
approved these changes
Jan 22, 2023
paulidale
added
approval: done
openssl-machine
added
approval: ready to merge
Collaborator
|
This pull request is ready to merge |
Contributor
|
Merged. |
openssl-machine
pushed a commit
that referenced
this pull request
Jan 24, 2023
Test that sending large app data records works correctly. Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from #20085)
openssl-machine
pushed a commit
that referenced
this pull request
Jan 24, 2023
Some ciphers/protocol versions have an explicit IV. We need to make sure we have sufficient room for it in the underlying buffer. Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from #20085)
openssl-machine
pushed a commit
that referenced
this pull request
Jan 24, 2023
Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from #20085)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some ciphers/protocol versions have an explicit IV. We need to make sure we
have sufficient room for it in the underlying buffer.
This fixes a regression introduced during the record layer refactor.