Skip to content

Comments

Fix ci failures in 111#19930

Closed
bernd-edlinger wants to merge 2 commits intoopenssl:OpenSSL_1_1_1-stablefrom
bernd-edlinger:fix_ci_failures_in_111
Closed

Fix ci failures in 111#19930
bernd-edlinger wants to merge 2 commits intoopenssl:OpenSSL_1_1_1-stablefrom
bernd-edlinger:fix_ci_failures_in_111

Conversation

@bernd-edlinger
Copy link
Member

Checklist
  • documentation is added or updated
  • tests are added or updated

@bernd-edlinger bernd-edlinger added the branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL) label Dec 16, 2022
tests: none
}
]
runs-on: ubuntu-latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this only a problem on 1.1.1? (What is the reason for the change).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the used gcc-11 version creates false-positive warnings in m68k-linux-gnu which make the build fail,
the warning is due to a large refactoring in the gcc-internal variable range computation engine ("ranger")
https://gcc.gnu.org/wiki/AndrewMacLeod/Ranger
that was rolled out in gcc-11 and gcc is still recovering from this major change.
So instead of disabling a potentially useful warning, I wanted to keep the test using ubuntu-20.04, and if that
version is no longer available, skip directly to ubuntu-24.04, which will be using gcc-13, and that warning
is already gone in gcc-trunk of today, I double-checked that.

@t8m t8m added triaged: bug The issue/pr is/fixes a bug approval: review pending This pull request needs review by a committer approval: otc review pending hold: discussion The community needs to establish a consensus how to move forward with the issue or PR labels Dec 20, 2022
@t8m
Copy link
Member

t8m commented Dec 20, 2022

OTC: Are these strict warning fixes something we want on 1.1.1 branch?

@t8m t8m added tests: exempted The PR is exempt from requirements for testing and removed approval: otc review pending hold: discussion The community needs to establish a consensus how to move forward with the issue or PR labels Jan 9, 2023
@t8m
Copy link
Member

t8m commented Jan 10, 2023

Removing the OTC hold as we removed it from a similar (warning fix) issue on today's OTC meeting.

@mattcaswell mattcaswell added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Jan 19, 2023
@t8m
Copy link
Member

t8m commented Jan 19, 2023

I would be OK with treating this as urgent as this is a CI fix.

@mattcaswell
Copy link
Member

I would be OK with treating this as urgent as this is a CI fix.

Agreed

@mattcaswell mattcaswell added the severity: urgent Fixes an urgent issue (exempt from 24h grace period) label Jan 19, 2023
@mattcaswell
Copy link
Member

I will merge shortly

@mattcaswell
Copy link
Member

Pushed. Thanks.

openssl-machine pushed a commit that referenced this pull request Jan 19, 2023
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from #19930)
openssl-machine pushed a commit that referenced this pull request Jan 19, 2023
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from #19930)
a-kromm-rogii pushed a commit to a-kromm-rogii/openssl that referenced this pull request Mar 14, 2025
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from openssl#19930)
a-kromm-rogii pushed a commit to a-kromm-rogii/openssl that referenced this pull request Mar 14, 2025
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from openssl#19930)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval: done This pull request has the required number of approvals branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL) severity: urgent Fixes an urgent issue (exempt from 24h grace period) tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants