crypto/bio: fix build on UEFI#19738
Closed
liyi77 wants to merge 1 commit intoopenssl:OpenSSL_1_1_1-stablefrom
Closed
crypto/bio: fix build on UEFI#19738liyi77 wants to merge 1 commit intoopenssl:OpenSSL_1_1_1-stablefrom
liyi77 wants to merge 1 commit intoopenssl:OpenSSL_1_1_1-stablefrom
Conversation
Using floating point is not supported in UEFI and can cause build problems, for example due to SSE being disabled and x64 calling convention passing floats in SSE registers. Avoid those problems by not compiling the formating code for floating point numbers. Signed-off-by: Gerd Hoffmann <[email protected]>
liyi77
force-pushed
the
fix_b_print_uefi_erro
branch
from
33936ba to
85dc3a6
Compare
Member
|
Maybe I am missing something here, but this doesn't look like a cherry pick to me. |
Contributor
Author
Oh sorry for the misunderstanding.
|
Member
|
Why is there a #else that is not in the original PR? |
Contributor
Author
PR link reference is wrong, update to #17547. |
Member
|
Unfortunately this is out of scope for 1.1.1 as that branch is for security fixes only now. |
t8m
added
branch: 1.1.1
Member
|
@openssl/otc should we accept this into 1.1.1? |
t8m
added
the
hold: discussion
Contributor
Author
|
This problem will cause EDK2 to fail to enable X509 certificate time check, really hope it can be merged into 1.1.1...... |
Member
|
OTC: Removing the hold. It's up to the discretion of reviewers. |
mattcaswell
removed
the
hold: discussion
hlandau
approved these changes
Nov 29, 2022
hlandau
added
the
approval: review pending
Collaborator
|
This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago |
Collaborator
|
This PR is in a state where it requires action by @openssl/committers but the last update was 61 days ago |
t8m
approved these changes
Jan 30, 2023
t8m
added
approval: done
openssl-machine
added
approval: ready to merge
Collaborator
|
This pull request is ready to merge |
Member
|
Merged to 1.1.1 branch. Thank you. |
openssl-machine
pushed a commit
that referenced
this pull request
Jan 31, 2023
Using floating point is not supported in UEFI and can cause build problems, for example due to SSE being disabled and x64 calling convention passing floats in SSE registers. Avoid those problems by not compiling the formating code for floating point numbers. Signed-off-by: Gerd Hoffmann <[email protected]> Reviewed-by: Hugo Landau <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from #19738)
a-kromm-rogii
pushed a commit
to a-kromm-rogii/openssl
that referenced
this pull request
Mar 14, 2025
Using floating point is not supported in UEFI and can cause build problems, for example due to SSE being disabled and x64 calling convention passing floats in SSE registers. Avoid those problems by not compiling the formating code for floating point numbers. Signed-off-by: Gerd Hoffmann <[email protected]> Reviewed-by: Hugo Landau <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from openssl#19738)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick from: #17547
When compiling openssl for tianocore compiling abs_val() and pow_10()
fails with the following error because SSE support is disabled:
crypto/bio/bio_print.c:587:46: error: SSE register return with SSE disabled
Fix that by using EFIAPI calling convention when compiling for UEFI.
EDK2 not support openssl-3.0, need fix it in openssl-1.1.1 also.