Check the encryption growth in tls1_enc#19710
Closed
bernd-edlinger wants to merge 4 commits intoopenssl:OpenSSL_1_1_1-stablefrom
Closed
Check the encryption growth in tls1_enc#19710bernd-edlinger wants to merge 4 commits intoopenssl:OpenSSL_1_1_1-stablefrom
bernd-edlinger wants to merge 4 commits intoopenssl:OpenSSL_1_1_1-stablefrom
Conversation
bernd-edlinger
added
the
branch: 1.1.1
2 tasks
mattcaswell
reviewed
Nov 18, 2022
Member
|
This is IMO outside of scope for 1.1.1. |
This reverts commit 31efcf2.
This adds a new parameter to the enc functions, that is optional, and if given can be used to prevent buffer overflows due to excessive padding before they happen. A minimum space reservation of 16 bytes is assumed to be available without checking. Additionally this fixes a bug, that prevented DTLS to use aes_cbc_hmac_sha1 and aes_cbc_hmac_sha256.
Test that sending large app data records works correctly.
bernd-edlinger
force-pushed
the
check_the_encryption_growth_in_tls1_enc
branch
from
83d2651 to
d90a225
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new parameter to the enc functions,
that is optional, and if given can be used to prevent buffer overflows due to excessive padding before they happen. A minimum space reservation of 16 bytes is assumed to be available without checking.
Additionally this fixes a bug, that prevented DTLS to use aes_cbc_hmac_sha1 and aes_cbc_hmac_sha256.