Skip to content

rand: remove the ossl_rand_pool_add_additional_data() function.#19493

Closed
paulidale wants to merge 2 commits intoopenssl:masterfrom
paulidale:deseed
Closed

rand: remove the ossl_rand_pool_add_additional_data() function.#19493
paulidale wants to merge 2 commits intoopenssl:masterfrom
paulidale:deseed

Conversation

@paulidale
Copy link
Contributor

This function isn't called from anywhere and cannot easily be used by the current RNG infrastructure.

This function isn't called from anywhere and cannot easily be used
by the current RNG infrastructure.
@paulidale paulidale added branch: master Applies to master branch approval: review pending This pull request needs review by a committer approval: otc review pending labels Oct 25, 2022
@paulidale paulidale self-assigned this Oct 25, 2022
@github-actions github-actions bot added the severity: fips change The pull request changes FIPS provider sources label Oct 25, 2022
@t8m t8m added triaged: refactor The issue/pr requests/implements refactoring branch: 3.1 Applies to openssl-3.1 (EOL) labels Oct 25, 2022
Copy link
Member

@t8m t8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for 3.1 as well.

@mspncp mspncp added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Oct 25, 2022
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Oct 26, 2022
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@paulidale
Copy link
Contributor Author

Merged, thanks.

@paulidale paulidale closed this Oct 26, 2022
@paulidale paulidale deleted the deseed branch October 26, 2022 22:23
openssl-machine pushed a commit that referenced this pull request Oct 26, 2022
This function isn't called from anywhere and cannot easily be used
by the current RNG infrastructure.

Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Matthias St. Pierre <[email protected]>
(Merged from #19493)
openssl-machine pushed a commit that referenced this pull request Oct 26, 2022
This function isn't called from anywhere and cannot easily be used
by the current RNG infrastructure.

Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Matthias St. Pierre <[email protected]>
(Merged from #19493)

(cherry picked from commit da7db83)
beldmit pushed a commit to beldmit/openssl that referenced this pull request Dec 26, 2022
This function isn't called from anywhere and cannot easily be used
by the current RNG infrastructure.

Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Matthias St. Pierre <[email protected]>
(Merged from openssl#19493)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Applies to master branch branch: 3.1 Applies to openssl-3.1 (EOL) severity: fips change The pull request changes FIPS provider sources triaged: refactor The issue/pr requests/implements refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants