Skip to content

Comments

doc: fix copy/paste error#19461

Closed
paulidale wants to merge 1 commit intoopenssl:masterfrom
paulidale:add-all-digest-fix
Closed

doc: fix copy/paste error#19461
paulidale wants to merge 1 commit intoopenssl:masterfrom
paulidale:add-all-digest-fix

Conversation

@paulidale
Copy link
Contributor

This isn't a security fix but should be safe in 1.1.1. If a reviewer disagrees, please remove the label. I'm fine either way.

Fixes #19460

  • documentation is added or updated
  • tests are added or updated

@paulidale paulidale added branch: master Applies to master branch approval: review pending This pull request needs review by a committer branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL) approval: otc review pending triaged: documentation The issue/pr deals with documentation (errors) branch: 3.0 Applies to openssl-3.0 branch labels Oct 20, 2022
@paulidale paulidale self-assigned this Oct 20, 2022
@t-j-h
Copy link
Member

t-j-h commented Oct 20, 2022

It is a pure documentation fix so it won't break any actual usage by any application.

@slontis slontis added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Oct 21, 2022
@slontis
Copy link
Member

slontis commented Oct 21, 2022

@openssl/otc - Is someone responsible for these buildbot runners that have been broken for a while (They seem to be timing out in the same place?)

@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

@paulidale
Copy link
Contributor Author

Merged to all three branches. Thanks.

@paulidale paulidale closed this Oct 23, 2022
openssl-machine pushed a commit that referenced this pull request Oct 23, 2022
Fixes #19460

Reviewed-by: Tim Hudson <[email protected]>
Reviewed-by: Shane Lontis <[email protected]>
(Merged from #19461)

(cherry picked from commit 5b9480f)
openssl-machine pushed a commit that referenced this pull request Oct 23, 2022
Fixes #19460

Reviewed-by: Tim Hudson <[email protected]>
Reviewed-by: Shane Lontis <[email protected]>
(Merged from #19461)
openssl-machine pushed a commit that referenced this pull request Oct 23, 2022
Fixes #19460

Reviewed-by: Tim Hudson <[email protected]>
Reviewed-by: Shane Lontis <[email protected]>
(Merged from #19461)

(cherry picked from commit 5b9480f)
@paulidale paulidale deleted the add-all-digest-fix branch October 24, 2022 10:13
beldmit pushed a commit to beldmit/openssl that referenced this pull request Dec 26, 2022
Fixes openssl#19460

Reviewed-by: Tim Hudson <[email protected]>
Reviewed-by: Shane Lontis <[email protected]>
(Merged from openssl#19461)
a-kromm-rogii pushed a commit to a-kromm-rogii/openssl that referenced this pull request Mar 14, 2025
Fixes openssl#19460

Reviewed-by: Tim Hudson <[email protected]>
Reviewed-by: Shane Lontis <[email protected]>
(Merged from openssl#19461)

(cherry picked from commit 5b9480f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval: done This pull request has the required number of approvals branch: master Applies to master branch branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL) branch: 3.0 Applies to openssl-3.0 branch triaged: documentation The issue/pr deals with documentation (errors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Copy/paste error in OPENSSL_INIT_ADD_ALL_DIGESTS description?

4 participants