Fix coverity issues with certificate compression#19440
Closed
tmshort wants to merge 3 commits into
Closed
Conversation
Unless multiple compression algorithms are configured, test 3 is not run, so anything looking at `test == 3` is considered dead code.
tmshort
added
branch: master
2 tasks
Contributor
Author
|
I don't know how to confirm if this fixes the coverity issues? |
t8m
approved these changes
Oct 19, 2022
t8m
added
triaged: bug
Member
We'll see if they disappear after merging. |
paulidale
approved these changes
Oct 19, 2022
paulidale
added
approval: done
Collaborator
|
24 hours has passed since 'approval: done' was set, but this PR has failing CI tests. Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually. |
Contributor
|
Merged with end of line white space removal. Thanks. |
openssl-machine
pushed a commit
that referenced
this pull request
Oct 20, 2022
Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from #19440)
openssl-machine
pushed a commit
that referenced
this pull request
Oct 20, 2022
Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from #19440)
openssl-machine
pushed a commit
that referenced
this pull request
Oct 20, 2022
Unless multiple compression algorithms are configured, test 3 is not run, so anything looking at `test == 3` is considered dead code. Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from #19440)
Contributor
Author
|
Where does one see the Coverity results? I looked under actions, but no details are provided. |
Member
|
Member
|
The 1516093 is still unfixed by this PR. IMO there should be some maximum possible length check on |
Contributor
Author
That might be the case. Coverity isn't always clear as to how to fix things. |
beldmit
pushed a commit
to beldmit/openssl
that referenced
this pull request
Dec 26, 2022
Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from openssl#19440)
beldmit
pushed a commit
to beldmit/openssl
that referenced
this pull request
Dec 26, 2022
Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from openssl#19440)
beldmit
pushed a commit
to beldmit/openssl
that referenced
this pull request
Dec 26, 2022
Unless multiple compression algorithms are configured, test 3 is not run, so anything looking at `test == 3` is considered dead code. Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from openssl#19440)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist