Skip to content

Comments

Fix no longer implicitly refresh the cached TBSCertificate for 1.1.1#19392

Closed
gibeom-gwon wants to merge 1 commit intoopenssl:OpenSSL_1_1_1-stablefrom
gibeom-gwon:fix-reg-1_1_1
Closed

Fix no longer implicitly refresh the cached TBSCertificate for 1.1.1#19392
gibeom-gwon wants to merge 1 commit intoopenssl:OpenSSL_1_1_1-stablefrom
gibeom-gwon:fix-reg-1_1_1

Conversation

@gibeom-gwon
Copy link
Contributor

This reverts commit 748df18.
Fixes #19388

Checklist
  • documentation is added or updated
  • tests are added or updated

@t8m t8m added branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL) triaged: bug The issue/pr is/fixes a bug severity: regression The issue/pr is a regression from previous released version approval: review pending This pull request needs review by a committer approval: otc review pending labels Oct 12, 2022
Copy link
Member

@t8m t8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given this fixes a recent regression, I think it should go into 1.1.1 even if it is in security-fix only mode.

@bernd-edlinger bernd-edlinger added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Oct 17, 2022
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Oct 18, 2022
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@t8m
Copy link
Member

t8m commented Oct 18, 2022

Merged to 1.1.1 branch. Thank you.

@t8m t8m closed this Oct 18, 2022
openssl-machine pushed a commit that referenced this pull request Oct 18, 2022
This reverts commit 748df18.
Fixes #19388

Reviewed-by: Bernd Edlinger <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from #19392)
@gibeom-gwon gibeom-gwon deleted the fix-reg-1_1_1 branch October 27, 2022 02:53
a-kromm-rogii pushed a commit to a-kromm-rogii/openssl that referenced this pull request Mar 14, 2025
This reverts commit 748df18.
Fixes openssl#19388

Reviewed-by: Bernd Edlinger <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from openssl#19392)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL) severity: regression The issue/pr is a regression from previous released version triaged: bug The issue/pr is/fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants