Skip to content

Comments

Fix inconsistent doc of CMS_verify and PKCS7_verify etc. - backporting #18915#19108

Closed
DDvO wants to merge 1 commit intoopenssl:masterfrom
siemens:fix_inconsistent_doc_SMIME_CMS_PKCS_verify_v30_111
Closed

Fix inconsistent doc of CMS_verify and PKCS7_verify etc. - backporting #18915#19108
DDvO wants to merge 1 commit intoopenssl:masterfrom
siemens:fix_inconsistent_doc_SMIME_CMS_PKCS_verify_v30_111

Conversation

@DDvO
Copy link
Contributor

@DDvO DDvO commented Sep 1, 2022

This is a copy of the doc changes in #18915 for backporting to 3.0 and 1.1.1, as discussed there.

Also change B< to I< in {CMS,PKCS7}_verify.pod, PKCS7_sign{,_add_signer}.pod
@DDvO DDvO added approval: review pending This pull request needs review by a committer branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL) approval: otc review pending triaged: documentation The issue/pr deals with documentation (errors) branch: 3.0 Applies to openssl-3.0 branch labels Sep 1, 2022
@DDvO
Copy link
Contributor Author

DDvO commented Sep 1, 2022

@t8m since you wrote that missingcrypto111.txt should not be touched even when doc of 1.1.1. is extended (as done here), I wonder what this file is good for?

@t8m
Copy link
Member

t8m commented Sep 1, 2022

@t8m since you wrote that missingcrypto111.txt should not be touched even when doc of 1.1.1. is extended (as done here), I wonder what this file is good for?

It's there basically to compare what documentation we added after 1.1.1. Not sure if the file should be kept forever in the tree.

@DDvO
Copy link
Contributor Author

DDvO commented Sep 1, 2022

@paulidale can you please give the 2nd approval here (for 3.0 and 1.1.1), too.

@DDvO DDvO requested a review from paulidale September 2, 2022 19:30
@DDvO
Copy link
Contributor Author

DDvO commented Sep 6, 2022

Ping for 2nd review

@DDvO
Copy link
Contributor Author

DDvO commented Sep 6, 2022

Being a copy of #18915, it's a very low-hanging fruit 😉

@DDvO
Copy link
Contributor Author

DDvO commented Sep 13, 2022

@paulidale, can you give the 2nd approval on this backport?
Should be a no-brainer as you already approved the original PR.

@openssl-machine
Copy link
Collaborator

This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago

@paulidale paulidale added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Oct 14, 2022
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Oct 15, 2022
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Oct 19, 2022
Also change B< to I< in {CMS,PKCS7}_verify.pod, PKCS7_sign{,_add_signer}.pod

Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: David von Oheimb <[email protected]>
(Merged from #19108)
DDvO added a commit to siemens/openssl that referenced this pull request Oct 19, 2022
Also change B< to I< in {CMS,PKCS7}_verify.pod, PKCS7_sign{,_add_signer}.pod

Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: David von Oheimb <[email protected]>
(Merged from openssl#19108)

(cherry picked from commit 312a6b3)
@DDvO
Copy link
Contributor Author

DDvO commented Oct 19, 2022

Merged to 3.0 and 1.1.1, fixing merge conflicts in the .pod files.
Thanks @t8m and @paulidale for the reviews.

@DDvO DDvO closed this Oct 19, 2022
openssl-machine pushed a commit that referenced this pull request Oct 19, 2022
Also change B< to I< in {CMS,PKCS7}_verify.pod, PKCS7_sign{,_add_signer}.pod

Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: David von Oheimb <[email protected]>
(Merged from #19108)

(cherry picked from commit 312a6b3)
a-kromm-rogii pushed a commit to a-kromm-rogii/openssl that referenced this pull request Mar 14, 2025
Also change B< to I< in {CMS,PKCS7}_verify.pod, PKCS7_sign{,_add_signer}.pod

Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: David von Oheimb <[email protected]>
(Merged from openssl#19108)

(cherry picked from commit 312a6b3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL) branch: 3.0 Applies to openssl-3.0 branch triaged: documentation The issue/pr deals with documentation (errors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants