Skip to content

Comments

Use longer time in TLS cookie 1.1.1#19022

Closed
paulidale wants to merge 2 commits intoopenssl:OpenSSL_1_1_1-stablefrom
paulidale:cookie-time-111
Closed

Use longer time in TLS cookie 1.1.1#19022
paulidale wants to merge 2 commits intoopenssl:OpenSSL_1_1_1-stablefrom
paulidale:cookie-time-111

Conversation

@paulidale
Copy link
Contributor

#19004 back ported to 1.1.1

Fixes a bug in the cookie code which would have caused problems for ten
minutes before and after the lower 32 bits of time_t rolled over.
@paulidale paulidale added approval: review pending This pull request needs review by a committer branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL) approval: otc review pending triaged: bug The issue/pr is/fixes a bug labels Aug 18, 2022
@paulidale paulidale requested review from kaduk and mattcaswell August 18, 2022 23:03
@paulidale paulidale self-assigned this Aug 18, 2022
@kaduk kaduk added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Aug 20, 2022
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Aug 21, 2022
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@paulidale
Copy link
Contributor Author

Merged, thanks for the reviews.

@paulidale paulidale closed this Aug 22, 2022
@paulidale paulidale deleted the cookie-time-111 branch August 22, 2022 04:46
openssl-machine pushed a commit that referenced this pull request Aug 22, 2022
Fixes a bug in the cookie code which would have caused problems for ten
minutes before and after the lower 32 bits of time_t rolled over.

Reviewed-by: Ben Kaduk <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from #19022)
a-kromm-rogii pushed a commit to a-kromm-rogii/openssl that referenced this pull request Mar 14, 2025
Fixes a bug in the cookie code which would have caused problems for ten
minutes before and after the lower 32 bits of time_t rolled over.

Reviewed-by: Ben Kaduk <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from openssl#19022)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge branch: 1.1.1 Applies to OpenSSL_1_1_1-stable branch (EOL) triaged: bug The issue/pr is/fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants