Moving notify check after the no time check#19007
Closed
doorsdown wants to merge 1 commit intoopenssl:masterfrom
Closed
Moving notify check after the no time check#19007doorsdown wants to merge 1 commit intoopenssl:masterfrom
doorsdown wants to merge 1 commit intoopenssl:masterfrom
Conversation
openssl-machine
added
the
hold: cla required
Member
|
NEVER MIND my comment on the commit message, it appears |
Member
|
I looked more closely at the commit message, and it does need to be adjusted slightly, by separating It needs to be this: A |
t8m
approved these changes
Aug 16, 2022
Member
t8m
left a comment
t8m
left a comment
There was a problem hiding this comment.
The commit message can be adjusted when merging.
Member
|
I am OK with CLA: trivial for this. |
t8m
added
branch: master
CLA: trivial
Contributor
Author
|
I updated commit message as requested |
paulidale
approved these changes
Aug 22, 2022
paulidale
added
approval: done
Member
|
@paulidale are you OK with CLA: trivial? |
Contributor
|
Yes, okay with trivial. |
Collaborator
|
24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually. |
openssl-machine
pushed a commit
that referenced
this pull request
Aug 23, 2022
CLA: trivial Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from #19007)
openssl-machine
pushed a commit
that referenced
this pull request
Aug 23, 2022
CLA: trivial Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from #19007) (cherry picked from commit c92c3df)
Contributor
|
Merged to all three branches. Thanks for the fix. |
openssl-machine
pushed a commit
that referenced
this pull request
Aug 23, 2022
CLA: trivial Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from #19007) (cherry picked from commit c92c3df)
bernd-edlinger
pushed a commit
to bernd-edlinger/openssl
that referenced
this pull request
Sep 9, 2022
CLA: trivial Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from openssl#19007) (cherry picked from commit c92c3df)
sftcd
pushed a commit
to sftcd/openssl
that referenced
this pull request
Sep 24, 2022
CLA: trivial Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from openssl#19007)
beldmit
pushed a commit
to beldmit/openssl
that referenced
this pull request
Dec 26, 2022
CLA: trivial Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from openssl#19007)
a-kromm-rogii
pushed a commit
to a-kromm-rogii/openssl
that referenced
this pull request
Mar 14, 2025
CLA: trivial Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from openssl#19007) (cherry picked from commit c92c3df)
kafei-cy
added a commit
to kafei-cy/Tongsuo
that referenced
this pull request
Jan 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #18992
The patch moves the notify check to after the no time check
CLA: trivial