Closed
Conversation
The test loops through all the ciphers, attempting to test each one in turn. However version negotiation happens before cipher selection, so with TLSv1.3 switched on if we use a non-TLSv1.3 compatible cipher suite we get "no share cipher".
richsalz
approved these changes
Nov 10, 2016
Contributor
richsalz
left a comment
richsalz
left a comment
There was a problem hiding this comment.
stderr. or is this also part of your promise upgrade to the simpler test framework ? :)
|
|
||
| ciphers = SSL_CTX_get_ciphers(cctx); | ||
| if (ciphers == NULL || sk_SSL_CIPHER_num(ciphers) != 1) { | ||
| printf("Unexpected ciphers set\n"); |
Contributor
There was a problem hiding this comment.
shouldn't these go to stderr?
Member
Author
There was a problem hiding this comment.
Just being consistent with the rest of the file
Contributor
There was a problem hiding this comment.
yeah, but errors should go to stderr. we waffle: just doing what's already done vs fix it all while you have the file opened. we should about a policy. but like i said, +1 to what you did.
2 tasks
Member
Author
|
Pushed. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
The test loops through all the ciphers, attempting to test each one in turn.
However version negotiation happens before cipher selection, so with TLSv1.3
switched on if we use a non-TLSv1.3 compatible cipher suite we get "no
share cipher".