Conversation
|
This is a very early draft with a bunch of missing pieces |
|
This PR is ready for comments. What needs more detail? What did I forget? Mind you, I'm going on vacation June 23rd -- July 4th, so will not respond much to comments during that period. |
github-actions
bot
added
the
severity: fips change
|
(why the hell did this trigger the fips-change label??????) |
github-actions
bot
removed
the
severity: fips change
|
Thanks, @t8m |
|
I do not yet know the exact conditions when this happens but it has something to do with changes on the to-be-merged-in branch in time of the pushes or in between the pushes. |
t8m
added
triaged: design
The same-ish module as the TX packetizer, handling the opposite direction.
levitte
force-pushed
the
rx-depacketizer
branch
from
05989bb to
e9d8b60
Compare
mattcaswell
left a comment
mattcaswell
left a comment
There was a problem hiding this comment.
Did we discuss this at OTC yet? We probably should do.
paulidale
left a comment
paulidale
left a comment
There was a problem hiding this comment.
Subject to the overview diagram receiving the appropriate renaming.
|
IMO: OTC discussion can happen after this is merged and any changes made in a separate PR. Until OTC review, this should be considered as a draft (perhaps add a comment at the top indicating this, lest this draft be pointed at as canonical). There are too many design documents lingering in an unmerged state. |
paulidale
added
the
approval: done
Agreed, it makes it very difficult to figure out what's what... |
OTOH if we merge them without OTC review they will probably never receive OTC review because we will forget to do it. |
Then maybe we need to start by having these much higher on the priority list of the OTC meetings. |
|
24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually. |
The same-ish module as the TX packetizer, handling the opposite direction. Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Matt Caswell <[email protected]> (Merged from #18610)
Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Matt Caswell <[email protected]> (Merged from #18610)
The same-ish module as the TX packetizer, handling the opposite direction. Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Matt Caswell <[email protected]> (Merged from openssl#18610)
Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Matt Caswell <[email protected]> (Merged from openssl#18610)
From OpenSSL commit d7fed97e37a4a66e8c7d53015684790951f6e943 openssl/openssl#18610 The same-ish module as the TX packetizer, handling the opposite direction.
5 participants
The same-ish module as the TX packetizer, handling the opposite direction.
Ref to companions: #18564 #18570