-
-
Notifications
You must be signed in to change notification settings - Fork 11k
Add d2i_PUBKEY_ex_fp and d2i_PUBKEY_ex_bio #18427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
How does the test actually test that the libctx is used for anything - i.e. the purpose of the variant of the function? |
The test setup loads the NULL provider into the default library context. If you dont use the mainctx it will fall over. |
|
This PR is in a state where it requires action by @openssl/otc but the last update was 30 days ago |
t8m
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved assuming CI passes.
|
Windows was failing due to an applink error. Only change was to test/build.info |
|
@paulidale have you seen this error before in the non-caching? |
This is #18631 - unfortunately we do not know what is causing the failure. |
|
This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago |
|
Unfortunately there are conflicts now, can you please rebase @slontis ? |
|
24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually. |
3907720 to
29c2f95
Compare
|
Still OK |
These functions pass a library content and prop query. The i2d documentation related to these functions has been corrected since the bio and fp functions always return 0 or 1.
|
Rebased to fix merge conflicts.. |
|
This pull request is ready to merge |
These functions pass a library content and prop query. The i2d documentation related to these functions has been corrected since the bio and fp functions always return 0 or 1. Reviewed-by: Hugo Landau <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from #18427)
i2d_XXX_bio and i2d_XXX_fp return either 0 or 1. Other i2d_XXX functions return the number of bytes or negative on error. Reviewed-by: Hugo Landau <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from #18427)
|
@t8m re: doc fix: Sounds good, go ahead. |
|
Cherry-picked the doc fix commit to 3.0 and 3.1 branches. Closing. |
i2d_XXX_bio and i2d_XXX_fp return either 0 or 1. Other i2d_XXX functions return the number of bytes or negative on error. Reviewed-by: Hugo Landau <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from #18427) (cherry picked from commit 943051d)
i2d_XXX_bio and i2d_XXX_fp return either 0 or 1. Other i2d_XXX functions return the number of bytes or negative on error. Reviewed-by: Hugo Landau <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from #18427) (cherry picked from commit 943051d)
These functions pass a library content and prop query. The i2d documentation related to these functions has been corrected since the bio and fp functions always return 0 or 1. Reviewed-by: Hugo Landau <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from openssl#18427)
i2d_XXX_bio and i2d_XXX_fp return either 0 or 1. Other i2d_XXX functions return the number of bytes or negative on error. Reviewed-by: Hugo Landau <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from openssl#18427)
This is in addition to "Introduce use of custom ossl libctx with OpenSSL >= 3.0" OpenSC#2712 pkcs11-tool uses some functions found in libopensc, but does not create a sc_context like other OpenSC tools as the pkcs11 module can be any pkscs11 module. There is one OpenSSL function "d2i_PUBKEY_bio" that does not have an equivalent "d2i_PUBKEY_ex_bio" in 3.0.8, It is listed in OpenSSL master See: openssl/openssl#18427
This is in addition to "Introduce use of custom ossl libctx with OpenSSL >= 3.0" OpenSC#2712 pkcs11-tool uses some functions found in libopensc, but does not create a sc_context like other OpenSC tools as the pkcs11 module can be any pkscs11 module. There is one OpenSSL function "d2i_PUBKEY_bio" that does not have an equivalent "d2i_PUBKEY_ex_bio" in 3.0.8. It is listed in OpenSSL master. See: openssl/openssl#18427 On branch ossl_lib_ctx-pkcs11-tool Changes to be committed: modified: src/tools/pkcs11-tool.c
This is in addition to "Introduce use of custom ossl libctx with OpenSSL >= 3.0" OpenSC#2712 pkcs11-tool uses some functions found in libopensc, but does not create a sc_context like other OpenSC tools as the pkcs11 module can be any pkscs11 module. There is one OpenSSL function "d2i_PUBKEY_bio" that does not have an equivalent "d2i_PUBKEY_ex_bio" in 3.0.8. It is listed in OpenSSL master. See: openssl/openssl#18427 On branch ossl_lib_ctx-pkcs11-tool Changes to be committed: modified: src/tools/pkcs11-tool.c
This is in addition to "Introduce use of custom ossl libctx with OpenSSL >= 3.0" #2712 pkcs11-tool uses some functions found in libopensc, but does not create a sc_context like other OpenSC tools as the pkcs11 module can be any pkscs11 module. There is one OpenSSL function "d2i_PUBKEY_bio" that does not have an equivalent "d2i_PUBKEY_ex_bio" in 3.0.8. It is listed in OpenSSL master. See: openssl/openssl#18427 On branch ossl_lib_ctx-pkcs11-tool Changes to be committed: modified: src/tools/pkcs11-tool.c
Add variants of d2i_PUBKEY_fp and d2i_PUBKEY_bio that pass a library context.
This also fixes some incorrect i2d documentation.
Checklist